Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable better support for infrastructure metrics access #131246

Closed
dannycroft opened this issue Apr 29, 2022 · 1 comment · Fixed by #131326
Closed

Enable better support for infrastructure metrics access #131246

dannycroft opened this issue Apr 29, 2022 · 1 comment · Fixed by #131326
Assignees
@miltonhultgren
Labels
apm:infrastructure-integration apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.3.0

Comments

@dannycroft
Copy link

dannycroft commented Apr 29, 2022 •
edited
Loading

While working on [APM] PoC Extend Kubernetes data available on a service overview and [APM] Infrastructure integration: Show infrastructure metrics for the selected service we quickly realised that we don't have enough infrastructure metric information available to be able to provide enough value with the feature set. To enable us to get more information we need more support from @elastic/infra-monitoring-ui.

After some initial discussions between @elastic/apm-ui and @elastic/infra-monitoring-ui we decided on the following options:

  1. Infrastructure Monitoring UI provides an endpoint that takes a collection of ids and provides extra information on those ids (depending on what's needed)
  2. Infrastructure Monitoring UI provides an already configured (with correct indices) client for us to use

Option 2 was the more favourable option.
@dannycroft dannycroft added Team:APM All issues that need APM UI Team support Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services apm:infrastructure-integration v8.3.0 labels Apr 29, 2022
@miltonhultgren miltonhultgren self-assigned this May 2, 2022
@miltonhultgren
Copy link
Contributor

miltonhultgren commented May 2, 2022 •
edited
Loading

After speaking with Dario in Slack, we agreed that the quickest solution would be to expose a function that simply resolves the current indices to target.

Update: Opened a PR to do just that.

miltonhultgren added a commit to miltonhultgren/kibana that referenced this issue May 2, 2022
@miltonhultgren
[Infra] Add getMetricIndices to start contract (elastic#131246)
a0f0d8d
@miltonhultgren miltonhultgren mentioned this issue May 2, 2022
Merged
miltonhultgren added a commit that referenced this issue May 3, 2022
@miltonhultgren @kibanamachine
[Infra] Add getMetricIndices to start contract (#131326)
71f2099 
* [Infra] Add getMetricIndices to start contract (#131246)

* Remove temporary return variable, change variable name

* Address review comments

* Use Jest Promise mock shorthand

Co-authored-by: Kibana Machine <[email protected]>
academo pushed a commit to academo/kibana that referenced this issue May 4, 2022
@miltonhultgren @kibanamachine
[Infra] Add getMetricIndices to start contract (elastic#131326)
b68fdad 
* [Infra] Add getMetricIndices to start contract (elastic#131246)

* Remove temporary return variable, change variable name

* Address review comments

* Use Jest Promise mock shorthand

Co-authored-by: Kibana Machine <[email protected]>
kertal pushed a commit to kertal/kibana that referenced this issue May 24, 2022
@miltonhultgren @kibanamachine @kertal
[Infra] Add getMetricIndices to start contract (elastic#131326)
ffd5ef8 
* [Infra] Add getMetricIndices to start contract (elastic#131246)

* Remove temporary return variable, change variable name

* Address review comments

* Use Jest Promise mock shorthand

Co-authored-by: Kibana Machine <[email protected]>
@kpatticha kpatticha added the apm:test-plan-done Pull request that was successfully tested during the test plan label Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miltonhultgren miltonhultgren

Labels
apm:infrastructure-integration apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Infra] Add getMetricIndices to start contract miltonhultgren/kibana
3 participants
@dannycroft @miltonhultgren @kpatticha