-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ::
logger context separator with more commonly used .
#13105
Comments
Hey @kjbekkelund, could you please explain a little bit more what you meant here? Do you want to expand only "top-level" properties or what?
test("don't expand nested properties", () => {
const obj = {
'foo.bar': {
'quux.a': 1,
b: 2
}
};
expect(ensureDeepObject(obj)).toEqual({
foo: {
bar: {
'quux.a': 1,
b: 2
}
}
});
}); Another idea is that we can go back to the initial approach and use logging:
appenders:
console:
kind: console
layout:
kind: pattern
highlight: true
root:
level: all
appenders: [console]
loggers:
- context: plugins.pid
level: info
appenders: [file]
- context: server
level: warn |
I see that |
@kjbekkelund would you mind giving me a brief feedback on e6e6dcd? |
Fixed via 052982d |
To make this work we should change config parsing code a bit since
.
in property names is used for nested config objects currently, but it should be doable.The text was updated successfully, but these errors were encountered: