Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded dashboard chrome is visible #13040

Closed
cjcenizal opened this issue Jul 21, 2017 · 1 comment
Closed

Embedded dashboard chrome is visible #13040

cjcenizal opened this issue Jul 21, 2017 · 1 comment
Assignees
@stacey-gammon
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Jul 21, 2017 •
edited
Loading

Kibana version: Master (6.0.0)

Note: To recreate this bug you'll need to create a file locally (or some other alternative) instead of using CodePen, since it looks like they're blocking IFRAMEs.

Embedding a dashboard with this share URL:

<!DOCTYPE html>
<html><body>

<iframe src="http://localhost:5601/eln/app/kibana#/dashboard/036793e0-6dd9-11e7-8071-47df016ec9a9?embed=true&_g=(refreshInterval%3A(display%3AOff%2Cpause%3A!f%2Cvalue%3A0)%2Ctime%3A(from%3Anow-4h%2Cmode%3Aquick%2Cto%3Anow))" height="600" width="800"></iframe>

</body></html>

Results in this IFRAME:

image

Looks like the embed=true flag isn't having the desired effect. We might need to take a closer look at the logic which controls hiding/showing chrome based on embed=true and full screen mode, and make sure there aren’t any conflicts.
@cjcenizal cjcenizal added Feature:Dashboard Dashboard related features :Sharing bug Fixes for quality problems that affect the customer experience labels Jul 21, 2017
@stacey-gammon
Copy link
Contributor

Full screen mode broke this. I'll add a test to ensure this doesn't happen again as this is the second time it's been broken by something directly setting the visibility of the chrome and overriding the embed parameter.

@stacey-gammon stacey-gammon self-assigned this Aug 1, 2017
stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Aug 1, 2017
@stacey-gammon
Make sure no one can show the chrome if the default setting is hidden.
e4842bf 
add tests

Fixes elastic#13040
@stacey-gammon stacey-gammon mentioned this issue Aug 1, 2017
Merged
stacey-gammon added a commit that referenced this issue Aug 3, 2017
@stacey-gammon
Make sure no one can show the chrome if the default setting is hidden. (
4f5313a 
#13250)

* Make sure no one can show the chrome if the default setting is hidden.

add tests

Fixes #13040

* Improve variable and function names and fix tests
stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Aug 3, 2017
@stacey-gammon
Make sure no one can show the chrome if the default setting is hidden. (
9d6a184 
elastic#13250)

* Make sure no one can show the chrome if the default setting is hidden.

add tests

Fixes elastic#13040

* Improve variable and function names and fix tests
stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Aug 3, 2017
@stacey-gammon
Make sure no one can show the chrome if the default setting is hidden. (
6d8d4b4 
elastic#13250)

* Make sure no one can show the chrome if the default setting is hidden.

add tests

Fixes elastic#13040

* Improve variable and function names and fix tests
This was referenced Aug 3, 2017
Merged
Merged
stacey-gammon added a commit that referenced this issue Aug 3, 2017
@stacey-gammon
Make sure no one can show the chrome if the default setting is hidden. (
7e5d2c4 
#13250) (#13317)

* Make sure no one can show the chrome if the default setting is hidden.

add tests

Fixes #13040

* Improve variable and function names and fix tests
stacey-gammon added a commit that referenced this issue Aug 3, 2017
@stacey-gammon
Make sure no one can show the chrome if the default setting is hidden. (
d57bfe2 
#13250) (#13316)

* Make sure no one can show the chrome if the default setting is hidden.

add tests

Fixes #13040

* Improve variable and function names and fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stacey-gammon stacey-gammon

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjcenizal @stacey-gammon