Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] ensure rum_allow_origins setting only saves valid YAML strings #128703

Closed
ogupte opened this issue Mar 29, 2022 · 0 comments · Fixed by #128704
Closed

[APM] ensure rum_allow_origins setting only saves valid YAML strings #128703

ogupte opened this issue Mar 29, 2022 · 0 comments · Fixed by #128704
Assignees
@ogupte
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v8.2.0

Comments

@ogupte
Copy link
Contributor

ogupte commented Mar 29, 2022 •
edited by zube bot
Loading

Ensures that the text values set in the rum_allow_origins setting (apm-server.rum.allow_origins) will be checked if they are valid YAML strings and then wrapped in quotes if not. This fixes the bug #121934 that would fail when the user attempts to migrate from classic indices / standalong APM server to a fleet-managed APM server agent policy. The fix validates and updates the settings values only when a user attempts the migration.
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 29, 2022
@ogupte ogupte added the Team:APM All issues that need APM UI Team support label Mar 29, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 29, 2022
@ogupte ogupte added needs-team Issues missing a team label v8.2.0 labels Mar 29, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 29, 2022
@ogupte ogupte added release_note:fix needs-team Issues missing a team label labels Mar 29, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 29, 2022
@ogupte ogupte self-assigned this Mar 29, 2022
ogupte added a commit to ogupte/kibana that referenced this issue Mar 29, 2022
@ogupte
[APM] ensure rum_allow_origins setting only saves valid YAML strings (e…
b5bcdbc 
…lastic#128703)
@ogupte ogupte added bug Fixes for quality problems that affect the customer experience and removed release_note:fix labels Mar 29, 2022
@ogupte ogupte mentioned this issue Mar 29, 2022
Merged
ogupte added a commit to ogupte/kibana that referenced this issue Mar 29, 2022
@ogupte
[APM] ensure rum_allow_origins setting only saves valid YAML strings (e…
b65568c 
…lastic#128703)
@ogupte ogupte mentioned this issue Mar 29, 2022
Merged
ogupte added a commit that referenced this issue Mar 29, 2022
@ogupte
[APM] ensure rum_allow_origins setting only saves valid YAML strings (#…
92aea76 
…128703) (#128704)
ogupte added a commit that referenced this issue Mar 29, 2022
@ogupte
[APM] ensure rum_allow_origins setting only saves valid YAML strings (#…
79039db 
…128703) (#128707)
ogupte added a commit to ogupte/kibana that referenced this issue Mar 29, 2022
@ogupte
[APM] ensure rum_allow_origins setting only saves valid YAML strings (e…
aac0d2a 
…lastic#128703) (elastic#128707)

(cherry picked from commit 79039db)
ogupte added a commit that referenced this issue Mar 29, 2022
@ogupte
[APM] ensure rum_allow_origins setting only saves valid YAML strings (#…
19006c4 
…128703) (#128707) (#128756)

(cherry picked from commit 79039db)
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogupte ogupte

Labels
apm:test-plan-done Pull request that was successfully tested during the test plan bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] ensure rum_allow_origins setting only saves valid YAML strings ogupte/kibana
2 participants
@dannycroft @ogupte