Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Enable JavaRuntimeAttacher component in Fleet UI integration #127414

Closed
ogupte opened this issue Mar 10, 2022 · 4 comments · Fixed by #127790
Closed

[APM] Enable JavaRuntimeAttacher component in Fleet UI integration #127414

ogupte opened this issue Mar 10, 2022 · 4 comments · Fixed by #127790
Assignees
Labels
apm:fleet apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.2.0

Comments

@ogupte
Copy link
Contributor

ogupte commented Mar 10, 2022

Lines 23 and 60 should be uncommented to enable the JavaRuntimAttachment component to be displayed with the Java Agent tutorial in the APM Fleet integration:

// TODO: Uncomment once https://github.com/elastic/beats/issues/29631 has been closed
// import { JavaRuntimeAttachment } from './runtime_attachment/supported_agents/java_runtime_attachment';
import {
NewPackagePolicy,
PackagePolicy,
PackagePolicyEditExtensionComponentProps,
} from '../apm_policy_form/typings';
export interface AgentRuntimeAttachmentProps {
policy: PackagePolicy;
newPolicy: NewPackagePolicy;
onChange: PackagePolicyEditExtensionComponentProps['onChange'];
}
export type CreateAgentInstructions = (
apmServerUrl?: string,
secretToken?: string
) => Array<{
title: string;
textPre?: string;
commands?: string[];
textPost?: string;
customComponentName?: string;
}>;
export const ApmAgentInstructionsMappings: Array<{
agentName: AgentName;
title: string;
variantId: string;
createAgentInstructions: CreateAgentInstructions;
AgentRuntimeAttachment?: ComponentType<AgentRuntimeAttachmentProps>;
}> = [
{
agentName: 'java',
title: 'Java',
variantId: 'java',
createAgentInstructions: createJavaAgentInstructions,
// TODO: Uncomment once https://github.com/elastic/beats/issues/29631 has been closed
// AgentRuntimeAttachment: JavaRuntimeAttachment,

This is current blocked on the availability with APM Server: elastic/apm-server#7023 No longer blocked

@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 10, 2022
@ogupte ogupte added apm:fleet and removed needs-team Issues missing a team label labels Mar 10, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 10, 2022
@ogupte ogupte added Team:APM All issues that need APM UI Team support and removed needs-team Issues missing a team label labels Mar 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@ogupte ogupte changed the title [APM] Enable JavaRuntimeAttacher component in Fleet integration [APM] Enable JavaRuntimeAttacher component in Fleet UI integration Mar 10, 2022
@felixbarny
Copy link
Member

With elastic/apm-server#7305 being resolved, I don't think this issue is blocked. @stuartnelson3 or @simitt, can you confirm that?

What's the best way to test this end-to-end once the UI component is enabled? Can someone from the UI or Server team do some basic testing with the Java agent team doing more extensive testing?

@simitt
Copy link
Contributor

simitt commented Mar 15, 2022

Agree, I am not aware of anything blocking from the apm-server side at this point.

What's the best way to test this end-to-end once the UI component is enabled? Can someone from the UI or Server team do some basic testing with the Java agent team doing more extensive testing?

How about creating a gh issue describing all the test cases and how to verify if everything works as expected. We can then derive automated tests and docs from this?

@felixbarny
Copy link
Member

We have some test case definitions here: elastic/apm-agent-java#2196 (comment)

But also, would you recommend testing this on staging cloud or with apm-integration-testing? What are the steps to get a stack up and running?

@sorenlouv sorenlouv added the 8.2 candidate considered, but not committed, for 8.2 release label Mar 15, 2022
@ogupte ogupte self-assigned this Mar 15, 2022
@dannycroft dannycroft added v8.2.0 apm:test-plan-8.2.0 and removed 8.2 candidate considered, but not committed, for 8.2 release labels Apr 4, 2022
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:fleet apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants