-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Rule information is not displayed under rule details page after deleted the rule #122013
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Related issue: #120562 |
…ed Rule from Alert with flattened structure (#122619) ## Summary Resolves #122013 by transforming flattened `alertHit` back to a `Rule` using the existing `expandDottedObject` utility (which was moved to `security_solution/common/utils` for global use). Also fixed margins on deleted badge (and ensured no overlap when title overflows). <p align="center"> <img width="500" src="https://user-images.githubusercontent.com/2946766/148868172-f8af8340-f49c-46e3-8cd6-4ebb38d7d76f.png" /> </p> ## Test Instructions: * Create Rule with all available fields filled out * Generate alerts for Rule * Delete Rule and navigate to Rule Details from Alert Details * Verify `Deleted` badge is present and Rule Details are filled out again Test with 7.x and 8.x alerts (as backwards compatibility was kept)
…ed Rule from Alert with flattened structure (elastic#122619) ## Summary Resolves elastic#122013 by transforming flattened `alertHit` back to a `Rule` using the existing `expandDottedObject` utility (which was moved to `security_solution/common/utils` for global use). Also fixed margins on deleted badge (and ensured no overlap when title overflows). <p align="center"> <img width="500" src="https://user-images.githubusercontent.com/2946766/148868172-f8af8340-f49c-46e3-8cd6-4ebb38d7d76f.png" /> </p> ## Test Instructions: * Create Rule with all available fields filled out * Generate alerts for Rule * Delete Rule and navigate to Rule Details from Alert Details * Verify `Deleted` badge is present and Rule Details are filled out again Test with 7.x and 8.x alerts (as backwards compatibility was kept) (cherry picked from commit 6392a05)
…ed Rule from Alert with flattened structure (#122619) (#122893) ## Summary Resolves #122013 by transforming flattened `alertHit` back to a `Rule` using the existing `expandDottedObject` utility (which was moved to `security_solution/common/utils` for global use). Also fixed margins on deleted badge (and ensured no overlap when title overflows). <p align="center"> <img width="500" src="https://user-images.githubusercontent.com/2946766/148868172-f8af8340-f49c-46e3-8cd6-4ebb38d7d76f.png" /> </p> ## Test Instructions: * Create Rule with all available fields filled out * Generate alerts for Rule * Delete Rule and navigate to Rule Details from Alert Details * Verify `Deleted` badge is present and Rule Details are filled out again Test with 7.x and 8.x alerts (as backwards compatibility was kept) (cherry picked from commit 6392a05) Co-authored-by: Garrett Spong <[email protected]>
@deepikakeshav-qasource can you please validate the fix of this issue on 8.0.0 branch? Thanks! :) |
Hi @MadameSheema , We have validated this issue on 8.0.0 branch and observed that issue is Partially Fixed. Rule information is displayed. however, error message is displayed under rule details of deleted rule Please find the below testing details: Build Details:
Screencast: rule_delete.mp4Observation on 7.16.0 Screencast: Alerts.-.Delete_7.16.0.mp4Thanks!! |
@spong can you please take a look at the above observation? Thanks :) |
Checked out latest Lines 47 to 51 in 6c3dcb6
kibana/packages/kbn-securitysolution-t-grid/src/utils/api/index.ts Lines 40 to 42 in 4fa3dc4
So the question here is why are you seeing a Are there any additional steps you may be taking in recreation here that could be resulting in this behavior @deepikakeshav-qasource? Did the rule have any historical failures (shown in the |
Hi @spong ,
No, We did not performed any additional steps. We created the custom query rule then generate the alerts and delete the rule.
No, Not any historical failures is displayed in Failure history tab before deleted. Please find below screencast for same.
This is not upgrade path, we have tested on
No, We only able to see this error on deleted rule. please find the below screencast. Screencast: Rules_delete1.mp4Please let us know if any other information is required from our end. :) Thanks!! |
Hrmm, still no luck reproducing against latest (commit 29165d5). Still getting When you say |
Hi @spong , Earlier latest changes were not merged to the cloud build. So we tested this ticket on We use the Today, the latest changes are merged on cloud and we also tested the same on cloud build and facing the same issue. Please find the below details: Build Details:
Screencast: Rules.mp4Please let us know if we can share the build details through email. Thanks!! |
@spong @banderror any update on this issue? Thanks! |
@MadameSheema -- I've been unable to reproduce the reported |
Sounds good to me @spong, lots of thanks for the clarification :) |
Validated BC 8.15 and wasn't able to reproduce. Keeping this open due to @spong comment above. |
We can probably close this then. There's a bit of history here and if we can't reproduce now it might be best to just open a new issue if/when it surfaces again. Going to swap assignments to @banderror since I'm on a different team now. |
Unable to repro, closing. |
Describe the bug
Rule information is not displayed under rule details page after deleted the rule
Build Details:
Browser Details:
N/A
Preconditions
Steps to Reproduce
Actual Result
Rule information is not displayed under rule details page after deleted the rule
Expected Result
Rule information should be displayed under rule details page after deleted the rule
What's Working
What's Not Working
Screen-Shot
The text was updated successfully, but these errors were encountered: