Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Builder interval should use dateFormat:tz #12113

Closed
LeeDr opened this issue May 31, 2017 · 3 comments · Fixed by #13378
Closed

Visual Builder interval should use dateFormat:tz #12113

LeeDr opened this issue May 31, 2017 · 3 comments · Fixed by #13378
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@LeeDr
Copy link

LeeDr commented May 31, 2017

Kibana version: master

Elasticsearch version: master

Server OS version: Ubuntu 14.04

Browser version: Chrome

Browser OS version: Windows 10

Original install method (e.g. download page, yum, from source, etc.): .deb packages from SNAPSHOT builds

Description of the problem including expected versus actual behavior:
As reported here;
https://discuss.elastic.co/t/changing-the-1d-interval-in-visual-builder/87134

Selecting a 1d interval in the Visual Builder seems to always select the time range based on UTC and then show that in the users local time (assuming dateFormat:tz is left at the default browser setting).
So if I'm in the US Central Time zone (-5) then my day buckets will show 7PM to 7PM instead of 00:00:00 or 12AM.

If I leave the default dateFormat:tz: browser it looks wrong to me;
image

And with the same browser setting other Kibana visualizations show 00:00:00 for the start time if a Daily interval;
image

If I set my dateFormat:tz: utc
image

Steps to reproduce:

  1. With your computer clock set to something other than UTC, load some test data (at least a couple of days) and Kibana with the default browser setting for dateFormat:tz
  2. Create a new Visualization and select Visual Builder
  3. Go to Panel Options tab and change the interval to 1d
  4. Go back to Data tab and change something else (like the Label) to get the chart to update.
  5. Mouse over the dots on the line as shown in the images above.

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

@LeeDr LeeDr added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience labels May 31, 2017
@ElWoodyl
Copy link

ElWoodyl commented Jul 4, 2017

Hello,

I think I have the same issue, I set the time range at this week or the previous week with interval 1d and I draw a bar chart. This returns a bit of the day before the begin of my time range and the last day seems to be missing in my case.

image

image
Here the first bar seems to represent a few hours of Jun 25 which is out of my interval range and July 2nd is missing.

@TheExorcista
Copy link

I have the same issue, but I've notice when I modify the time range, visual builder gives me different data from same time period.

simianhacker added a commit to simianhacker/kibana that referenced this issue Aug 7, 2017
@simianhacker simianhacker self-assigned this Aug 9, 2017
simianhacker added a commit that referenced this issue Aug 14, 2017
…13378)

* Fixes #12113 - Add timezone to date histogram aggregations

* Fixing tests

* Fixing tests

* Moving to universal timezone function
simianhacker added a commit that referenced this issue Aug 14, 2017
…13378)

* Fixes #12113 - Add timezone to date histogram aggregations

* Fixing tests

* Fixing tests

* Moving to universal timezone function
simianhacker added a commit that referenced this issue Aug 14, 2017
…13378)

* Fixes #12113 - Add timezone to date histogram aggregations

* Fixing tests

* Fixing tests

* Moving to universal timezone function
@fjiang212
Copy link

Do you plan to back port to 5.5.x? I am using 5.5.1 and found similar problem. Last day bar is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants