Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Inject internal configuration per consuming app #120931

Open
Tracked by #120920
weltenwort opened this issue Dec 9, 2021 · 1 comment
Open
Tracked by #120920

[Logs UI] Inject internal configuration per consuming app #120931

weltenwort opened this issue Dec 9, 2021 · 1 comment
Labels
Feature:Logs Settings Feature:Logs UI Logs UI feature Team:obs-ux-logs Observability Logs User Experience Team

Comments

@weltenwort
Copy link
Member

weltenwort commented Dec 9, 2021 •
edited
Loading

📓 Summary

Several usage sites of the shared log stream component rely on the default log view to be suitable for them. To prevent customization of the default log view by the user from breaking these components, the consumers of the component should define their own log view via the provided logViews.defineInternalLogView() function on the infra plugin's setup contract.

part of #120920

✔️ Acceptance criteria

  • All usage sites by other plugins of the shared log view component within the Kibana codebase inject their log view configuration via the logViews.defineInternalLogView() function on the infra plugin's setup contract.
  • The stack monitoring plugin's usage of the predecessor defineInternalSourceConfiguration() is replaced by an equivalent call to logViews.defineInternalLogView().

💡 Background

Possible usage sites:

  • APM
  • Metrics UI
  • Upgrade assistant
  • Fleet
  • Stack Monitoring (already uses the predecessor, needs to be migrated)
@weltenwort weltenwort mentioned this issue Dec 9, 2021
Closed
7 tasks
@weltenwort weltenwort added Feature:Logs UI Logs UI feature needs-refinement A reason and acceptance criteria need to be defined for this issue Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Dec 9, 2021
@weltenwort weltenwort changed the title Inject internal configuration per consuming app (APM, metrics, Upgrade assistant, Fleet, who else?, Stack Monitoring) [Logs UI] Inject internal configuration per consuming app Dec 9, 2021
@weltenwort weltenwort mentioned this issue May 16, 2022
Closed
@weltenwort weltenwort removed the needs-refinement A reason and acceptance criteria need to be defined for this issue label May 16, 2022
@gbamparop gbamparop added Team:obs-ux-logs Observability Logs User Experience Team and removed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Nov 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot added needs-team Issues missing a team label and removed needs-team Issues missing a team label labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Logs Settings Feature:Logs UI Logs UI feature Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weltenwort @gbamparop @elasticmachine