Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Make configuration ID required in Log Stream component #120930

Closed
Tracked by #120920
weltenwort opened this issue Dec 9, 2021 · 0 comments · Fixed by #134850
Closed
Tracked by #120920

[Logs UI] Make configuration ID required in Log Stream component #120930

weltenwort opened this issue Dec 9, 2021 · 0 comments · Fixed by #134850
Assignees
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

weltenwort commented Dec 9, 2021

📓 Summary

Currently the source configuration id of the shared log stream component defaults to default. In order to prepare for #120920 and #120931, this reference should be made explicit.

part of #120920

✔️ Acceptance criteria

  • The shared log stream component's optional sourceId property is replaced by a required logView property.
  • The new logView property accepts values of type { type: 'log-view-reference'; logViewId: string; } (in preparation for [Logs UI] Inject internal configuration per consuming app #120931).
  • All current usage sites of the log view are updated to include a log view reference.

⏩ Follow-up tasks

@weltenwort weltenwort changed the title Make configuration ID required in Log Stream component (else show error state) [Logs UI] Make configuration ID required in Log Stream component Dec 9, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 9, 2021
@weltenwort weltenwort added Feature:Logs UI Logs UI feature needs-refinement A reason and acceptance criteria need to be defined for this issue Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services and removed needs-team Issues missing a team label labels Dec 9, 2021
@weltenwort weltenwort removed the needs-refinement A reason and acceptance criteria need to be defined for this issue label May 16, 2022
@crespocarlos crespocarlos self-assigned this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants