Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] The long rule name breaks the UI structure under exception tab in rule details page #119012

Closed
ghost opened this issue Nov 18, 2021 · 10 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.0.1 v8.1.0

Comments

@ghost
Copy link

ghost commented Nov 18, 2021

Describe the bug
The long rule name breaks the UI structure under exception tab in rule details page

Build Details:
Version:7.16.0 BC5
Build: 46061
COMMIT: f13296d

Browser Details:
N/A

Preconditions

  1. Kibana should be running
  2. Rule should be created with long name
  3. Alerts should be generated from created rule

Steps to Reproduce

  1. Navigate to Alerts tab of security tab
  2. Click on more action icon of generated alerts
  3. Add the rule exception
  4. Navigate to rule details page and click on exception tab
  5. Observe that long rule name breaks the UI structure under exception tab in rule details page

Actual Result
The long rule name breaks the UI structure under exception tab in rule details page

Expected Result
UI should not be break with long rule name under exception tab in rule details page

What's Working

  • N/A

What's Not Working

  • N/A

Screen-Shots

Rule Name with Space:
image

Rule Name Without Space:
image

@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Nov 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost added v7.16.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Nov 18, 2021
@ghost ghost assigned ghost and MadameSheema and unassigned ghost Nov 18, 2021
@MadameSheema
Copy link
Member

@deepikakeshav-qasource can you please try to reproduce the same with a long rule name but with spaces on it? Thanks

@ghost
Copy link
Author

ghost commented Nov 22, 2021

Hi @MadameSheema ,

Yes, Issue is also occurring with long rule name with spaces. I have also shared the observations in bug as well.

image

Please let us know if anything else is required from our end.

Thanks!!

@spong
Copy link
Member

spong commented Nov 23, 2021

Here's an issue covering other remaining max-length and overflow issues between the Rule Creation, Edit, and Details pages: #119402

@spong
Copy link
Member

spong commented Jan 7, 2022

@jethr0null -- users are running into this issue in the discuss forums, so we should prioritize accordingly. Fix is low impact and low LOE, so can probably bundle in with the other overflow issues outlined in #119402 and tackle post-FF for 8.1.

@jethr0null
Copy link

Thanks for flagging this. cc @peluja1012 for scheduling consideration

@MadameSheema MadameSheema added v8.0.1 and removed v8.0.0 labels Feb 8, 2022
@yctercero yctercero self-assigned this Feb 9, 2022
yctercero added a commit that referenced this issue Feb 10, 2022
…125145)

### Summary

Addresses #119012

- updates exception item viewer UI
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Feb 10, 2022
…lastic#125145)

### Summary

Addresses elastic#119012

- updates exception item viewer UI

(cherry picked from commit dba7207)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Feb 10, 2022
…lastic#125145)

### Summary

Addresses elastic#119012

- updates exception item viewer UI

(cherry picked from commit dba7207)
@yctercero
Copy link
Contributor

PR merged, backports running now!

kibanamachine added a commit that referenced this issue Feb 10, 2022
…125145) (#125176)

### Summary

Addresses #119012

- updates exception item viewer UI

(cherry picked from commit dba7207)

Co-authored-by: Yara Tercero <[email protected]>
kibanamachine added a commit that referenced this issue Feb 10, 2022
…125145) (#125177)

### Summary

Addresses #119012

- updates exception item viewer UI

(cherry picked from commit dba7207)

Co-authored-by: Yara Tercero <[email protected]>
@MadameSheema
Copy link
Member

@deepikakeshav-qasource can you please validate this on 8.1.0BC3? Thanks :)

@ghost
Copy link
Author

ghost commented Feb 17, 2022

Hi @MadameSheema ,

We have validated this issue on 8.1.0 BC3 build. and found that issue is fixed.

Build Details:

Version: 8.1.0-BC3
Commit:0335dd6a26ef29ae9021d0fae9347dc88f3b7d6e
Build:50346

Screenshots

image

Hence, we are closing this issue and marking as QA Validated.

Thanks!

@ghost ghost added the QA:Validated Issue has been validated by QA label Feb 17, 2022
@ghost ghost closed this as completed Feb 17, 2022
@ghost
Copy link
Author

ghost commented Feb 22, 2022

Hi @MadameSheema

We have validated this issue on 8.0.1 BC1 and found it still Fixed. ✔️

Please find below the testing details:

Build Details:

Version: 8.0.1
Commit: f4b44d7eb7355c9d1e38d9f2dc753b3fe10c601c
Build: 49342

Screenshot:

image

Thanks !!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.0.1 v8.1.0
Projects
None yet
Development

No branches or pull requests

5 participants