Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/users·ts - security app users edit Deactivate/Activate user deactivates user when confirming #118728

Closed
kibanamachine opened this issue Nov 16, 2021 · 13 comments · Fixed by #132465
Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 16, 2021

A test failed on a tracked branch

Error: expected true to equal false
    at Assertion.assert (/opt/local-ssd/buildkite/builds/kb-cigroup-6-dbccfa29bbbe05c0/elastic/kibana-hourly/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/opt/local-ssd/buildkite/builds/kb-cigroup-6-dbccfa29bbbe05c0/elastic/kibana-hourly/kibana/node_modules/@kbn/expect/expect.js:227:8)
    at Assertion.be (/opt/local-ssd/buildkite/builds/kb-cigroup-6-dbccfa29bbbe05c0/elastic/kibana-hourly/kibana/node_modules/@kbn/expect/expect.js:69:22)
    at Context.<anonymous> (test/functional/apps/security/users.ts:206:49)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (/opt/local-ssd/buildkite/builds/kb-cigroup-6-dbccfa29bbbe05c0/elastic/kibana-hourly/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

First failure: CI Build - 7.16

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Nov 16, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 16, 2021
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.0

@mistic mistic added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Dec 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 6, 2021
@jportner
Copy link
Contributor

jportner commented Dec 6, 2021

Both of the recent failures:

Error: expected true to equal false
    at Assertion.assert (/opt/local-ssd/buildkite/builds/kb-n2-4-2c0b4686fbf8f9e0/elastic/kibana-hourly/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/opt/local-ssd/buildkite/builds/kb-n2-4-2c0b4686fbf8f9e0/elastic/kibana-hourly/kibana/node_modules/@kbn/expect/expect.js:227:8)
    at Assertion.be (/opt/local-ssd/buildkite/builds/kb-n2-4-2c0b4686fbf8f9e0/elastic/kibana-hourly/kibana/node_modules/@kbn/expect/expect.js:69:22)
    at Context.<anonymous> (test/functional/apps/security/users.ts:208:49)

Screenshot:

image

The test edits the user, clicks "Deactivate user", confirms the modal, and clicks "Update user" to return to the users page.
The user's Status column should now show a "Disabled" badge, but it doesn't.

Assertion:

expect(users.OptionalUser.enabled).to.be(false);

It seems like the user is being updated but we aren't waiting for an index refresh, so we query again too quickly and this is the result.
Since we are using the Elasticsearch API to update a user, we don't have the ability to specify a refresh flag.

I hate to suggest this but it might be prudent to wait for a couple of seconds before we click the "Update user" button to return to the page. WDYT @XavierM ?

@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort labels Dec 8, 2021
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.17

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.0

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Jan 18, 2022
mistic added a commit that referenced this issue Jan 18, 2022
@mistic
Copy link
Member

mistic commented Jan 18, 2022

This test keeps failing and looks flaky. Skipping for now.

main: d296c6f
8.0: f18a138
7.17: 55988cb

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.17

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.17

spalger pushed a commit that referenced this issue Jan 26, 2022
(cherry picked from commit f18a138)
@spalger
Copy link
Contributor

spalger commented Jan 26, 2022

backported skip to 7.17 55988cb

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - 8.x

@azasypkin
Copy link
Member

Duplicate of #199483 (afterAll that is failing is the same these tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants