Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search Sessions][Discover] Search sessions with relative time range won't restore in discover #112562

Closed
Dosant opened this issue Sep 20, 2021 · 2 comments · Fixed by #112588
Closed

[Search Sessions][Discover] Search sessions with relative time range won't restore in discover #112562

Dosant opened this issue Sep 20, 2021 · 2 comments · Fixed by #112588
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:Search Sessions Feature:Search Querying infrastructure in Kibana impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort regression v7.15.0

Comments

@Dosant
Copy link
Contributor

Dosant commented Sep 20, 2021 •
edited
Loading

Kibana version: master, 7.16 (7.15.?, 7.14.? potentially)

Description of the problem including expected versus actual behavior:

Restoring a discover search session with a relative time range won't restore searches, but will run new searches instead with Your search session is still running warning

Steps to reproduce:

  1. Run a search with relative time range
  2. Save a session
  3. Go to management. Reload the page to clear a client-side cache.
  4. Restore a session
  5. See the warning and check-in search response isRestore: true

Additional context

Restoring a relative time search session worked the following way:

  1. Discover on the client transforms relative time to an absolute time range
  2. Absolute time range becomes part of search payload
  3. Absolute time range is saved as part of a search session
  4. Session is restored using absolute time range.

Looks like this doesn't work anymore because in #110459 discover starts sending relative time range as part of a search payload, but the whole search session restoration flow relies on the absolute time range inside the payload. Payloads, when a search is first run and then restored, don't match anymore and the search session cannot be restored.

cc @elastic/kibana-app-services & @elastic/kibana-data-discovery
@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana Feature:Discover Discover Application regression Team:AppServices labels Sep 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@Dosant Dosant mentioned this issue Sep 20, 2021
Closed
@jloleysens jloleysens mentioned this issue Sep 20, 2021
Merged
1 task
@jloleysens
Copy link
Contributor

Did an investigation and I believe only 7.14.2 will be affected after we have merged #112588

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Sep 21, 2021
KOTungseth added a commit to KOTungseth/kibana that referenced this issue Sep 21, 2021
@KOTungseth
[DOCS] Adds elastic#112562 known issue to 7.14.2 release notes
9e2411d
@KOTungseth KOTungseth mentioned this issue Sep 21, 2021
Merged
KOTungseth added a commit that referenced this issue Sep 23, 2021
@KOTungseth @jloleysens
[DOCS] Adds #112562 known issue to 7.14.2 release notes (#112744)
819c670 
* [DOCS] Adds #112562 known issue to 7.14.2 release notes

* Update docs/CHANGELOG.asciidoc

Co-authored-by: Jean-Louis Leysens <[email protected]>

Co-authored-by: Jean-Louis Leysens <[email protected]>
KOTungseth added a commit to KOTungseth/kibana that referenced this issue Sep 23, 2021
@KOTungseth
[7.15] [DOCS] Adds elastic#112562 known issue to 7.14.2 release notes (…
105bd5f 
…elastic#112744)
@KOTungseth KOTungseth mentioned this issue Sep 23, 2021
Merged
KOTungseth added a commit to KOTungseth/kibana that referenced this issue Sep 23, 2021
@KOTungseth
[7.x] [DOCS] Adds elastic#112562 known issue to 7.14.2 release notes (e…
973b601 
…lastic#112744)
@KOTungseth KOTungseth mentioned this issue Sep 23, 2021
Merged
KOTungseth added a commit that referenced this issue Sep 23, 2021
@KOTungseth
[7.15] [DOCS] Adds #112562 known issue to 7.14.2 release notes (#112744…
a0e2981 
…) (#113005)
KOTungseth added a commit that referenced this issue Sep 23, 2021
@KOTungseth
[7.x] [DOCS] Adds #112562 known issue to 7.14.2 release notes (#112744)…
c33fe03 
… (#113006)
@Dosant Dosant added the v7.15.0 label Sep 29, 2021
jloleysens added a commit that referenced this issue Sep 29, 2021
@jloleysens
Revert "[DOCS] Adds #112562 known issue to 7.14.2 release notes (#112744
a6f7998 
)"

This reverts commit 819c670.
jloleysens added a commit that referenced this issue Oct 4, 2021
@jloleysens
Partial revert "[DOCS] Adds #112562 known issue to 7.14.2 release not…
b92eb1e 
…es" (#113441)

* Revert "[DOCS] Adds #112562 known issue to 7.14.2 release notes (#112744)"

This reverts commit 819c670.

* Keep removal of "coming" copy
@jloleysens jloleysens mentioned this issue Oct 4, 2021
Merged
jloleysens added a commit to jloleysens/kibana that referenced this issue Oct 4, 2021
@jloleysens
Partial revert "[DOCS] Adds elastic#112562 known issue to 7.14.2 rele…
9a2a78d 
…ase notes" (elastic#113441)

* Revert "[DOCS] Adds elastic#112562 known issue to 7.14.2 release notes (elastic#112744)"

This reverts commit 819c670.

* Keep removal of "coming" copy
# Conflicts:
#	docs/CHANGELOG.asciidoc
jloleysens added a commit to jloleysens/kibana that referenced this issue Oct 4, 2021
@jloleysens
Partial revert "[DOCS] Adds elastic#112562 known issue to 7.14.2 rele…
a794375 
…ase notes" (elastic#113441)

* Revert "[DOCS] Adds elastic#112562 known issue to 7.14.2 release notes (elastic#112744)"

This reverts commit 819c670.

* Keep removal of "coming" copy
@jloleysens jloleysens mentioned this issue Oct 4, 2021
Merged
jloleysens added a commit to jloleysens/kibana that referenced this issue Oct 4, 2021
@jloleysens
Revert "Partial revert "[DOCS] Adds elastic#112562 known issue to 7.1…
b9a67fd 
…4.2 release notes" (elastic#113441)"

This reverts commit a794375.
@exalate-issue-sync exalate-issue-sync bot changed the title [Search Sessions][Discover] Search sessions with relative time range won't restore in discover [Search Sessions][Discover] Search sessions with relative time range won't restore in discover Oct 4, 2021
jloleysens added a commit that referenced this issue Oct 5, 2021
@jloleysens
Partial revert "[DOCS] Adds #112562 known issue to 7.14.2 release not…
5745dca 
…es" (#113441) (#113724)

* Revert "[DOCS] Adds #112562 known issue to 7.14.2 release notes (#112744)"

This reverts commit 819c670.

* Keep removal of "coming" copy
# Conflicts:
#	docs/CHANGELOG.asciidoc
jloleysens added a commit that referenced this issue Oct 5, 2021
@jloleysens
[7.15] Partial revert "[DOCS] Adds #112562 known issue to 7.14.2 rele…
5c15a98 
…ase notes" (#113441) (#113725)

* Partial revert "[DOCS] Adds #112562 known issue to 7.14.2 release notes" (#113441)

* Revert "[DOCS] Adds #112562 known issue to 7.14.2 release notes (#112744)"

This reverts commit 819c670.

* Keep removal of "coming" copy

* Revert "Partial revert "[DOCS] Adds #112562 known issue to 7.14.2 release notes" (#113441)"

This reverts commit a794375.

* remove just the known issues, do not change white spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:Search Sessions Feature:Search Querying infrastructure in Kibana impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort regression v7.15.0
Projects
None yet
Milestone
No milestone
4 participants
@lukasolson @Dosant @jloleysens @elasticmachine