Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kibanaAppServices] Remove export* syntax from plugin index files #110897

Closed
17 of 20 tasks
spalger opened this issue Sep 1, 2021 · 2 comments
Closed
17 of 20 tasks

[kibanaAppServices] Remove export* syntax from plugin index files #110897

spalger opened this issue Sep 1, 2021 · 2 comments
Labels
chore impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@spalger
Copy link
Contributor

spalger commented Sep 1, 2021

See #57370 for reasoning, but the gist is that export * usage leads to unexpected and excessive exports from the plugin, leading the public API to grow and increasing the cost of maintaining backwards compatibility.

#109357 implements an ESLint rule to check for this that also assists in fixing the rule, though the auto-fix is imperfect and will require some manual review before committing.

Please remove the /* eslint-disable @kbn/eslint/no_export_all */ comment(s) added in #109357 from the relevant files, validate the auto-fix, remove unnecessary exports, and then submit a PR. Thank you!

Hint: You can search for the URL of this issue to find specific occurrences


For each plugin:

  • In server/index.ts, public/index.ts and common/index.ts folders for each plugin below, repalce * exports by a named export for each thing.
  • Do not export things that are not used by other plugins.
  • Some plugins might not need any action, so just tick it.

Plugins to check:

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Sep 10, 2021
@mattkime
Copy link
Contributor

exalate is a great way to accidentally close issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

No branches or pull requests

4 participants