Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lens should register expression functions in setup contract #106510

Closed
ppisljar opened this issue Jul 22, 2021 · 1 comment · Fixed by #110639
Closed

lens should register expression functions in setup contract #106510

ppisljar opened this issue Jul 22, 2021 · 1 comment · Fixed by #110639
Assignees
@alexwizp
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@ppisljar
Copy link
Member

ppisljar commented Jul 22, 2021 •
edited
Loading

lens expression functions are currently registered too late. they should be registered in setup life cycle to enable #106509

as functions are registered too late this will prevent us to run migrations on them, do reference extraction/injection or in the future use alerting or reporting services.
@ppisljar ppisljar added the bug Fixes for quality problems that affect the customer experience label Jul 22, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 22, 2021
@ppisljar ppisljar added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 22, 2021
@timroes timroes added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Jul 22, 2021
This was referenced Jul 27, 2021
Closed
Merged
@alexwizp alexwizp self-assigned this Aug 10, 2021
@alexwizp alexwizp mentioned this issue Aug 31, 2021
Merged
alexwizp added a commit to alexwizp/kibana that referenced this issue Aug 31, 2021
@alexwizp
lens should register expression functions in setup contract
441e18d 
Closes: elastic#106510
@dokmic dokmic mentioned this issue Sep 1, 2021
Merged
3 tasks
alexwizp added a commit that referenced this issue Sep 7, 2021
@alexwizp @kibanamachine @mbondyra
lens should register expression functions in setup contract (#110639)
e2c6a03 
* lens should register expression functions in setup contract

Closes: #106510

* fix CI

* build optimization

* build optimizations - step 3

* fix CI

* try to optimize bundle

* Update x-pack/plugins/lens/common/expressions/time_scale/types.ts

Co-authored-by: Marta Bondyra <[email protected]>

* Update types.ts

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
alexwizp added a commit to alexwizp/kibana that referenced this issue Sep 7, 2021
@alexwizp @kibanamachine @mbondyra
lens should register expression functions in setup contract (elastic#…
0ca1c89 
…110639)

* lens should register expression functions in setup contract

Closes: elastic#106510

* fix CI

* build optimization

* build optimizations - step 3

* fix CI

* try to optimize bundle

* Update x-pack/plugins/lens/common/expressions/time_scale/types.ts

Co-authored-by: Marta Bondyra <[email protected]>

* Update types.ts

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
alexwizp added a commit that referenced this issue Sep 7, 2021
@alexwizp @kibanamachine @mbondyra
lens should register expression functions in setup contract (#110639) (…
69c0c2d 
…#111324)

* lens should register expression functions in setup contract

Closes: #106510

* fix CI

* build optimization

* build optimizations - step 3

* fix CI

* try to optimize bundle

* Update x-pack/plugins/lens/common/expressions/time_scale/types.ts

Co-authored-by: Marta Bondyra <[email protected]>

* Update types.ts

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lens should register expression functions in setup contract alexwizp/kibana
4 participants
@timroes @ppisljar @elasticmachine @alexwizp