Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing ES Promotion: dashboard app using current data dashboard saved search embeddable highlighting on filtering works #104365

Closed
mistic opened this issue Jul 6, 2021 · 2 comments · Fixed by #104571
Closed

Failing ES Promotion: dashboard app using current data dashboard saved search embeddable highlighting on filtering works #104365

mistic opened this issue Jul 6, 2021 · 2 comments · Fixed by #104571
Labels
blocker failed-es-promotion skipped-test Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.15.0 v8.0.0

Comments

@mistic
Copy link
Member

mistic commented Jul 6, 2021

This failure is preventing the promotion of the current Elasticsearch nightly snapshot.

For more information on the Elasticsearch snapshot promotion process including how to reproduce using the unverified nightly ES build: https://www.elastic.co/guide/en/kibana/master/development-es-snapshots.html

CI failure logs: https://kibana-ci.elastic.co/job/elasticsearch+snapshots+verify/3026/testReport/junit/Chrome%20UI%20Functional%20Tests/test_functional_apps_dashboard_saved_search_embeddable%C2%B7ts/Kibana_Pipeline___dashboard_app_using_current_data_dashboard_saved_search_embeddable_highlighting_on_filtering_works/

Error: expected 0 to be above 10
    at Assertion.assert (node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.above (node_modules/@kbn/expect/expect.js:317:8)
    at Context.<anonymous> (test/functional/apps/dashboard/saved_search_embeddable.ts:50:31)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.apply (node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
@mistic mistic added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 skipped-test failed-es-promotion v7.15.0 labels Jul 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

mistic added a commit that referenced this issue Jul 6, 2021
@mistic
skip failing es promotion suite (#104365)
2695777
mistic added a commit that referenced this issue Jul 6, 2021
@mistic
skip failing es promotion suite (#104365)
2b1575b
@mistic mistic added the blocker label Jul 6, 2021
@tylersmalley
Copy link
Contributor

I believe this is a bug in a recent ES change raised here: #104466 (comment)

tylersmalley pushed a commit to tylersmalley/kibana that referenced this issue Jul 12, 2021
Revert "skip failing es promotion suite (elastic#104365)"
3c9b92a 
This reverts commit 2695777.
@tylersmalley tylersmalley mentioned this issue Jul 12, 2021
Merged
mistic pushed a commit that referenced this issue Jul 14, 2021
@kibanamachine
[test] Reverts tests skipped to promote snapshot (#104571)
50a8a28 
* temp use unverified snapshot

Signed-off-by: Tyler Smalley <[email protected]>

* Revert "skip failing es promotion suite (#104469)"

This reverts commit 87971e7.

* Revert "skip failing es promotion suite (#104467)"

This reverts commit c72ad3e.

* Revert "skip failing es promotion suite (#104466)"

This reverts commit a0b36c7.

* Revert "skip failing es promotion suite (#104413)"

This reverts commit 9773e3f.

* Revert "skip failing es promotion suite (#104409)"

This reverts commit 79608dc.

* Revert "skip failing es promotion suite (#104366)"

This reverts commit dfc5dbb.

* Revert "skip failing es promotion suite (#104365)"

This reverts commit 2695777.

* Revert "skip failing es promotion suite (#104364)"

This reverts commit 16f69d2.

* Revert "skip failing es promotion suite (#104362)"

This reverts commit 2e492c2.

* Revert another commit to promote ES snapshot

Signed-off-by: Tyler Smalley <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
kibanamachine added a commit to kibanamachine/kibana that referenced this issue Jul 14, 2021
@kibanamachine
[test] Reverts tests skipped to promote snapshot (elastic#104571)
db5a6d9 
* temp use unverified snapshot

Signed-off-by: Tyler Smalley <[email protected]>

* Revert "skip failing es promotion suite (elastic#104469)"

This reverts commit 87971e7.

* Revert "skip failing es promotion suite (elastic#104467)"

This reverts commit c72ad3e.

* Revert "skip failing es promotion suite (elastic#104466)"

This reverts commit a0b36c7.

* Revert "skip failing es promotion suite (elastic#104413)"

This reverts commit 9773e3f.

* Revert "skip failing es promotion suite (elastic#104409)"

This reverts commit 79608dc.

* Revert "skip failing es promotion suite (elastic#104366)"

This reverts commit dfc5dbb.

* Revert "skip failing es promotion suite (elastic#104365)"

This reverts commit 2695777.

* Revert "skip failing es promotion suite (elastic#104364)"

This reverts commit 16f69d2.

* Revert "skip failing es promotion suite (elastic#104362)"

This reverts commit 2e492c2.

* Revert another commit to promote ES snapshot

Signed-off-by: Tyler Smalley <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
kibanamachine added a commit that referenced this issue Jul 14, 2021
@kibanamachine
[test] Reverts tests skipped to promote snapshot (#104571) (#105634)
07cdc5a 
* temp use unverified snapshot

Signed-off-by: Tyler Smalley <[email protected]>

* Revert "skip failing es promotion suite (#104469)"

This reverts commit 87971e7.

* Revert "skip failing es promotion suite (#104467)"

This reverts commit c72ad3e.

* Revert "skip failing es promotion suite (#104466)"

This reverts commit a0b36c7.

* Revert "skip failing es promotion suite (#104413)"

This reverts commit 9773e3f.

* Revert "skip failing es promotion suite (#104409)"

This reverts commit 79608dc.

* Revert "skip failing es promotion suite (#104366)"

This reverts commit dfc5dbb.

* Revert "skip failing es promotion suite (#104365)"

This reverts commit 2695777.

* Revert "skip failing es promotion suite (#104364)"

This reverts commit 16f69d2.

* Revert "skip failing es promotion suite (#104362)"

This reverts commit 2e492c2.

* Revert another commit to promote ES snapshot

Signed-off-by: Tyler Smalley <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Tyler Smalley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker failed-es-promotion skipped-test Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[test] Reverts tests skipped to promote snapshot tylersmalley/kibana
3 participants
@tylersmalley @mistic @elasticmachine