Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover][Lens] Right click on new Datatable when a flyout is open freezes the browser #100111

Closed
dej611 opened this issue May 14, 2021 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure upstream

Comments

@dej611
Copy link
Contributor

dej611 commented May 14, 2021

Describe the bug:

When the new Datatable (EuiDataGrid) is below a flyout component (classic or custom as in Lens) then a right click action does freeze the browser.

If two flyouts (stacked) are open on top of a Datatable also a left click can leads to the same result.

Steps to reproduce:

Right click scenario:

  1. Open Discover with the new datatable
  2. Click on a row/Open the Inspect panel
  3. Now right click on a cell on the table
  4. 🥶

Left click scenario:

  1. Use the [Lens] Adds dynamic table cell coloring #95217 to create a datatable
  2. Open a second flyout via editing the palette for a dimension/metric
  3. Change the palette
  4. Left click on a cell on the table
  5. 🥶
    Fixed by Fix datagrid freezing on open flyout eui#4813

Expected behavior:

Browser/Window/Datatable does not freeze.

Any additional context:

We found out that keeping only a single FocusTrap enabled (used in flyouts) on the "left click" scenario manages to remove the bug in that specific case. There's still the pending issue with the "right click".

We managed to track back this bug since Kibana 7.12 .

Will open an issue on the EUI repo to fix this upstream.

@dej611 dej611 added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels May 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

I tested with the new EUI version #101334 and the EUI side fix takes care of the left click scenario (no freezes anymore), but not the right click scenario (still freezes). As right click is much less likely I'm going to move this to minor bugs, but we should still try to find a fix during next fix-it week.

@flash1293 flash1293 changed the title [Discover][Lens] Click on new Datatable when a flyout is open freezes the browser [Discover][Lens] Right click on new Datatable when a flyout is open freezes the browser Jun 17, 2021
@flash1293
Copy link
Contributor

Tested with the most recent master in Firefox, Safari and Chrome and couldn't reproduce the issue. Closing for now - If I missed something, feel free to reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure upstream
Projects
None yet
Development

No branches or pull requests

4 participants