Skip to content

Commit

Permalink
Remove Angular from visualize (#20295)
Browse files Browse the repository at this point in the history
  • Loading branch information
ppisljar authored Jul 9, 2018
1 parent 49139d2 commit fffa3d4
Show file tree
Hide file tree
Showing 15 changed files with 277 additions and 498 deletions.
12 changes: 6 additions & 6 deletions src/ui/public/render_complete/render_complete_helper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,21 +24,21 @@ export class RenderCompleteHelper {
this.setup();
}

public destroy() {
public destroy = () => {
this.element.removeEventListener('renderStart', this.start);
this.element.removeEventListener('renderComplete', this.complete);
}
};

public setup() {
public setup = () => {
this.element.setAttribute(attributeName, 'false');
this.element.addEventListener('renderStart', this.start);
this.element.addEventListener('renderComplete', this.complete);
}
};

public disable() {
public disable = () => {
this.element.setAttribute(attributeName, 'disabled');
this.destroy();
}
};

private start = () => {
this.element.setAttribute(attributeName, 'false');
Expand Down
195 changes: 0 additions & 195 deletions src/ui/public/visualize/__tests__/visualize.js

This file was deleted.

1 change: 1 addition & 0 deletions src/ui/public/visualize/components/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@
* under the License.
*/

export * from './visualization';
export * from './visualization_chart';
export * from './visualization_noresults';
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
* under the License.
*/

import './visualize.less';
import './visualization.less';
import _ from 'lodash';
import React, { Component } from 'react';
import { VisualizationNoResults, VisualizationChart } from './components';
import { VisualizationNoResults, VisualizationChart } from './';

const _showNoResultsMessage = (vis, visData) => {
const requiresSearch = _.get(vis, 'type.requiresSearch');
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@import (reference) "~ui/styles/variables";

visualize {
.visualize {
display: flex;
flex: 1 1 100%;
overflow-x: hidden;
Expand Down
2 changes: 1 addition & 1 deletion src/ui/public/visualize/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@
* under the License.
*/

import './visualize';
export * from './loader';
Loading

0 comments on commit fffa3d4

Please sign in to comment.