Skip to content

Commit

Permalink
add retry logic and focus test
Browse files Browse the repository at this point in the history
  • Loading branch information
dominiqueclarke committed Nov 3, 2021
1 parent 1efcfb6 commit feaaeee
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 36 deletions.
4 changes: 2 additions & 2 deletions x-pack/test/functional/apps/uptime/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export default ({ loadTestFile, getService }: FtrProviderContext) => {
const server = getService('kibanaServer');
const uptime = getService('uptime');

describe('Uptime app', function () {
describe.only('Uptime app', function () {
this.tags('ciGroup10');

beforeEach('delete settings', async () => {
Expand All @@ -62,7 +62,7 @@ export default ({ loadTestFile, getService }: FtrProviderContext) => {
loadTestFile(require.resolve('./synthetics_integration'));
});

describe('with generated data but no data reset', () => {
describe.only('with generated data but no data reset', () => {
loadTestFile(require.resolve('./ping_redirects'));
});

Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/uptime/ping_redirects.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

const monitor = () => uptime.monitor;

// FLAKY: https://github.com/elastic/kibana/issues/84992
describe.skip('Ping redirects', () => {
describe.only('Ping redirects', () => {
const start = '~ 15 minutes ago';
const end = 'now';

Expand Down
62 changes: 31 additions & 31 deletions x-pack/test/functional/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,39 +24,39 @@ export default async function ({ readConfigFile }) {
// list paths to the files that contain your plugins tests
testFiles: [
resolve(__dirname, './apps/advanced_settings'),
resolve(__dirname, './apps/canvas'),
resolve(__dirname, './apps/graph'),
resolve(__dirname, './apps/monitoring'),
resolve(__dirname, './apps/watcher'),
resolve(__dirname, './apps/dashboard'),
resolve(__dirname, './apps/discover'),
// resolve(__dirname, './apps/canvas'),
// resolve(__dirname, './apps/graph'),
// resolve(__dirname, './apps/monitoring'),
// resolve(__dirname, './apps/watcher'),
// resolve(__dirname, './apps/dashboard'),
// resolve(__dirname, './apps/discover'),
resolve(__dirname, './apps/security'),
resolve(__dirname, './apps/spaces'),
resolve(__dirname, './apps/logstash'),
resolve(__dirname, './apps/grok_debugger'),
resolve(__dirname, './apps/infra'),
resolve(__dirname, './apps/ml'),
resolve(__dirname, './apps/rollup_job'),
resolve(__dirname, './apps/maps'),
resolve(__dirname, './apps/status_page'),
resolve(__dirname, './apps/upgrade_assistant'),
resolve(__dirname, './apps/visualize'),
// resolve(__dirname, './apps/spaces'),
// resolve(__dirname, './apps/logstash'),
// resolve(__dirname, './apps/grok_debugger'),
// resolve(__dirname, './apps/infra'),
// resolve(__dirname, './apps/ml'),
// resolve(__dirname, './apps/rollup_job'),
// resolve(__dirname, './apps/maps'),
// resolve(__dirname, './apps/status_page'),
// resolve(__dirname, './apps/upgrade_assistant'),
// resolve(__dirname, './apps/visualize'),
resolve(__dirname, './apps/uptime'),
resolve(__dirname, './apps/saved_objects_management'),
resolve(__dirname, './apps/dev_tools'),
resolve(__dirname, './apps/apm'),
resolve(__dirname, './apps/api_keys'),
resolve(__dirname, './apps/index_patterns'),
resolve(__dirname, './apps/index_management'),
resolve(__dirname, './apps/index_lifecycle_management'),
resolve(__dirname, './apps/ingest_pipelines'),
resolve(__dirname, './apps/snapshot_restore'),
resolve(__dirname, './apps/cross_cluster_replication'),
resolve(__dirname, './apps/remote_clusters'),
resolve(__dirname, './apps/transform'),
resolve(__dirname, './apps/reporting_management'),
resolve(__dirname, './apps/management'),
resolve(__dirname, './apps/lens'), // smokescreen tests cause flakiness in other tests
// resolve(__dirname, './apps/saved_objects_management'),
// resolve(__dirname, './apps/dev_tools'),
// resolve(__dirname, './apps/apm'),
// resolve(__dirname, './apps/api_keys'),
// resolve(__dirname, './apps/index_patterns'),
// resolve(__dirname, './apps/index_management'),
// resolve(__dirname, './apps/index_lifecycle_management'),
// resolve(__dirname, './apps/ingest_pipelines'),
// resolve(__dirname, './apps/snapshot_restore'),
// resolve(__dirname, './apps/cross_cluster_replication'),
// resolve(__dirname, './apps/remote_clusters'),
// resolve(__dirname, './apps/transform'),
// resolve(__dirname, './apps/reporting_management'),
// resolve(__dirname, './apps/management'),
// resolve(__dirname, './apps/lens'), // smokescreen tests cause flakiness in other tests

// This license_management file must be last because it is destructive.
resolve(__dirname, './apps/license_management'),
Expand Down
4 changes: 3 additions & 1 deletion x-pack/test/functional/services/uptime/navigation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ export function UptimeNavigationProvider({ getService, getPageObjects }: FtrProv
goToMonitor: async (monitorId: string) => {
// only go to monitor page if not already there
if (!(await testSubjects.exists('uptimeMonitorPage', { timeout: 0 }))) {
await testSubjects.click(`monitor-page-link-${monitorId}`);
return retry.try(async () => {
await testSubjects.click(`monitor-page-link-${monitorId}`);
});
await testSubjects.existOrFail('uptimeMonitorPage', {
timeout: 30000,
});
Expand Down

0 comments on commit feaaeee

Please sign in to comment.