addressing PR comments

elastic · Mar 10, 2021 · f67dc7f · f67dc7f
1 parent 91598bc
commit f67dc7f
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/x-pack/plugins/apm/public/components/shared/charts/latency_chart/index.tsx b/x-pack/plugins/apm/public/components/shared/charts/latency_chart/index.tsx
@@ -9,7 +9,6 @@ import { EuiFlexGroup, EuiFlexItem, EuiSelect, EuiTitle } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import React from 'react';
 import { useHistory } from 'react-router-dom';
-import { APMChartSpec, Coordinate } from '../../../../../typings/timeseries';
 import { LatencyAggregationType } from '../../../../../common/latency_aggregation_types';
 import { getDurationFormatter } from '../../../../../common/utils/formatters';
 import { useLicenseContext } from '../../../../context/license/use_license_context';
@@ -35,6 +34,10 @@ const options: Array<{ value: LatencyAggregationType; text: string }> = [
   { value: LatencyAggregationType.p99, text: '99th percentile' },
 ];
 
+function filterNil<T>(value: T | null | undefined): value is T {
+  return value != null;
+}
+
 export function LatencyChart({ height }: Props) {
   const history = useHistory();
   const theme = useTheme();
@@ -58,7 +61,7 @@ export function LatencyChart({ height }: Props) {
   const timeseries = [
     currentPeriod,
     comparisonEnabled ? previousPeriod : undefined,
-  ].filter((data) => data) as Array<APMChartSpec<Coordinate>>;
+  ].filter(filterNil);
 
   const latencyMaxY = getMaxY(timeseries);
   const latencyFormatter = getDurationFormatter(latencyMaxY);