Merge branch 'main' into de-8-13/enable-additional-connectors

elastic · May 9, 2024 · f655fe8 · f655fe8
2 parents beee520 + ed14baf
commit f655fe8
Show file tree

Hide file tree

Showing 124 changed files with 3,443 additions and 5,647 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -1432,6 +1432,7 @@ x-pack/test/security_solution_cypress/cypress/tasks/expandable_flyout  @elastic/
 /x-pack/test/security_solution_cypress/cypress/tasks/hosts @elastic/security-threat-hunting-explore
 /x-pack/test/security_solution_cypress/cypress/tasks/network @elastic/security-threat-hunting-explore
 
+/x-pack/plugins/security_solution/public/app/actions @elastic/security-threat-hunting-explore
 /x-pack/plugins/security_solution/public/common/components/guided_onboarding_tour @elastic/security-threat-hunting-explore
 /x-pack/plugins/security_solution/public/common/components/charts @elastic/security-threat-hunting-explore
 /x-pack/plugins/security_solution/public/detections/components/alerts_table/grouping_settings @elastic/security-threat-hunting-explore

diff --git a/packages/kbn-cell-actions/actions/index.ts b/packages/kbn-cell-actions/actions/index.ts
@@ -0,0 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+export * from '../src/actions';
diff --git a/packages/kbn-cell-actions/actions/utils.ts b/packages/kbn-cell-actions/actions/utils.ts
@@ -0,0 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+export * from '../src/actions/utils';
diff --git a/packages/kbn-cell-actions/index.ts b/packages/kbn-cell-actions/index.ts
@@ -6,4 +6,8 @@
  * Side Public License, v 1.
  */
 
-export * from './src';
+export * from './src/types';
+
+export * from './src/context';
+export * from './src/components';
+export * from './src/hooks';
diff --git a/packages/kbn-cell-actions/src/actions/index.ts b/packages/kbn-cell-actions/src/actions/index.ts
@@ -0,0 +1,20 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+export * from './types';
+
+export { createCellActionFactory } from './factory';
+
+export { createCopyToClipboardActionFactory } from './copy_to_clipboard';
+export {
+  createFilterInActionFactory,
+  createFilterOutActionFactory,
+  addFilterIn,
+  addFilterOut,
+  addExistsFilter,
+} from './filter';
diff --git a/packages/kbn-cell-actions/src/actions/types.ts b/packages/kbn-cell-actions/src/actions/types.ts
@@ -6,8 +6,9 @@
  * Side Public License, v 1.
  */
 
-import { SerializableRecord } from '@kbn/utility-types';
-import { SerializableArray } from '@kbn/utility-types/src/serializable';
+import type { SerializableRecord } from '@kbn/utility-types';
+import type { SerializableArray } from '@kbn/utility-types/src/serializable';
+import type { CellAction } from '../types';
 
 export type DefaultActionsSupportedValue = string[] | number[] | boolean[];
 
@@ -17,3 +18,20 @@ export type NonNullableSerializable =
   | boolean
   | SerializableArray
   | SerializableRecord;
+
+/**
+ * Cell action factory template with optional `id`.
+ * The id override is required when using the action factory so it
+ * can be omitted in the original action creator
+ */
+export type CellActionTemplate<C extends CellAction = CellAction> = Omit<C, 'id'>;
+/**
+ * Action factory extend parameter type,
+ */
+export type CellActionExtend<C extends CellAction = CellAction> = Partial<C> & { id: string };
+export interface CellActionFactory<C extends CellAction = CellAction> {
+  <A extends C = C>(extend: CellActionExtend<A>): A;
+  combine: <A extends C = C>(
+    partialActionTemplate: Partial<CellActionTemplate<A>>
+  ) => CellActionFactory<A>;
+}
diff --git a/packages/kbn-cell-actions/src/components/hover_actions_popover.test.tsx b/packages/kbn-cell-actions/src/components/hover_actions_popover.test.tsx
@@ -31,14 +31,16 @@ describe('HoverActionsPopover', () => {
   const TestComponent = () => <span data-test-subj="test-component" />;
   jest.useFakeTimers();
 
-  it('renders', () => {
+  it('renders the children', () => {
     const getActions = () => Promise.resolve([]);
-    const { queryByTestId } = render(
+    const { getByTestId } = render(
       <CellActionsProvider getTriggerCompatibleActions={getActions}>
-        <HoverActionsPopover {...defaultProps} children={null} />
+        <HoverActionsPopover {...defaultProps}>
+          <TestComponent />
+        </HoverActionsPopover>
       </CellActionsProvider>
     );
-    expect(queryByTestId('hoverActionsPopover')).toBeInTheDocument();
+    expect(getByTestId('test-component')).toBeInTheDocument();
   });
 
   it('renders actions when hovered', async () => {

diff --git a/packages/kbn-cell-actions/src/components/hover_actions_popover.tsx b/packages/kbn-cell-actions/src/components/hover_actions_popover.tsx
@@ -135,7 +135,7 @@ export const HoverActionsPopover: React.FC<Props> = ({
           panelPaddingSize="none"
           repositionOnScroll
           ownFocus={false}
-          data-test-subj={'hoverActionsPopover'}
+          panelProps={{ ['data-test-subj']: 'hoverActionsPopover' }}
           aria-label={ACTIONS_AREA_LABEL}
         >
           {showHoverContent && (

diff --git a/packages/kbn-cell-actions/src/index.ts b/packages/kbn-cell-actions/src/index.ts
diff --git a/packages/kbn-cell-actions/src/types.ts b/packages/kbn-cell-actions/src/types.ts
@@ -16,6 +16,8 @@ import type { FieldSpec } from '@kbn/data-views-plugin/common';
 import { Serializable } from '@kbn/utility-types';
 import type { CellActionsMode } from './constants';
 
+export * from './actions/types';
+
 export type CellActionsProviderProps = PropsWithChildren<{
   /**
    * Please assign `uiActions.getTriggerCompatibleActions` function.
@@ -133,20 +135,3 @@ export interface PartitionedActions {
   extraActions: CellAction[];
   visibleActions: CellAction[];
 }
-
-/**
- * Cell action factory template with optional `id`.
- * The id override is required when using the action factory so it
- * can be omitted in the original action creator
- */
-export type CellActionTemplate<C extends CellAction = CellAction> = Omit<C, 'id'>;
-/**
- * Action factory extend parameter type,
- */
-export type CellActionExtend<C extends CellAction = CellAction> = Partial<C> & { id: string };
-export interface CellActionFactory<C extends CellAction = CellAction> {
-  <A extends C = C>(extend: CellActionExtend<A>): A;
-  combine: <A extends C = C>(
-    partialActionTemplate: Partial<CellActionTemplate<A>>
-  ) => CellActionFactory<A>;
-}
diff --git a/x-pack/plugins/security_solution/public/actions/jest.config.js b/x-pack/plugins/security_solution/public/actions/jest.config.js
diff --git a/...eline/cell_action/add_to_timeline.test.ts → ...eline/cell_action/add_to_timeline.test.ts b/...eline/cell_action/add_to_timeline.test.ts → ...eline/cell_action/add_to_timeline.test.ts
@@ -5,13 +5,13 @@
  * 2.0.
  */
 
-import type { SecurityAppStore } from '../../../common/store/types';
-import { TimelineId } from '../../../../common/types';
-import { addProvider } from '../../../timelines/store/actions';
+import type { SecurityAppStore } from '../../../../common/store/types';
+import { TimelineId } from '../../../../../common/types';
+import { addProvider } from '../../../../timelines/store/actions';
 import { createAddToTimelineCellActionFactory } from './add_to_timeline';
 import type { CellActionExecutionContext } from '@kbn/cell-actions';
-import { GEO_FIELD_TYPE } from '../../../timelines/components/timeline/body/renderers/constants';
-import { createStartServicesMock } from '../../../common/lib/kibana/kibana_react.mock';
+import { GEO_FIELD_TYPE } from '../../../../timelines/components/timeline/body/renderers/constants';
+import { createStartServicesMock } from '../../../../common/lib/kibana/kibana_react.mock';
 import { set } from 'lodash/fp';
 import { KBN_FIELD_TYPES } from '@kbn/field-types';
 

diff --git a/...o_timeline/cell_action/add_to_timeline.ts → ...o_timeline/cell_action/add_to_timeline.ts b/...o_timeline/cell_action/add_to_timeline.ts → ...o_timeline/cell_action/add_to_timeline.ts
@@ -5,19 +5,18 @@
  * 2.0.
  */
 
-import { createCellActionFactory } from '@kbn/cell-actions';
-import type { CellActionTemplate } from '@kbn/cell-actions';
+import { createCellActionFactory, type CellActionTemplate } from '@kbn/cell-actions/actions';
 import {
   isTypeSupportedByDefaultActions,
   isValueSupportedByDefaultActions,
   filterOutNullableValues,
   valueToArray,
-} from '@kbn/cell-actions/src/actions/utils';
+} from '@kbn/cell-actions/actions/utils';
 import { ACTION_INCOMPATIBLE_VALUE_WARNING } from '@kbn/cell-actions/src/actions/translations';
 import type { KBN_FIELD_TYPES } from '@kbn/field-types';
-import { addProvider } from '../../../timelines/store/actions';
-import { TimelineId } from '../../../../common/types';
-import type { SecurityAppStore } from '../../../common/store';
+import { addProvider } from '../../../../timelines/store/actions';
+import { TimelineId } from '../../../../../common/types';
+import type { SecurityAppStore } from '../../../../common/store';
 import { fieldHasCellActions } from '../../utils';
 import {
   ADD_TO_TIMELINE,
@@ -28,7 +27,7 @@ import {
 } from '../constants';
 import { createDataProviders, isValidDataProviderField } from '../data_provider';
 import { SecurityCellActionType } from '../../constants';
-import type { StartServices } from '../../../types';
+import type { StartServices } from '../../../../types';
 import type { SecurityCellAction } from '../../types';
 
 export const createAddToTimelineCellActionFactory = createCellActionFactory(

diff --git a/...ction/investigate_in_new_timeline.test.ts → ...ction/investigate_in_new_timeline.test.ts b/...ction/investigate_in_new_timeline.test.ts → ...ction/investigate_in_new_timeline.test.ts
@@ -5,14 +5,14 @@
  * 2.0.
  */
 
-import type { SecurityAppStore } from '../../../common/store/types';
-import { TimelineId } from '../../../../common/types';
-import { addProvider, showTimeline } from '../../../timelines/store/actions';
+import type { SecurityAppStore } from '../../../../common/store/types';
+import { TimelineId } from '../../../../../common/types';
+import { addProvider, showTimeline } from '../../../../timelines/store/actions';
 import { createInvestigateInNewTimelineCellActionFactory } from './investigate_in_new_timeline';
 import type { CellActionExecutionContext } from '@kbn/cell-actions';
-import { GEO_FIELD_TYPE } from '../../../timelines/components/timeline/body/renderers/constants';
-import { createStartServicesMock } from '../../../common/lib/kibana/kibana_react.mock';
-import { timelineActions } from '../../../timelines/store';
+import { GEO_FIELD_TYPE } from '../../../../timelines/components/timeline/body/renderers/constants';
+import { createStartServicesMock } from '../../../../common/lib/kibana/kibana_react.mock';
+import { timelineActions } from '../../../../timelines/store';
 import { KBN_FIELD_TYPES } from '@kbn/field-types';
 
 const services = createStartServicesMock();

diff --git a/...ell_action/investigate_in_new_timeline.ts → ...ell_action/investigate_in_new_timeline.ts b/...ell_action/investigate_in_new_timeline.ts → ...ell_action/investigate_in_new_timeline.ts
@@ -5,19 +5,19 @@
  * 2.0.
  */
 
-import { createCellActionFactory, type CellActionTemplate } from '@kbn/cell-actions';
 import type { KBN_FIELD_TYPES } from '@kbn/field-types';
+import { createCellActionFactory, type CellActionTemplate } from '@kbn/cell-actions/actions';
 import {
   isTypeSupportedByDefaultActions,
   isValueSupportedByDefaultActions,
-  valueToArray,
   filterOutNullableValues,
-} from '@kbn/cell-actions/src/actions/utils';
+  valueToArray,
+} from '@kbn/cell-actions/actions/utils';
 import { ACTION_INCOMPATIBLE_VALUE_WARNING } from '@kbn/cell-actions/src/actions/translations';
-import { timelineActions } from '../../../timelines/store';
-import { addProvider, showTimeline } from '../../../timelines/store/actions';
-import { TimelineId } from '../../../../common/types';
-import type { SecurityAppStore } from '../../../common/store';
+import { timelineActions } from '../../../../timelines/store';
+import { addProvider, showTimeline } from '../../../../timelines/store/actions';
+import { TimelineId } from '../../../../../common/types';
+import type { SecurityAppStore } from '../../../../common/store';
 import { fieldHasCellActions } from '../../utils';
 import {
   ADD_TO_TIMELINE_FAILED_TEXT,
@@ -27,9 +27,9 @@ import {
 } from '../constants';
 import { createDataProviders, isValidDataProviderField } from '../data_provider';
 import { SecurityCellActionType } from '../../constants';
-import type { StartServices } from '../../../types';
+import type { StartServices } from '../../../../types';
 import type { SecurityCellAction } from '../../types';
-import { timelineDefaults } from '../../../timelines/store/defaults';
+import { timelineDefaults } from '../../../../timelines/store/defaults';
 
 export const createInvestigateInNewTimelineCellActionFactory = createCellActionFactory(
   ({

diff --git a/...blic/actions/add_to_timeline/constants.ts → .../app/actions/add_to_timeline/constants.ts b/...blic/actions/add_to_timeline/constants.ts → .../app/actions/add_to_timeline/constants.ts
diff --git a/.../actions/add_to_timeline/data_provider.ts → .../actions/add_to_timeline/data_provider.ts b/.../actions/add_to_timeline/data_provider.ts → .../actions/add_to_timeline/data_provider.ts
@@ -9,13 +9,13 @@ import { escapeDataProviderId } from '@kbn/securitysolution-t-grid';
 import type { Serializable } from '@kbn/utility-types';
 
 import { isArray, isString, isEmpty } from 'lodash/fp';
-import { INDICATOR_REFERENCE } from '../../../common/cti/constants';
-import type { DataProvider, QueryOperator } from '../../../common/types';
-import { EXISTS_OPERATOR, IS_OPERATOR } from '../../../common/types';
-import { IP_FIELD_TYPE } from '../../explore/network/components/ip';
-import { PORT_NAMES } from '../../explore/network/components/port/helpers';
-import { EVENT_DURATION_FIELD_NAME } from '../../timelines/components/duration';
-import { BYTES_FORMAT } from '../../timelines/components/timeline/body/renderers/bytes';
+import { INDICATOR_REFERENCE } from '../../../../common/cti/constants';
+import type { DataProvider, QueryOperator } from '../../../../common/types';
+import { EXISTS_OPERATOR, IS_OPERATOR } from '../../../../common/types';
+import { IP_FIELD_TYPE } from '../../../explore/network/components/ip';
+import { PORT_NAMES } from '../../../explore/network/components/port/helpers';
+import { EVENT_DURATION_FIELD_NAME } from '../../../timelines/components/duration';
+import { BYTES_FORMAT } from '../../../timelines/components/timeline/body/renderers/bytes';
 import {
   GEO_FIELD_TYPE,
   MESSAGE_FIELD_NAME,
@@ -25,7 +25,7 @@ import {
   RULE_REFERENCE_FIELD_NAME,
   REFERENCE_URL_FIELD_NAME,
   EVENT_URL_FIELD_NAME,
-} from '../../timelines/components/timeline/body/renderers/constants';
+} from '../../../timelines/components/timeline/body/renderers/constants';
 import { isCountField } from '../utils';
 
 export const getDataProvider = ({

diff --git a/...timeline/discover/add_to_timeline.test.ts → ...timeline/discover/add_to_timeline.test.ts b/...timeline/discover/add_to_timeline.test.ts → ...timeline/discover/add_to_timeline.test.ts
@@ -5,14 +5,14 @@
  * 2.0.
  */
 
-import type { SecurityAppStore } from '../../../common/store/types';
-import { TimelineId } from '../../../../common/types';
-import { addProvider } from '../../../timelines/store/actions';
+import type { SecurityAppStore } from '../../../../common/store/types';
+import { TimelineId } from '../../../../../common/types';
+import { addProvider } from '../../../../timelines/store/actions';
 import { createAddToTimelineDiscoverCellActionFactory } from './add_to_timeline';
 import type { CellActionExecutionContext } from '@kbn/cell-actions';
-import { GEO_FIELD_TYPE } from '../../../timelines/components/timeline/body/renderers/constants';
-import { createStartServicesMock } from '../../../common/lib/kibana/kibana_react.mock';
-import { APP_UI_ID } from '../../../../common';
+import { GEO_FIELD_TYPE } from '../../../../timelines/components/timeline/body/renderers/constants';
+import { createStartServicesMock } from '../../../../common/lib/kibana/kibana_react.mock';
+import { APP_UI_ID } from '../../../../../common';
 import { BehaviorSubject } from 'rxjs';
 
 const services = createStartServicesMock();

diff --git a/...d_to_timeline/discover/add_to_timeline.ts → ...d_to_timeline/discover/add_to_timeline.ts b/...d_to_timeline/discover/add_to_timeline.ts → ...d_to_timeline/discover/add_to_timeline.ts
@@ -6,9 +6,9 @@
  */
 
 import type { CellAction, CellActionFactory } from '@kbn/cell-actions';
-import type { SecurityAppStore } from '../../../common/store';
+import type { SecurityAppStore } from '../../../../common/store';
 import { isInSecurityApp } from '../../utils';
-import type { StartServices } from '../../../types';
+import type { StartServices } from '../../../../types';
 import { createAddToTimelineCellActionFactory } from '../cell_action/add_to_timeline';
 
 export const createAddToTimelineDiscoverCellActionFactory = ({

diff --git a/...n/public/actions/add_to_timeline/index.ts → ...blic/app/actions/add_to_timeline/index.ts b/...n/public/actions/add_to_timeline/index.ts → ...blic/app/actions/add_to_timeline/index.ts