divide endpoint list checking function

elastic · Apr 25, 2023 · f5ce24d · f5ce24d
1 parent 7d03f5c
commit f5ce24d
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/x-pack/plugins/security_solution/public/management/cypress/e2e/endpoint/isolate.cy.ts b/x-pack/plugins/security_solution/public/management/cypress/e2e/endpoint/isolate.cy.ts
@@ -9,7 +9,8 @@ import type { Agent } from '@kbn/fleet-plugin/common';
 import { APP_CASES_PATH, APP_ENDPOINTS_PATH } from '../../../../../common/constants';
 import { closeAllToasts } from '../../tasks/close_all_toasts';
 import {
-  checkEndpointListForIsolatedHosts,
+  checkEndpointListForOnlyIsolatedHosts,
+  checkEndpointListForOnlyUnIsolatedHosts,
   checkFlyoutEndpointIsolation,
   createAgentPolicyTask,
   filterOutEndpoints,
@@ -69,7 +70,7 @@ describe('Isolate command', () => {
     it('should allow filtering endpoint by Isolated status', () => {
       cy.visit(APP_ENDPOINTS_PATH);
       closeAllToasts();
-      checkEndpointListForIsolatedHosts(false);
+      checkEndpointListForOnlyUnIsolatedHosts();
 
       filterOutIsolatedHosts();
       cy.contains('No items found');
@@ -87,7 +88,7 @@ describe('Isolate command', () => {
       cy.getByTestSubj('rowHostStatus-actionStatuses').should('contain.text', 'Isolated');
       filterOutIsolatedHosts();
 
-      checkEndpointListForIsolatedHosts();
+      checkEndpointListForOnlyIsolatedHosts();
 
       cy.getByTestSubj('endpointTableRowActions').click();
       cy.getByTestSubj('unIsolateLink').click();
@@ -96,7 +97,7 @@ describe('Isolate command', () => {
       cy.getByTestSubj('euiFlyoutCloseButton').click();
       cy.getByTestSubj('adminSearchBar').click().type('{selectall}{backspace}');
       cy.getByTestSubj('querySubmitButton').click();
-      checkEndpointListForIsolatedHosts(false);
+      checkEndpointListForOnlyUnIsolatedHosts();
     });
   });
 

diff --git a/x-pack/plugins/security_solution/public/management/cypress/e2e/mocked_data/isolate.cy.ts b/x-pack/plugins/security_solution/public/management/cypress/e2e/mocked_data/isolate.cy.ts
@@ -7,7 +7,7 @@
 
 import { getEndpointListPath } from '../../../common/routing';
 import {
-  checkEndpointListForIsolatedHosts,
+  checkEndpointListForOnlyIsolatedHosts,
   checkFlyoutEndpointIsolation,
   filterOutIsolatedHosts,
   interceptActionRequests,
@@ -72,7 +72,7 @@ describe('Isolate command', () => {
       closeAllToasts();
       filterOutIsolatedHosts();
       cy.contains('Showing 2 endpoints');
-      checkEndpointListForIsolatedHosts();
+      checkEndpointListForOnlyIsolatedHosts();
     });
   });
 

diff --git a/x-pack/plugins/security_solution/public/management/cypress/tasks/isolate.ts b/x-pack/plugins/security_solution/public/management/cypress/tasks/isolate.ts
@@ -129,7 +129,7 @@ export const filterOutIsolatedHosts = (): void => {
   cy.getByTestSubj('querySubmitButton').click();
 };
 
-export const checkEndpointListForIsolatedHosts = (expectIsolated = true): void => {
+const checkEndpointListForIsolatedHosts = (expectIsolated: boolean): void => {
   const chainer = expectIsolated ? 'contain.text' : 'not.contain.text';
   cy.getByTestSubj('endpointListTable').within(() => {
     cy.get('tbody tr').each(($tr) => {
@@ -140,6 +140,7 @@ export const checkEndpointListForIsolatedHosts = (expectIsolated = true): void =
   });
 };
 
-export const checkEndpointListForOnlyUnIsolatedHosts = () =>
+export const checkEndpointListForOnlyUnIsolatedHosts = (): void =>
   checkEndpointListForIsolatedHosts(false);
-export const checkEndpointListForOnlyIsolatedHosts = () => checkEndpointListForIsolatedHosts(true);
+export const checkEndpointListForOnlyIsolatedHosts = (): void =>
+  checkEndpointListForIsolatedHosts(true);