Apply suggestions from code review

Co-authored-by: Constance <[email protected]>
elastic · Nov 16, 2020 · f492e2e · f492e2e
1 parent c371287
commit f492e2e
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 13 deletions.
diff --git a/...prise_search/public/applications/app_search/components/documents/document_detail_logic.ts b/...prise_search/public/applications/app_search/components/documents/document_detail_logic.ts
@@ -41,9 +41,9 @@ const DELETE_SUCCESS = i18n.translate(
 export const DocumentDetailLogic = kea<DocumentDetailLogicType>({
   path: ['enterprise_search', 'app_search', 'document_detail_logic'],
   actions: () => ({
-    setFields: (fields: FieldDetails[]) => ({ fields }),
-    getDocumentDetails: (documentId: string) => ({ documentId }),
-    deleteDocument: (documentId: string) => ({ documentId }),
+    setFields: (fields) => ({ fields }),
+    getDocumentDetails: (documentId) => ({ documentId }),
+    deleteDocument: (documentId) => ({ documentId }),
   }),
   reducers: () => ({
     dataLoading: [

diff --git a/...search/public/applications/app_search/components/documents/documents_detail_logic.test.ts b/...search/public/applications/app_search/components/documents/documents_detail_logic.test.ts
@@ -89,7 +89,7 @@ describe('DocumentsLogic', () => {
 
       it('handles errors', async () => {
         mount();
-        const promise = Promise.reject('An error occured');
+        const promise = Promise.reject('An error occurred');
         http.get.mockReturnValue(promise);
 
         try {
@@ -98,23 +98,23 @@ describe('DocumentsLogic', () => {
         } catch {
           // Do nothing
         }
-        expect(flashAPIErrors).toHaveBeenCalledWith('An error occured');
+        expect(flashAPIErrors).toHaveBeenCalledWith('An error occurred');
       });
     });
 
     describe('deleteDocument', () => {
-      let originalWindowConfirm: any;
+      let confirmSpy: any;
       let promise: Promise<any>;
 
       beforeEach(() => {
-        originalWindowConfirm = window.confirm;
-        window.confirm = () => true;
+        confirmSpy = jest.spyOn(window, 'confirm');
+        confirmSpy.mockImplementation(jest.fn(() => true));
         promise = Promise.resolve({});
         http.delete.mockReturnValue(promise);
       });
 
       afterEach(() => {
-        window.confirm = originalWindowConfirm;
+        confirmSpy.mockRestore())
       });
 
       it('will call an API endpoint and show a success message', async () => {

diff --git a/.../enterprise_search/public/applications/app_search/components/documents/documents_logic.ts b/.../enterprise_search/public/applications/app_search/components/documents/documents_logic.ts
@@ -15,9 +15,9 @@ export interface DocumentsLogicActions {
   openDocumentCreation(): void;
 }
 
-type DocumnetsLogicType = MakeLogicType<DocumentsLogicValues, DocumentsLogicActions>;
+type DocumentsLogicType = MakeLogicType<DocumentsLogicValues, DocumentsLogicActions>;
 
-export const DocumentsLogic = kea<DocumnetsLogicType>({
+export const DocumentsLogic = kea<DocumentsLogicType>({
   path: ['enterprise_search', 'app_search', 'documents_logic'],
   actions: () => ({
     openDocumentCreation: true,

diff --git a/x-pack/plugins/enterprise_search/server/routes/app_search/documents.test.ts b/x-pack/plugins/enterprise_search/server/routes/app_search/documents.test.ts
@@ -17,7 +17,6 @@ describe('document routes', () => {
       mockRouter = new MockRouter({
         method: 'get',
         path: '/api/app_search/engines/{engineName}/documents/{documentId}',
-        payload: 'query',
       });
 
       registerDocumentRoutes({
@@ -43,7 +42,6 @@ describe('document routes', () => {
       mockRouter = new MockRouter({
         method: 'delete',
         path: '/api/app_search/engines/{engineName}/documents/{documentId}',
-        payload: 'query',
       });
 
       registerDocumentRoutes({