Merge branch 'main' into 137988-category-field-api

.github/CODEOWNERS

@@ -13,6 +13,7 @@
 /src/plugins/saved_search/ @elastic/kibana-data-discovery
 /x-pack/plugins/discover_enhanced/ @elastic/kibana-data-discovery
 /test/functional/apps/discover/ @elastic/kibana-data-discovery
+/test/functional/apps/context/ @elastic/kibana-data-discovery
 /test/api_integration/apis/unified_field_list/ @elastic/kibana-data-discovery
 /x-pack/plugins/graph/ @elastic/kibana-data-discovery
 /x-pack/test/functional/apps/graph @elastic/kibana-data-discovery

packages/kbn-user-profile-components/src/user_profiles_popover.test.tsx

@@ -8,10 +8,11 @@
 
 import { shallow } from 'enzyme';
 import React from 'react';
+import { UserProfile } from './user_profile';
 
 import { UserProfilesPopover } from './user_profiles_popover';
 
-const userProfiles = [
+const userProfiles: UserProfile[] = [
   {
     uid: 'u_BOulL4QMPSyV9jg5lQI2JmCkUnokHTazBnet3xVHNv0_0',
     enabled: true,

packages/kbn-user-profile-components/src/user_profiles_selectable.test.tsx

@@ -8,10 +8,11 @@
 
 import { mount } from 'enzyme';
 import React from 'react';
+import { UserProfile } from './user_profile';
 
 import { UserProfilesSelectable } from './user_profiles_selectable';
 
-const userProfiles = [
+const userProfiles: UserProfile[] = [
   {
     uid: 'u_BOulL4QMPSyV9jg5lQI2JmCkUnokHTazBnet3xVHNv0_0',
     enabled: true,

src/plugins/discover/public/embeddable/saved_search_embeddable.tsx

@@ -484,6 +484,8 @@ export class SavedSearchEmbeddable
       ReactDOM.unmountComponentAtNode(this.node);
     }
     this.node = domNode;
+
+    this.renderReactComponent(this.node, this.searchProps!);
   }
 
   private renderReactComponent(domNode: HTMLElement, searchProps: SearchProps) {

src/plugins/discover/public/services/doc_views/components/doc_viewer_table/table_cell_actions.tsx

@@ -177,15 +177,13 @@ export const TableActions = ({
     },
   ];
 
-  const testSubject = `openFieldActionsButton-${field}`;
-
   if (mode === 'inline') {
     return (
       <EuiFlexGroup
         responsive={false}
         gutterSize="xs"
         className="kbnDocViewer__buttons"
-        data-test-subj={testSubject}
+        data-test-subj={`fieldActionsGroup-${field}`}
       >
         {panels[0].items.map((item) => (
           <EuiFlexItem key={item.icon} grow={false}>
@@ -210,7 +208,7 @@ export const TableActions = ({
     <EuiPopover
       button={
         <EuiButtonIcon
-          data-test-subj={testSubject}
+          data-test-subj={`openFieldActionsButton-${field}`}
           aria-label={openActionsLabel}
           onClick={toggleOpenPopover}
           iconType="boxesHorizontal"

test/accessibility/apps/discover.ts

@@ -117,13 +117,21 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
     it('a11y test for actions on a field', async () => {
       await PageObjects.discover.clickDocViewerTab(0);
-      await testSubjects.click('openFieldActionsButton-Cancelled');
+      if (await testSubjects.exists('openFieldActionsButton-Cancelled')) {
+        await testSubjects.click('openFieldActionsButton-Cancelled');
+      } else {
+        await testSubjects.existOrFail('fieldActionsGroup-Cancelled');
+      }
       await a11y.testAppSnapshot();
     });
 
     it('a11y test for data-grid table with columns', async () => {
       await testSubjects.click('toggleColumnButton-Cancelled');
-      await testSubjects.click('openFieldActionsButton-Carrier');
+      if (await testSubjects.exists('openFieldActionsButton-Carrier')) {
+        await testSubjects.click('openFieldActionsButton-Carrier');
+      } else {
+        await testSubjects.existOrFail('fieldActionsGroup-Carrier');
+      }
       await testSubjects.click('toggleColumnButton-Carrier');
       await testSubjects.click('euiFlyoutCloseButton');
       await toasts.dismissAllToasts();

test/functional/apps/context/_filters.ts

@@ -18,7 +18,6 @@ const TEST_COLUMN_NAMES = ['extension', 'geo.src'];
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const dataGrid = getService('dataGrid');
   const filterBar = getService('filterBar');
-  const testSubjects = getService('testSubjects');
   const retry = getService('retry');
   const browser = getService('browser');
 
@@ -34,12 +33,17 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     it('inclusive filter should be addable via expanded data grid rows', async function () {
       await retry.waitFor(`filter ${TEST_ANCHOR_FILTER_FIELD} in filterbar`, async () => {
         await dataGrid.clickRowToggle({ isAnchorRow: true, renderMoreRows: true });
-        await testSubjects.click(`openFieldActionsButton-${TEST_ANCHOR_FILTER_FIELD}`);
-        await testSubjects.click(`addFilterForValueButton-${TEST_ANCHOR_FILTER_FIELD}`);
+        await dataGrid.clickFieldActionInFlyout(
+          TEST_ANCHOR_FILTER_FIELD,
+          'addFilterForValueButton'
+        );
         await PageObjects.context.waitUntilContextLoadingHasFinished();
 
         return await filterBar.hasFilter(TEST_ANCHOR_FILTER_FIELD, TEST_ANCHOR_FILTER_VALUE, true);
       });
+
+      await dataGrid.closeFlyout();
+
       await retry.waitFor(`filter matching docs in data grid`, async () => {
         const fields = await dataGrid.getFields();
         return fields
@@ -71,8 +75,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     it('filter for presence should be addable via expanded data grid rows', async function () {
       await retry.waitFor('an exists filter in the filterbar', async () => {
         await dataGrid.clickRowToggle({ isAnchorRow: true, renderMoreRows: true });
-        await testSubjects.click(`openFieldActionsButton-${TEST_ANCHOR_FILTER_FIELD}`);
-        await testSubjects.click(`addExistsFilterButton-${TEST_ANCHOR_FILTER_FIELD}`);
+        await dataGrid.clickFieldActionInFlyout(TEST_ANCHOR_FILTER_FIELD, 'addExistsFilterButton');
         await PageObjects.context.waitUntilContextLoadingHasFinished();
         return await filterBar.hasFilter(TEST_ANCHOR_FILTER_FIELD, 'exists', true);
       });

test/functional/apps/discover/embeddable/_saved_search_embeddable.ts

@@ -77,5 +77,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
       await dataGrid.checkCurrentRowsPerPageToBe(10);
     });
+
+    it('should render duplicate saved search embeddables', async () => {
+      await PageObjects.dashboard.switchToEditMode();
+      await addSearchEmbeddableToDashboard();
+      const [firstGridCell, secondGridCell] = await dataGrid.getAllCellElements();
+      const firstGridCellContent = await firstGridCell.getVisibleText();
+      const secondGridCellContent = await secondGridCell.getVisibleText();
+
+      expect(firstGridCellContent).to.be.equal(secondGridCellContent);
+    });
   });
 }

test/functional/apps/discover/group2/_data_grid_doc_navigation.ts

@@ -60,9 +60,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await PageObjects.discover.waitUntilSearchingHasFinished();
 
       await dataGrid.clickRowToggle({ rowIndex: 0 });
-
-      await testSubjects.click('openFieldActionsButton-@timestamp');
-      await testSubjects.click('addExistsFilterButton-@timestamp');
+      await dataGrid.clickFieldActionInFlyout('@timestamp', 'addExistsFilterButton');
 
       const hasExistsFilter = await filterBar.hasFilter('@timestamp', 'exists', true, false, false);
       expect(hasExistsFilter).to.be(true);

test/functional/apps/discover/group2/_data_grid_doc_table.ts

@@ -197,17 +197,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
           // add columns
           const fields = ['_id', '_index', 'agent'];
           for (const field of fields) {
-            await testSubjects.click(`openFieldActionsButton-${field}`);
-            await testSubjects.click(`toggleColumnButton-${field}`);
+            await dataGrid.clickFieldActionInFlyout(field, 'toggleColumnButton');
           }
 
           const headerWithFields = await dataGrid.getHeaderFields();
           expect(headerWithFields.join(' ')).to.contain(fields.join(' '));
 
           // remove columns
           for (const field of fields) {
-            await testSubjects.click(`openFieldActionsButton-${field}`);
-            await testSubjects.click(`toggleColumnButton-${field}`);
+            await dataGrid.clickFieldActionInFlyout(field, 'toggleColumnButton');
           }
 
           const headerWithoutFields = await dataGrid.getHeaderFields();

test/functional/services/data_grid.ts

@@ -80,15 +80,24 @@ export class DataGridService extends FtrService {
       .map((cell) => $(cell).text());
   }
 
+  private getCellElementSelector(rowIndex: number = 0, columnIndex: number = 0) {
+    return `[data-test-subj="euiDataGridBody"] [data-test-subj="dataGridRowCell"][data-gridcell-column-index="${columnIndex}"][data-gridcell-row-index="${rowIndex}"]`;
+  }
+
   /**
    * Returns a grid cell element by row & column indexes.
    * @param rowIndex data row index starting from 0 (0 means 1st row)
    * @param columnIndex column index starting from 0 (0 means 1st column)
    */
   public async getCellElement(rowIndex: number = 0, columnIndex: number = 0) {
-    return await this.find.byCssSelector(
-      `[data-test-subj="euiDataGridBody"] [data-test-subj="dataGridRowCell"][data-gridcell-column-index="${columnIndex}"][data-gridcell-row-index="${rowIndex}"]`
-    );
+    return await this.find.byCssSelector(this.getCellElementSelector(rowIndex, columnIndex));
+  }
+
+  /**
+   * The same as getCellElement, but useful when multiple data grids are on the page.
+   */
+  public async getAllCellElements(rowIndex: number = 0, columnIndex: number = 0) {
+    return await this.find.allByCssSelector(this.getCellElementSelector(rowIndex, columnIndex));
   }
 
   public async getDocCount(): Promise<number> {
@@ -312,6 +321,17 @@ export class DataGridService extends FtrService {
     return await tableDocViewRow.findByTestSubject(`~removeInclusiveFilterButton`);
   }
 
+  public async clickFieldActionInFlyout(fieldName: string, actionName: string): Promise<void> {
+    const openPopoverButtonSelector = `openFieldActionsButton-${fieldName}`;
+    const inlineButtonsGroupSelector = `fieldActionsGroup-${fieldName}`;
+    if (await this.testSubjects.exists(openPopoverButtonSelector)) {
+      await this.testSubjects.click(openPopoverButtonSelector);
+    } else {
+      await this.testSubjects.existOrFail(inlineButtonsGroupSelector);
+    }
+    await this.testSubjects.click(`${actionName}-${fieldName}`);
+  }
+
   public async removeInclusiveFilter(
     detailsRow: WebElementWrapper,
     fieldName: string

x-pack/packages/ml/aiops_utils/src/stream_factory.test.ts

@@ -44,7 +44,12 @@ describe('streamFactory', () => {
       streamResult += chunk.toString('utf8');
     }
 
-    expect(responseWithHeaders.headers).toBe(undefined);
+    expect(responseWithHeaders.headers).toStrictEqual({
+      'Cache-Control': 'no-cache',
+      Connection: 'keep-alive',
+      'Transfer-Encoding': 'chunked',
+      'X-Accel-Buffering': 'no',
+    });
     expect(streamResult).toBe('push1push2');
   });
 
@@ -65,7 +70,12 @@ describe('streamFactory', () => {
 
     const parsedItems = streamItems.map((d) => JSON.parse(d));
 
-    expect(responseWithHeaders.headers).toBe(undefined);
+    expect(responseWithHeaders.headers).toStrictEqual({
+      'Cache-Control': 'no-cache',
+      Connection: 'keep-alive',
+      'Transfer-Encoding': 'chunked',
+      'X-Accel-Buffering': 'no',
+    });
     expect(parsedItems).toHaveLength(2);
     expect(parsedItems[0]).toStrictEqual(mockItem1);
     expect(parsedItems[1]).toStrictEqual(mockItem2);
@@ -105,7 +115,13 @@ describe('streamFactory', () => {
 
         const streamResult = decoded.toString('utf8');
 
-        expect(responseWithHeaders.headers).toStrictEqual({ 'content-encoding': 'gzip' });
+        expect(responseWithHeaders.headers).toStrictEqual({
+          'Cache-Control': 'no-cache',
+          Connection: 'keep-alive',
+          'content-encoding': 'gzip',
+          'Transfer-Encoding': 'chunked',
+          'X-Accel-Buffering': 'no',
+        });
         expect(streamResult).toBe('push1push2');
 
         done();
@@ -143,7 +159,13 @@ describe('streamFactory', () => {
 
         const parsedItems = streamItems.map((d) => JSON.parse(d));
 
-        expect(responseWithHeaders.headers).toStrictEqual({ 'content-encoding': 'gzip' });
+        expect(responseWithHeaders.headers).toStrictEqual({
+          'Cache-Control': 'no-cache',
+          Connection: 'keep-alive',
+          'content-encoding': 'gzip',
+          'Transfer-Encoding': 'chunked',
+          'X-Accel-Buffering': 'no',
+        });
         expect(parsedItems).toHaveLength(2);
         expect(parsedItems[0]).toStrictEqual(mockItem1);
         expect(parsedItems[1]).toStrictEqual(mockItem2);

x-pack/packages/ml/aiops_utils/src/stream_factory.ts

@@ -106,13 +106,16 @@ export function streamFactory<T = unknown>(
 
   const responseWithHeaders: StreamFactoryReturnType['responseWithHeaders'] = {
     body: stream,
-    ...(isCompressed
-      ? {
-          headers: {
-            'content-encoding': 'gzip',
-          },
-        }
-      : {}),
+    headers: {
+      ...(isCompressed ? { 'content-encoding': 'gzip' } : {}),
+
+      // This disables response buffering on proxy servers (Nginx, uwsgi, fastcgi, etc.)
+      // Otherwise, those proxies buffer responses up to 4/8 KiB.
+      'X-Accel-Buffering': 'no',
+      'Cache-Control': 'no-cache',
+      Connection: 'keep-alive',
+      'Transfer-Encoding': 'chunked',
+    },
   };
 
   return { DELIMITER, end, push, responseWithHeaders };

x-pack/plugins/cases/common/api/user.ts

@@ -7,11 +7,14 @@
 
 import * as rt from 'io-ts';
 
-export const UserRT = rt.type({
-  email: rt.union([rt.undefined, rt.null, rt.string]),
-  full_name: rt.union([rt.undefined, rt.null, rt.string]),
-  username: rt.union([rt.undefined, rt.null, rt.string]),
-});
+export const UserRT = rt.intersection([
+  rt.type({
+    email: rt.union([rt.undefined, rt.null, rt.string]),
+    full_name: rt.union([rt.undefined, rt.null, rt.string]),
+    username: rt.union([rt.undefined, rt.null, rt.string]),
+  }),
+  rt.partial({ profile_uid: rt.string }),
+]);
 
 export const UsersRt = rt.array(UserRT);
 

x-pack/plugins/cases/common/constants.ts

@@ -163,3 +163,8 @@ export const PUSH_CASES_CAPABILITY = 'push_cases' as const;
  */
 
 export const DEFAULT_USER_SIZE = 10;
+
+/**
+ * Delays
+ */
+export const SEARCH_DEBOUNCE_MS = 500;

x-pack/plugins/cases/common/ui/types.ts

@@ -103,6 +103,7 @@ export interface FilterOptions {
   severity: CaseSeverityWithAll;
   status: CaseStatusWithAllStatus;
   tags: string[];
+  assignees: string[];
   reporters: User[];
   owner: string[];
 }
@@ -162,7 +163,7 @@ export interface FieldMappings {
 
 export type UpdateKey = keyof Pick<
   CasePatchRequest,
-  'connector' | 'description' | 'status' | 'tags' | 'title' | 'settings' | 'severity'
+  'connector' | 'description' | 'status' | 'tags' | 'title' | 'settings' | 'severity' | 'assignees'
 >;
 
 export interface UpdateByKey {

x-pack/plugins/cases/public/common/mock/index.ts

@@ -6,3 +6,4 @@
  */
 
 export * from './test_providers';
+export * from './permissions';