Skip to content

Commit

Permalink
chore: use secret paths without /migrated
Browse files Browse the repository at this point in the history
  • Loading branch information
delanni committed Dec 5, 2023
1 parent aa23c6b commit efd5aa3
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 14 deletions.
4 changes: 2 additions & 2 deletions .buildkite/scripts/common/util.sh
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ vault_get() {
path=$1
field=$2

fullPath="secret/ci/elastic-kibana/migrated/$path"
fullPath="secret/ci/elastic-kibana/$path"
if [[ "$VAULT_ADDR" == *"secrets.elastic.co"* ]]; then
fullPath="secret/kibana-issues/dev/$path"
fi
Expand All @@ -193,7 +193,7 @@ vault_set() {
shift
fields=("$@")

fullPath="secret/ci/elastic-kibana/migrated/$path"
fullPath="secret/ci/elastic-kibana/$path"
if [[ "$VAULT_ADDR" == *"secrets.elastic.co"* ]]; then
fullPath="secret/kibana-issues/dev/$path"
fi
Expand Down
10 changes: 0 additions & 10 deletions .buildkite/scripts/pipelines/pull_request/pipeline.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,6 @@ const getPipeline = (filename: string, removeSteps = true) => {
return removeSteps ? str.replace(/^steps:/, '') : str;
};

const uploadPipeline = (pipelineContent: string | object) => {
const str =
typeof pipelineContent === 'string' ? pipelineContent : JSON.stringify(pipelineContent);

execSync('buildkite-agent pipeline upload', {
input: str,
stdio: ['pipe', 'inherit', 'inherit'],
});
};

(async () => {
try {
const skippable = await areChangesSkippable(SKIPPABLE_PR_MATCHERS, REQUIRED_PATHS);
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/scripts/steps/cloud/purge_deployment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const deploymentsListJson = execSync('ecctl deployment list --output json').toSt
const { deployments } = JSON.parse(deploymentsListJson);
const secretBasePath = process.env.VAULT_ADDR?.match(/secrets\.elastic\.co/g)
? 'secret/kibana-issues/dev'
: 'secret/ci/elastic-kibana/migrated';
: 'secret/ci/elastic-kibana';

const prNumber = parseInt(
process.env.KIBANA_PULL_REQUEST ||
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/scripts/steps/cloud/purge_deployments.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const deploymentsListJson = execSync('ecctl deployment list --output json').toSt
const { deployments } = JSON.parse(deploymentsListJson);
const secretBasePath = process.env.VAULT_ADDR?.match(/secrets\.elastic\.co/g)
? 'secret/kibana-issues/dev'
: 'secret/ci/elastic-kibana/migrated';
: 'secret/ci/elastic-kibana';

const prDeployments = deployments.filter((deployment: any) =>
deployment.name.startsWith('kibana-pr-')
Expand Down

0 comments on commit efd5aa3

Please sign in to comment.