Merge branch 'master' into how-to-build-a-kibana-distributable-tutorial

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.searchstrategydependencies.md

@@ -15,6 +15,7 @@ export interface SearchStrategyDependencies
 |  Property | Type | Description |
 |  --- | --- | --- |
 |  [esClient](./kibana-plugin-plugins-data-server.searchstrategydependencies.esclient.md) | <code>IScopedClusterClient</code> |  |
+|  [request](./kibana-plugin-plugins-data-server.searchstrategydependencies.request.md) | <code>KibanaRequest</code> |  |
 |  [savedObjectsClient](./kibana-plugin-plugins-data-server.searchstrategydependencies.savedobjectsclient.md) | <code>SavedObjectsClientContract</code> |  |
 |  [searchSessionsClient](./kibana-plugin-plugins-data-server.searchstrategydependencies.searchsessionsclient.md) | <code>IScopedSearchSessionsClient</code> |  |
 |  [uiSettingsClient](./kibana-plugin-plugins-data-server.searchstrategydependencies.uisettingsclient.md) | <code>IUiSettingsClient</code> |  |

packages/elastic-datemath/BUILD.bazel

@@ -55,7 +55,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-ace/BUILD.bazel

@@ -64,7 +64,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )
@@ -82,4 +82,4 @@ filegroup(
     ":npm_module",
   ],
   visibility = ["//visibility:public"],
-)
+)

packages/kbn-analytics/BUILD.bazel

@@ -103,7 +103,7 @@ pkg_npm(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":target"] + DEPS,
+  deps = DEPS + [":target"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-apm-config-loader/BUILD.bazel

@@ -66,7 +66,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-apm-utils/BUILD.bazel

@@ -54,7 +54,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-babel-code-parser/BUILD.bazel

@@ -53,7 +53,7 @@ babel(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":target"] + DEPS,
+  deps = DEPS + [":target"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-config-schema/BUILD.bazel

@@ -64,7 +64,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-config/BUILD.bazel

@@ -76,7 +76,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-crypto/BUILD.bazel

@@ -67,7 +67,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )
@@ -85,4 +85,4 @@ filegroup(
     ":npm_module",
   ],
   visibility = ["//visibility:public"],
-) 
+)

packages/kbn-dev-utils/BUILD.bazel

@@ -107,7 +107,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-docs-utils/BUILD.bazel

@@ -67,7 +67,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-es/BUILD.bazel

@@ -69,7 +69,7 @@ babel(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":target"] + DEPS,
+  deps = DEPS + [":target"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-i18n/BUILD.bazel

@@ -111,7 +111,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc", ":tsc_browser"] + DEPS,
+  deps = DEPS + [":tsc", ":tsc_browser"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-i18n/tsconfig.browser.json

@@ -8,7 +8,10 @@
     "isolatedModules": true,
     "sourceMap": true,
     "sourceRoot": "../../../../../packages/kbn-i18n/src",
-    "types": ["node"],
+    "types": [
+      "jest",
+      "node"
+    ],
   },
   "include": [
     "src/**/*.ts",

packages/kbn-legacy-logging/BUILD.bazel

@@ -71,7 +71,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-logging/BUILD.bazel

@@ -61,7 +61,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-optimizer/limits.yml

@@ -46,7 +46,7 @@ pageLoadAssetSize:
   lens: 96624
   licenseManagement: 41817
   licensing: 29004
-  lists: 200000
+  lists: 22900
   logstash: 53548
   management: 46112
   maps: 80000

packages/kbn-plugin-generator/BUILD.bazel

@@ -85,7 +85,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-securitysolution-constants/BUILD.bazel

@@ -65,7 +65,7 @@ js_library(
   package_name = PKG_REQUIRE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
   visibility = ["//visibility:public"],
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
 )
 
 pkg_npm(

packages/kbn-securitysolution-es-utils/BUILD.bazel

@@ -67,7 +67,7 @@ js_library(
   package_name = PKG_REQUIRE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
   visibility = ["//visibility:public"],
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
 )
 
 pkg_npm(

packages/kbn-securitysolution-io-ts-alerting-types/BUILD.bazel

@@ -73,7 +73,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-securitysolution-io-ts-list-types/BUILD.bazel

@@ -73,7 +73,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-securitysolution-io-ts-types/BUILD.bazel

@@ -72,7 +72,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-securitysolution-io-ts-utils/BUILD.bazel

@@ -71,7 +71,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-securitysolution-list-api/BUILD.bazel

@@ -69,7 +69,7 @@ js_library(
   package_name = PKG_REQUIRE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
   visibility = ["//visibility:public"],
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
 )
 
 pkg_npm(

packages/kbn-securitysolution-list-hooks/BUILD.bazel

@@ -74,7 +74,7 @@ js_library(
   package_name = PKG_REQUIRE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
   visibility = ["//visibility:public"],
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
 )
 
 pkg_npm(

packages/kbn-securitysolution-list-utils/BUILD.bazel

@@ -70,7 +70,7 @@ js_library(
   package_name = PKG_REQUIRE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
   visibility = ["//visibility:public"],
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
 )
 
 pkg_npm(

packages/kbn-securitysolution-utils/BUILD.bazel

@@ -67,7 +67,7 @@ js_library(
   package_name = PKG_REQUIRE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
   visibility = ["//visibility:public"],
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
 )
 
 pkg_npm(

packages/kbn-server-http-tools/BUILD.bazel

@@ -69,7 +69,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-std/BUILD.bazel

@@ -64,7 +64,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-telemetry-tools/BUILD.bazel

@@ -76,7 +76,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-utility-types/BUILD.bazel

@@ -58,7 +58,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = "@kbn/utility-types",
   visibility = ["//visibility:public"],
 )

packages/kbn-utils/BUILD.bazel

@@ -61,7 +61,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

src/core/server/saved_objects/migrations/core/document_migrator.test.ts

@@ -748,14 +748,8 @@ describe('DocumentMigrator', () => {
         migrator.migrate(_.cloneDeep(failedDoc));
         expect('Did not throw').toEqual('But it should have!');
       } catch (error) {
-        expect(error.message).toMatchInlineSnapshot(`
-          "Failed to transform document smelly. Transform: dog:1.2.3
-          Doc: {\\"id\\":\\"smelly\\",\\"type\\":\\"dog\\",\\"attributes\\":{},\\"migrationVersion\\":{}}"
-        `);
+        expect(error.message).toBe('Dang diggity!');
         expect(error).toBeInstanceOf(TransformSavedObjectDocumentError);
-        expect(loggingSystemMock.collect(mockLoggerFactory).error[0][0]).toMatchInlineSnapshot(
-          `[Error: Dang diggity!]`
-        );
       }
     });
 

src/core/server/saved_objects/migrations/core/document_migrator.ts

@@ -679,19 +679,8 @@ function wrapWithTry(
 
       return { transformedDoc: result, additionalDocs: [] };
     } catch (error) {
-      const failedTransform = `${type.name}:${version}`;
-      const failedDoc = JSON.stringify(doc);
       log.error(error);
-      // To make debugging failed migrations easier, we add items needed to convert the
-      // saved object id to the full raw id (the id only contains the uuid part) and the full error itself
-      throw new TransformSavedObjectDocumentError(
-        doc.id,
-        doc.type,
-        doc.namespace,
-        failedTransform,
-        failedDoc,
-        error
-      );
+      throw new TransformSavedObjectDocumentError(error);
     }
   };
 }

src/core/server/saved_objects/migrations/core/migrate_raw_docs.test.ts

@@ -233,34 +233,7 @@ describe('migrateRawDocsSafely', () => {
 
   test('instance of Either.left containing transform errors when the transform function throws a TransformSavedObjectDocument error', async () => {
     const transform = jest.fn<any, any>((doc: any) => {
-      throw new TransformSavedObjectDocumentError(
-        `${doc.id}`,
-        `${doc.type}`,
-        `${doc.namespace}`,
-        `${doc.type}1.2.3`,
-        JSON.stringify(doc),
-        new Error('error during transform')
-      );
-    });
-    const task = migrateRawDocsSafely(
-      new SavedObjectsSerializer(new SavedObjectTypeRegistry()),
-      transform,
-      [{ _id: 'a:b', _source: { type: 'a', a: { name: 'AAA' } } }] // this is the raw doc
-    );
-    const result = (await task()) as Either.Left<DocumentsTransformFailed>;
-    expect(transform).toHaveBeenCalledTimes(1);
-    expect(result._tag).toEqual('Left');
-    expect(result.left.corruptDocumentIds.length).toEqual(0);
-    expect(result.left.transformErrors.length).toEqual(1);
-    expect(result.left.transformErrors[0].err.message).toMatchInlineSnapshot(`
-      "Failed to transform document b. Transform: a1.2.3
-      Doc: {\\"type\\":\\"a\\",\\"id\\":\\"b\\",\\"attributes\\":{\\"name\\":\\"AAA\\"},\\"references\\":[],\\"migrationVersion\\":{}}"
-    `);
-  });
-
-  test("instance of Either.left containing errors when the transform function throws an error that isn't a TransformSavedObjectDocument error", async () => {
-    const transform = jest.fn<any, any>((doc: any) => {
-      throw new Error('error during transform');
+      throw new TransformSavedObjectDocumentError(new Error('error during transform'));
     });
     const task = migrateRawDocsSafely(
       new SavedObjectsSerializer(new SavedObjectTypeRegistry()),