Please code review

elastic · Mar 7, 2022 · e98197e · e98197e
1 parent 2927134
commit e98197e
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 12 deletions.
diff --git a/x-pack/plugins/security_solution/cypress/integration/hosts/host_risk_tab.spec.ts b/x-pack/plugins/security_solution/cypress/integration/hosts/host_risk_tab.spec.ts
@@ -7,14 +7,15 @@
 
 import { cleanKibana } from '../../tasks/common';
 import { esArchiverLoad, esArchiverUnload } from '../../tasks/es_archiver';
-import { navigateToHostRiskDetailTab } from '../../tasks/host_risk';
+import {
+  navigateToHostRiskDetailTab,
+  openRiskTableFilterAndSelectTheCriticalOption,
+  removeCritialFilter,
+  selectFiveItemsPerPageOption,
+} from '../../tasks/host_risk';
 import {
   HOST_BY_RISK_TABLE_CELL,
-  HOST_BY_RISK_TABLE_FILTER,
-  HOST_BY_RISK_TABLE_FILTER_CRITICAL,
   HOST_BY_RISK_TABLE_HOSTNAME_CELL,
-  HOST_BY_RISK_TABLE_PERPAGE_BUTTON,
-  HOST_BY_RISK_TABLE_PERPAGE_OPTIONS,
   HOST_BY_RISK_TABLE_NEXT_PAGE_BUTTON,
 } from '../../screens/hosts/host_risk';
 import { loginAndWaitForPage } from '../../tasks/login';
@@ -42,18 +43,15 @@ describe('risk tab', () => {
   });
 
   it('filters the table', () => {
-    cy.get(HOST_BY_RISK_TABLE_FILTER).click();
-    cy.get(HOST_BY_RISK_TABLE_FILTER_CRITICAL).click();
+    openRiskTableFilterAndSelectTheCriticalOption();
 
     cy.get(HOST_BY_RISK_TABLE_CELL).eq(3).should('not.have.text', 'siem-kibana');
 
-    // remove filter
-    cy.get(HOST_BY_RISK_TABLE_FILTER_CRITICAL).click();
+    removeCritialFilter();
   });
 
   it('should be able to change items count per page', () => {
-    cy.get(HOST_BY_RISK_TABLE_PERPAGE_BUTTON).click();
-    cy.get(HOST_BY_RISK_TABLE_PERPAGE_OPTIONS).first().click();
+    selectFiveItemsPerPageOption();
 
     cy.get(HOST_BY_RISK_TABLE_HOSTNAME_CELL).should('have.length', 5);
   });

diff --git a/x-pack/plugins/security_solution/cypress/tasks/host_risk.ts b/x-pack/plugins/security_solution/cypress/tasks/host_risk.ts
@@ -5,7 +5,15 @@
  * 2.0.
  */
 
-import { LOADING_TABLE, RISK_DETAILS_NAV, RISK_FLYOUT_TRIGGER } from '../screens/hosts/host_risk';
+import {
+  HOST_BY_RISK_TABLE_FILTER,
+  HOST_BY_RISK_TABLE_FILTER_CRITICAL,
+  HOST_BY_RISK_TABLE_PERPAGE_BUTTON,
+  HOST_BY_RISK_TABLE_PERPAGE_OPTIONS,
+  LOADING_TABLE,
+  RISK_DETAILS_NAV,
+  RISK_FLYOUT_TRIGGER,
+} from '../screens/hosts/host_risk';
 
 export const navigateToHostRiskDetailTab = () => cy.get(RISK_DETAILS_NAV).click();
 
@@ -15,3 +23,15 @@ export const waitForTableToLoad = () => {
   cy.get(LOADING_TABLE).should('exist');
   cy.get(LOADING_TABLE).should('not.exist');
 };
+
+export const openRiskTableFilterAndSelectTheCriticalOption = () => {
+  cy.get(HOST_BY_RISK_TABLE_FILTER).click();
+  cy.get(HOST_BY_RISK_TABLE_FILTER_CRITICAL).click();
+};
+export const removeCritialFilter = () => {
+  cy.get(HOST_BY_RISK_TABLE_FILTER_CRITICAL).click();
+};
+export const selectFiveItemsPerPageOption = () => {
+  cy.get(HOST_BY_RISK_TABLE_PERPAGE_BUTTON).click();
+  cy.get(HOST_BY_RISK_TABLE_PERPAGE_OPTIONS).first().click();
+};