checking for flakiness of index pattern filter test (#144180)

* checking for flakiness of index pattern filter test * added a small code change to check if the popover is open
elastic · Oct 31, 2022 · e92b384 · e92b384
1 parent 4695c9a
commit e92b384
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/test/functional/apps/management/_index_pattern_filter.ts b/test/functional/apps/management/_index_pattern_filter.ts
@@ -13,12 +13,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const kibanaServer = getService('kibanaServer');
   const retry = getService('retry');
   const PageObjects = getPageObjects(['settings']);
-  const esArchiver = getService('esArchiver');
 
-  // Failing: See https://github.com/elastic/kibana/issues/143109
-  describe.skip('index pattern filter', function describeIndexTests() {
+  describe('index pattern filter', function describeIndexTests() {
     before(async function () {
-      await esArchiver.emptyKibanaIndex();
+      await kibanaServer.savedObjects.cleanStandardList();
       await kibanaServer.uiSettings.replace({});
       await PageObjects.settings.navigateTo();
       await PageObjects.settings.clickKibanaIndexPatterns();
@@ -30,6 +28,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
     afterEach(async function () {
       await PageObjects.settings.removeIndexPattern();
+      await kibanaServer.savedObjects.cleanStandardList();
     });
 
     it('should filter indexed fields', async function () {

diff --git a/test/functional/page_objects/settings_page.ts b/test/functional/page_objects/settings_page.ts
@@ -306,9 +306,11 @@ export class SettingsPageObject extends FtrService {
   }
 
   async clearFieldTypeFilter(type: string) {
-    await this.testSubjects.clickWhenNotDisabledWithoutRetry('indexedFieldTypeFilterDropdown');
     await this.retry.try(async () => {
-      await this.testSubjects.existOrFail('indexedFieldTypeFilterDropdown-popover');
+      await this.testSubjects.clickWhenNotDisabledWithoutRetry('indexedFieldTypeFilterDropdown');
+      await this.find.byCssSelector(
+        '.euiPopover-isOpen[data-test-subj="indexedFieldTypeFilterDropdown-popover"]'
+      );
     });
     await this.retry.try(async () => {
       await this.testSubjects.existOrFail(`indexedFieldTypeFilterDropdown-option-${type}-checked`);
@@ -319,8 +321,12 @@ export class SettingsPageObject extends FtrService {
   }
 
   async setFieldTypeFilter(type: string) {
-    await this.testSubjects.clickWhenNotDisabledWithoutRetry('indexedFieldTypeFilterDropdown');
-    await this.testSubjects.existOrFail('indexedFieldTypeFilterDropdown-popover');
+    await this.retry.try(async () => {
+      await this.testSubjects.clickWhenNotDisabledWithoutRetry('indexedFieldTypeFilterDropdown');
+      await this.find.byCssSelector(
+        '.euiPopover-isOpen[data-test-subj="indexedFieldTypeFilterDropdown-popover"]'
+      );
+    });
     await this.testSubjects.existOrFail(`indexedFieldTypeFilterDropdown-option-${type}`);
     await this.testSubjects.click(`indexedFieldTypeFilterDropdown-option-${type}`);
     await this.testSubjects.existOrFail(`indexedFieldTypeFilterDropdown-option-${type}-checked`);