Skip to content

Commit

Permalink
include and fix hello world example test (#108072)
Browse files Browse the repository at this point in the history
  • Loading branch information
Dosant authored Aug 11, 2021
1 parent 86c17da commit e86d909
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion examples/hello_world/public/plugin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class HelloWorldPlugin implements Plugin<void, void, SetupDeps> {
id: 'helloWorld',
title: 'Hello World',
async mount({ element }: AppMountParameters) {
ReactDOM.render(<div id="helloWorldDiv">Hello World!</div>, element);
ReactDOM.render(<div data-test-subj="helloWorldDiv">Hello World!</div>, element);
return () => ReactDOM.unmountComponentAtNode(element);
},
});
Expand Down
1 change: 1 addition & 0 deletions test/examples/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export default async function ({ readConfigFile }) {

return {
testFiles: [
require.resolve('./hello_world'),
require.resolve('./embeddables'),
require.resolve('./bfetch_explorer'),
require.resolve('./ui_actions'),
Expand Down

0 comments on commit e86d909

Please sign in to comment.