Merge branch 'master' into kertal-pr-2021-10-13-dicover-improve-doc-v…

…iewer-code

.buildkite/scripts/build_kibana.sh

@@ -5,7 +5,11 @@ set -euo pipefail
 export KBN_NP_PLUGINS_BUILT=true
 
 echo "--- Build Kibana Distribution"
-node scripts/build --debug
+if [[ "${GITHUB_PR_LABELS:-}" == *"ci:build-all-platforms"* ]]; then
+  node scripts/build --all-platforms --skip-os-packages
+else
+  node scripts/build
+fi
 
 echo "--- Archive Kibana Distribution"
 linuxBuild="$(find "$KIBANA_DIR/target" -name 'kibana-*-linux-x86_64.tar.gz')"

.buildkite/scripts/pipelines/pull_request/pipeline.js

@@ -55,21 +55,20 @@ const uploadPipeline = (pipelineContent) => {
     pipeline.push(getPipeline('.buildkite/pipelines/pull_request/base.yml', false));
 
     if (
-      await doAnyChangesMatch([
+      (await doAnyChangesMatch([
         /^x-pack\/plugins\/security_solution/,
         /^x-pack\/test\/security_solution_cypress/,
         /^x-pack\/plugins\/triggers_actions_ui\/public\/application\/sections\/action_connector_form/,
         /^x-pack\/plugins\/triggers_actions_ui\/public\/application\/context\/actions_connectors_context\.tsx/,
-      ]) || process.env.GITHUB_PR_LABELS.includes('ci:all-cypress-suites')
+      ])) ||
+      process.env.GITHUB_PR_LABELS.includes('ci:all-cypress-suites')
     ) {
       pipeline.push(getPipeline('.buildkite/pipelines/pull_request/security_solution.yml'));
     }
 
-    // Disabled for now, these are failing/disabled in Jenkins currently as well
     // if (
-    //   await doAnyChangesMatch([
-    //     /^x-pack\/plugins\/apm/,
-    //   ]) || process.env.GITHUB_PR_LABELS.includes('ci:all-cypress-suites')
+    //   (await doAnyChangesMatch([/^x-pack\/plugins\/apm/])) ||
+    //   process.env.GITHUB_PR_LABELS.includes('ci:all-cypress-suites')
     // ) {
     //   pipeline.push(getPipeline('.buildkite/pipelines/pull_request/apm_cypress.yml'));
     // }

.buildkite/scripts/post_build_kibana.sh

@@ -12,7 +12,6 @@ fi
 echo "--- Upload Build Artifacts"
 # Moving to `target/` first will keep `buildkite-agent` from including directories in the artifact name
 cd "$KIBANA_DIR/target"
-mv kibana-*-linux-x86_64.tar.gz kibana-default.tar.gz
-buildkite-agent artifact upload kibana-default.tar.gz
-buildkite-agent artifact upload kibana-default-plugins.tar.gz
+cp kibana-*-linux-x86_64.tar.gz kibana-default.tar.gz
+buildkite-agent artifact upload "./*.tar.gz;./*.zip"
 cd -

.ci/Dockerfile

@@ -1,7 +1,7 @@
 # NOTE: This Dockerfile is ONLY used to run certain tasks in CI. It is not used to run Kibana or as a distributable.
 # If you're looking for the Kibana Docker image distributable, please see: src/dev/build/tasks/os_packages/docker_generator/templates/dockerfile.template.ts
 
-ARG NODE_VERSION=14.17.6
+ARG NODE_VERSION=16.11.1
 
 FROM node:${NODE_VERSION} AS base
 
@@ -10,7 +10,7 @@ RUN apt-get update && \
       libdbus-1-3 libexpat1 libfontconfig1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 \
       libgtk-3-0 libnspr4 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 \
       libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 \
-      libxtst6 ca-certificates fonts-liberation libappindicator1 libnss3 lsb-release xdg-utils wget openjdk-8-jre && \
+      libxtst6 ca-certificates fonts-liberation libappindicator1 libnss3 lsb-release xdg-utils wget openjdk-11-jre && \
     rm -rf /var/lib/apt/lists/*
 
 RUN curl -sSL https://dl.google.com/linux/linux_signing_key.pub | apt-key add - \

.node-version

@@ -1 +1 @@
-14.17.6
+16.11.1

.nvmrc

@@ -1 +1 @@
-14.17.6
+16.11.1

WORKSPACE.bazel

@@ -27,13 +27,13 @@ check_rules_nodejs_version(minimum_version_string = "3.8.0")
 # we can update that rule.
 node_repositories(
   node_repositories = {
-    "14.17.6-darwin_amd64": ("node-v14.17.6-darwin-x64.tar.gz", "node-v14.17.6-darwin-x64", "e3e4c02240d74fb1dc8a514daa62e5de04f7eaee0bcbca06a366ece73a52ad88"),
-    "14.17.6-linux_arm64": ("node-v14.17.6-linux-arm64.tar.xz", "node-v14.17.6-linux-arm64", "9c4f3a651e03cd9b5bddd33a80e8be6a6eb15e518513e410bb0852a658699156"),
-    "14.17.6-linux_s390x": ("node-v14.17.6-linux-s390x.tar.xz", "node-v14.17.6-linux-s390x", "3677f35b97608056013b5368f86eecdb044bdccc1b3976c1d4448736c37b6a0c"),
-    "14.17.6-linux_amd64": ("node-v14.17.6-linux-x64.tar.xz", "node-v14.17.6-linux-x64", "3bbe4faf356738d88b45be222bf5e858330541ff16bd0d4cfad36540c331461b"),
-    "14.17.6-windows_amd64": ("node-v14.17.6-win-x64.zip", "node-v14.17.6-win-x64", "b83e9ce542fda7fc519cec6eb24a2575a84862ea4227dedc171a8e0b5b614ac0"),
+    "16.11.1-darwin_amd64": ("node-v16.11.1-darwin-x64.tar.gz", "node-v16.11.1-darwin-x64", "ba54b8ed504bd934d03eb860fefe991419b4209824280d4274f6a911588b5e45"),
+    "16.11.1-linux_arm64": ("node-v16.11.1-linux-arm64.tar.xz", "node-v16.11.1-linux-arm64", "083fc51f0ea26de9041aaf9821874651a9fd3b20d1cf57071ce6b523a0436f17"),
+    "16.11.1-linux_s390x": ("node-v16.11.1-linux-s390x.tar.xz", "node-v16.11.1-linux-s390x", "855b5c83c2ccb05273d50bb04376335c68d47df57f3187cdebe1f22b972d2825"),
+    "16.11.1-linux_amd64": ("node-v16.11.1-linux-x64.tar.xz", "node-v16.11.1-linux-x64", "493bcc9b660eff983a6de65a0f032eb2717f57207edf74c745bcb86e360310b3"),
+    "16.11.1-windows_amd64": ("node-v16.11.1-win-x64.zip", "node-v16.11.1-win-x64", "4d3c179b82d42e66e321c3948a4e332ed78592917a69d38b86e3a242d7e62fb7"),
   },
-  node_version = "14.17.6",
+  node_version = "16.11.1",
   node_urls = [
     "https://nodejs.org/dist/v{version}/{filename}",
   ],

config/kibana.yml

@@ -94,6 +94,8 @@
 #logging.appenders.default:
 #  type: file
 #  fileName: /var/logs/kibana.log
+#  layout:
+#    type: json
 
 # Logs queries sent to Elasticsearch.
 #logging.loggers:

config/node.options

@@ -4,3 +4,6 @@
 
 ## max size of old space in megabytes
 #--max-old-space-size=4096
+
+## do not terminate process on unhandled promise rejection
+ --unhandled-rejections=warn

docs/dev-tools/console/console.asciidoc

@@ -129,13 +129,3 @@ image::dev-tools/console/images/console-settings.png["Console Settings", width=6
 
 For a list of available keyboard
 shortcuts, click *Help*.
-
-[float]
-[[console-settings]]
-=== Disable Console
-
-deprecated:[7.16.0,"In 8.0 and later, this setting will no longer be supported."]
-If you don’t want to use *Console*, you can disable it by setting `console.enabled`
-to `false` in your `kibana.yml` configuration file. Changing this setting
-causes the server to regenerate assets on the next startup,
-which might cause a delay before pages start being served.

docs/migration/migrate_8_0.asciidoc

@@ -17,6 +17,7 @@ See also <<whats-new>> and <<release-notes>>.
 //NOTE: The notable-breaking-changes tagged regions are re-used in the
 //Installation and Upgrade Guide
 
+// tag::notable-breaking-changes[]
 [float]
 [[breaking_80_index_pattern_changes]]
 === Index pattern changes
@@ -30,18 +31,24 @@ to function as expected. Support for these index patterns has been removed in 8.
 *Impact:* You must migrate your time_based index patterns to a wildcard pattern,
 for example, `logstash-*`.
 
-
 [float]
 [[breaking_80_setting_changes]]
 === Settings changes
 
-// tag::notable-breaking-changes[]
 [float]
 ==== Multitenancy by changing `kibana.index` is no longer supported
 *Details:* `kibana.index`, `xpack.reporting.index` and `xpack.task_manager.index` can no longer be specified. 
 
 *Impact:* Users who relied on changing these settings to achieve multitenancy should use *Spaces*, cross-cluster replication, or cross-cluster search instead. To migrate to *Spaces*, users are encouraged to use saved object management to export their saved objects from a tenant into the default tenant in a space. Improvements are planned to improve on this workflow. See https://github.com/elastic/kibana/issues/82020 for more details.   
 
+[float]
+==== Disabling most plugins with the `{plugin_name}.enabled` setting is no longer supported
+*Details:* The ability for most plugins to be disabled using the `{plugin_name}.enabled` config option has been removed.
+
+*Impact:* Some plugins, such as `telemetry`, `newsfeed`, `reporting`, and the various `vis_type` plugins will continue to support this setting, however the rest of the plugins that ship with Kibana will not. By default, any newly created plugins will not support this configuration unless it is explicitly added to the plugin's `configSchema`.
+
+If you are currently using one of these settings in your Kibana config, please remove it before upgrading to 8.0. If you were using these settings to control user access to certain Kibana applications, we recommend leveraging Feature Controls instead.
+
 [float]
 ==== Legacy browsers are now rejected by default
 *Details:* `csp.strict` is now enabled by default, so Kibana will fail to load for older, legacy browsers that do not enforce basic Content Security Policy protections - notably Internet Explorer 11.

docs/settings/apm-settings.asciidoc

@@ -40,10 +40,6 @@ Changing these settings may disable features of the APM App.
 
 [cols="2*<"]
 |===
-| `xpack.apm.enabled` {ess-icon}
-  | deprecated:[7.16.0,"In 8.0 and later, this setting will no longer be supported."]
-  Set to `false` to disable the APM app. Defaults to `true`.
-
 | `xpack.apm.maxServiceEnvironments` {ess-icon}
   | Maximum number of unique service environments recognized by the UI. Defaults to `100`.
 

docs/settings/fleet-settings.asciidoc

@@ -20,9 +20,6 @@ See the {fleet-guide}/index.html[{fleet}] docs for more information.
 
 [cols="2*<"]
 |===
-| `xpack.fleet.enabled` {ess-icon}
-  | deprecated:[7.16.0,"In 8.0 and later, this setting will no longer be supported."]
-  Set to `true` (default) to enable {fleet}. 
 | `xpack.fleet.agents.enabled` {ess-icon}
   | Set to `true` (default) to enable {fleet}. 
 |===

docs/settings/general-infra-logs-ui-settings.asciidoc

@@ -1,8 +1,4 @@
 
-`xpack.infra.enabled`::
-deprecated:[7.16.0,"In 8.0 and later, this setting will no longer be supported."]
-Set to `false` to disable the Logs and Metrics app plugin {kib}. Defaults to `true`.
-
 `xpack.infra.sources.default.logAlias`::
 Index pattern for matching indices that contain log data. Defaults to `filebeat-*,kibana_sample_data_logs*`. To match multiple wildcard patterns, use a comma to separate the names, with no space after the comma. For example, `logstash-app1-*,default-logs-*`.
 

docs/settings/logging-settings.asciidoc

@@ -31,7 +31,7 @@ logging:
       layout:
         type: pattern
   root:
-    appenders: [default, file]
+    appenders: [file]
 ----
 
 [[log-in-json-ECS-example]]
@@ -49,7 +49,7 @@ logging:
       layout:
         type: json
   root:
-    appenders: [default, json-layout]
+    appenders: [json-layout]
 ----
 
 [[log-with-meta-to-stdout]]
@@ -67,7 +67,7 @@ logging:
         type: pattern
         pattern: "[%date] [%level] [%logger] [%meta] %message"
   root:
-    appenders: [default, console-meta]
+    appenders: [console-meta]
 ----
 
 [[log-elasticsearch-queries]]
@@ -83,7 +83,7 @@ logging:
         type: pattern
         highlight: true
   root:
-    appenders: [default, console_appender]
+    appenders: [console_appender]
     level: warn
   loggers:
     - name: elasticsearch.query
@@ -128,7 +128,7 @@ logging:
         type: json
 
   root:
-    appenders: [default, console, file]
+    appenders: [console, file]
     level: error
 
   loggers:

docs/settings/monitoring-settings.asciidoc

@@ -31,13 +31,6 @@ For more information, see
 
 [cols="2*<"]
 |===
-| `monitoring.enabled`
-  | deprecated:[7.16.0,"In 8.0 and later, this setting will no longer be supported."]
-  Set to `true` (default) to enable the {monitor-features} in {kib}. Unlike the
-  <<monitoring-ui-enabled, `monitoring.ui.enabled`>> setting, when this setting is `false`, the
-  monitoring back-end does not run and {kib} stats are not sent to the monitoring
-  cluster.
-
 | `monitoring.ui.ccs.enabled`
   | Set to `true` (default) to enable {ref}/modules-cross-cluster-search.html[cross-cluster search] of your monitoring data. The {ref}/modules-remote-clusters.html#remote-cluster-settings[`remote_cluster_client`] role must exist on each node.
 

docs/settings/settings-xkb.asciidoc

@@ -13,11 +13,8 @@ For more {kib} configuration settings, see <<settings>>.
 include::alert-action-settings.asciidoc[]
 include::apm-settings.asciidoc[]
 include::banners-settings.asciidoc[]
-include::dev-settings.asciidoc[]
-include::graph-settings.asciidoc[]
 include::infrastructure-ui-settings.asciidoc[]
 include::logs-ui-settings.asciidoc[]
-include::ml-settings.asciidoc[]
 include::reporting-settings.asciidoc[]
 include::spaces-settings.asciidoc[]
 include::task-manager-settings.asciidoc[]

docs/settings/url-drilldown-settings.asciidoc

@@ -8,10 +8,6 @@ Configure the URL drilldown settings in your `kibana.yml` configuration file.
 
 [cols="2*<"]
 |===
-| [[url-drilldown-enabled]] `url_drilldown.enabled`
- | deprecated:[7.16.0,"In 8.0 and later, this setting will no longer be supported."]
- When `true`, enables URL drilldowns on your {kib} instance.
-
 | [[external-URL-policy]] `externalUrl.policy`
  | Configures the external URL policies. URL drilldowns respect the global *External URL* service, which you can use to deny or allow external URLs.
 By default all external URLs are allowed.

docs/setup/settings.asciidoc

@@ -20,11 +20,12 @@ configuration using `${MY_ENV_VAR}` syntax.
 [cols="2*<"]
 |===
 
-| `console.enabled:`
- | deprecated:[7.16.0,"In 8.0 and later, this setting will no longer be supported."]
-Toggling this causes the server to regenerate assets on the next startup,
-which may cause a delay before pages start being served.
-Set to `false` to disable Console. *Default: `true`*
+| `csp.rules:`
+ | deprecated:[7.14.0,"In 8.0 and later, this setting will no longer be supported."]
+A https://w3c.github.io/webappsec-csp/[Content Security Policy] template
+that disables certain unnecessary and potentially insecure capabilities in
+the browser. It is strongly recommended that you keep the default CSP rules
+that ship with {kib}.
 
 | `csp.script_src:`
 | Add sources for the https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/script-src[Content Security Policy `script-src` directive].
@@ -688,15 +689,6 @@ sources and images. When false, Vega can only get data from {es}. *Default: `fal
 `exploreDataInChart.enabled`
  | Enables you to view the underlying documents in a data series from a dashboard panel. *Default: `false`*
 
-| `xpack.license_management.enabled`
- | deprecated:[7.16.0,"In 8.0 and later, this setting will no longer be supported."]
-Set this value to false to disable the License Management UI.
-*Default: `true`*
-
-| `xpack.rollup.enabled:`
- | deprecated:[7.16.0,"In 8.0 and later, this setting will no longer be supported."]
-Set this value to false to disable the Rollup UI. *Default: true*
-
 | `i18n.locale` {ess-icon}
  | Set this value to change the {kib} interface language.
 Valid locales are: `en`, `zh-CN`, `ja-JP`. *Default: `en`*
@@ -706,14 +698,11 @@ Valid locales are: `en`, `zh-CN`, `ja-JP`. *Default: `en`*
 include::{kib-repo-dir}/settings/alert-action-settings.asciidoc[]
 include::{kib-repo-dir}/settings/apm-settings.asciidoc[]
 include::{kib-repo-dir}/settings/banners-settings.asciidoc[]
-include::{kib-repo-dir}/settings/dev-settings.asciidoc[]
-include::{kib-repo-dir}/settings/graph-settings.asciidoc[]
 include::{kib-repo-dir}/settings/fleet-settings.asciidoc[]
 include::{kib-repo-dir}/settings/i18n-settings.asciidoc[]
 include::{kib-repo-dir}/settings/logging-settings.asciidoc[]
 include::{kib-repo-dir}/settings/logs-ui-settings.asciidoc[]
 include::{kib-repo-dir}/settings/infrastructure-ui-settings.asciidoc[]
-include::{kib-repo-dir}/settings/ml-settings.asciidoc[]
 include::{kib-repo-dir}/settings/monitoring-settings.asciidoc[]
 include::{kib-repo-dir}/settings/reporting-settings.asciidoc[]
 include::secure-settings.asciidoc[]