[Lens] Remove default title, tweak text for consistency (#49394)

* [Lens] Remove default title, tweak text for consistency * Remove unused * Text update
elastic · Oct 29, 2019 · e3ec773 · e3ec773
1 parent 77792af
commit e3ec773
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 13 deletions.
diff --git a/...cy/core_plugins/kibana/public/discover/components/field_chooser/discover_field_search.tsx b/...cy/core_plugins/kibana/public/discover/components/field_chooser/discover_field_search.tsx
@@ -68,7 +68,7 @@ export function DiscoverFieldSearch({
         defaultMessage: 'Show field filter settings',
       });
   const searchPlaceholder = i18n.translate('kbn.discover.fieldChooser.searchPlaceHolder', {
-    defaultMessage: 'Search fields',
+    defaultMessage: 'Search field names',
   });
 
   return (
@@ -97,7 +97,7 @@ export function DiscoverFieldSearch({
       >
         <FormattedMessage
           id="kbn.discover.fieldChooser.fieldFilterFacetButtonLabel"
-          defaultMessage="Fields filtered"
+          defaultMessage="Filter by type"
         />
       </EuiFacetButton>
     </React.Fragment>

diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.test.tsx b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/editor_frame.test.tsx
@@ -1520,7 +1520,7 @@ describe('editor_frame', () => {
             query: { query: '', language: 'lucene' },
             filters: [],
           },
-          title: 'New visualization',
+          title: '',
           type: 'lens',
           visualizationType: 'testVis',
         },
@@ -1539,7 +1539,7 @@ describe('editor_frame', () => {
             query: { query: '', language: 'lucene' },
             filters: [],
           },
-          title: 'New visualization',
+          title: '',
           type: 'lens',
           visualizationType: 'testVis',
         },
@@ -1596,7 +1596,7 @@ describe('editor_frame', () => {
             query: { query: 'new query', language: 'lucene' },
             filters: [],
           },
-          title: 'New visualization',
+          title: '',
           type: 'lens',
           visualizationType: 'testVis',
         },

diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/state_management.ts b/x-pack/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/state_management.ts
@@ -4,7 +4,6 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { i18n } from '@kbn/i18n';
 import { EditorFrameProps } from '../editor_frame';
 import { Document } from '../../persistence/saved_object_store';
 
@@ -113,7 +112,7 @@ export const getInitialState = (props: EditorFrameProps): EditorFrameState => {
   }
 
   return {
-    title: i18n.translate('xpack.lens.chartTitle', { defaultMessage: 'New visualization' }),
+    title: '',
     datasourceStates,
     activeDatasourceId: getInitialDatasourceId(props),
     visualization: {

diff --git a/...k/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel_wrapper.tsx b/...k/legacy/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel_wrapper.tsx
@@ -15,9 +15,11 @@ interface Props {
 export function WorkspacePanelWrapper({ children, title }: Props) {
   return (
     <EuiPageContent className="lnsWorkspacePanelWrapper">
-      <EuiPageContentHeader className="lnsWorkspacePanelWrapper__pageContentHeader">
-        <span data-test-subj="lns_ChartTitle">{title}</span>
-      </EuiPageContentHeader>
+      {title && (
+        <EuiPageContentHeader className="lnsWorkspacePanelWrapper__pageContentHeader">
+          <span data-test-subj="lns_ChartTitle">{title}</span>
+        </EuiPageContentHeader>
+      )}
       <EuiPageContentBody className="lnsWorkspacePanelWrapper__pageContentBody">
         {children}
       </EuiPageContentBody>

diff --git a/x-pack/legacy/plugins/lens/public/indexpattern_plugin/datapanel.tsx b/x-pack/legacy/plugins/lens/public/indexpattern_plugin/datapanel.tsx
@@ -320,7 +320,7 @@ export const InnerIndexPatternDataPanel = function InnerIndexPatternDataPanel({
                 className="euiFieldText euiFieldText--fullWidth lnsInnerIndexPatternDataPanel__textField"
                 data-test-subj="lnsIndexPatternFieldSearch"
                 placeholder={i18n.translate('xpack.lens.indexPatterns.filterByNameLabel', {
-                  defaultMessage: 'Search for fields',
+                  defaultMessage: 'Search field names',
                   description:
                     'Search the list of fields in the index pattern for the provided text',
                 })}
@@ -339,7 +339,7 @@ export const InnerIndexPatternDataPanel = function InnerIndexPatternDataPanel({
               id="dataPanelTypeFilter"
               panelClassName="euiFilterGroup__popoverPanel"
               panelPaddingSize="none"
-              anchorPosition="downLeft"
+              anchorPosition="rightDown"
               display="block"
               isOpen={localState.isTypeFilterOpen}
               closePopover={() => setLocalState(() => ({ ...localState, isTypeFilterOpen: false }))}

diff --git a/x-pack/legacy/plugins/lens/public/register_vis_type_alias.ts b/x-pack/legacy/plugins/lens/public/register_vis_type_alias.ts
@@ -20,7 +20,7 @@ visualizations.types.registerAlias({
     }),
   },
   title: i18n.translate('xpack.lens.visTypeAlias.title', {
-    defaultMessage: 'Lens Visualizations',
+    defaultMessage: 'Lens',
   }),
   description: i18n.translate('xpack.lens.visTypeAlias.description', {
     defaultMessage: `Lens is a simpler way to create basic visualizations`,