Stabilize and re-enable custom url test suite

elastic · Nov 8, 2022 · e1734ed · e1734ed
1 parent 76ee973
commit e1734ed
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/x-pack/test/functional/apps/ml/anomaly_detection_jobs/custom_urls.ts b/x-pack/test/functional/apps/ml/anomaly_detection_jobs/custom_urls.ts
@@ -62,8 +62,7 @@ export default function ({ getService }: FtrProviderContext) {
   const ml = getService('ml');
   const browser = getService('browser');
 
-  // Failing: See https://github.com/elastic/kibana/issues/143933
-  describe.skip('custom urls', function () {
+  describe('custom urls', function () {
     this.tags(['ml']);
 
     let testDashboardId: string | null = null;

diff --git a/x-pack/test/functional/services/ml/custom_urls.ts b/x-pack/test/functional/services/ml/custom_urls.ts
@@ -170,12 +170,15 @@ export function MachineLearningCustomUrlsProvider({
 
     async assertDiscoverCustomUrlAction(expectedHitCountFormatted: string) {
       await PageObjects.discover.waitForDiscoverAppOnScreen();
+      await PageObjects.header.waitUntilLoadingHasFinished();
+
       // Make sure all existing popovers are closed
       await browser.pressKeys(browser.keys.ESCAPE);
 
       // During cloud tests, the small browser width might cause hit count to be invisible
       // so temporarily collapsing the sidebar ensures the count shows
       await PageObjects.discover.closeSidebar();
+
       await retry.tryForTime(10 * 1000, async () => {
         const hitCount = await PageObjects.discover.getHitCount();
         expect(hitCount).to.eql(