review comments

elastic · Nov 2, 2020 · df33fa2 · df33fa2
1 parent 2575403
commit df33fa2
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 12 deletions.
diff --git a/src/plugins/charts/common/palette.test.ts b/src/plugins/charts/common/palette.test.ts
@@ -99,9 +99,4 @@ describe('system_palette', () => {
     const result = fn(null, { name: 'test' });
     expect(result).toHaveProperty('name', 'test');
   });
-
-  it('passes params through', () => {
-    const result = fn(null, { name: 'test', params: { customProp: 123 } });
-    expect(result).toHaveProperty('params', { customProp: 123 });
-  });
 });
diff --git a/src/plugins/charts/common/palette.ts b/src/plugins/charts/common/palette.ts
@@ -33,7 +33,6 @@ export interface CustomPaletteState {
 
 export interface SystemPaletteArguments {
   name: string;
-  params?: unknown;
 }
 
 export interface PaletteOutput<T = unknown> {
@@ -158,17 +157,11 @@ export function systemPalette(): ExpressionFunctionDefinition<
           'gray',
         ],
       },
-      params: {
-        help: i18n.translate('charts.functions.systemPalette.args.paramsHelpText', {
-          defaultMessage: 'Palette specific params of the palette',
-        }),
-      },
     },
     fn: (input, args) => {
       return {
         type: 'palette',
         name: args.name,
-        params: args.params,
       };
     },
   };

diff --git a/x-pack/plugins/lens/public/shared_components/palette_picker.tsx b/x-pack/plugins/lens/public/shared_components/palette_picker.tsx
@@ -31,6 +31,7 @@ export function PalettePicker({
       <>
         <EuiColorPalettePicker
           data-test-subj="lns-palettePicker"
+          compressed
           palettes={palettes
             .getAll()
             .filter(({ internal }) => !internal)