[RAC] Fix scrolling on Obs alerts table (#109139) (#109894)

* Fix scrolling on obs alerts table and default to 50 items per page Co-authored-by: Kerry Gallagher <[email protected]>
elastic · Aug 24, 2021 · ddba1b4 · ddba1b4
1 parent 8244185
commit ddba1b4
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 7 deletions.
diff --git a/x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid.tsx b/x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid.tsx
@@ -325,7 +325,6 @@ export function AlertsTableTGrid(props: AlertsTableTGridProps) {
       end: rangeTo,
       filters: [],
       indexNames,
-      itemsPerPage: 10,
       itemsPerPageOptions: [10, 25, 50],
       loadingText: i18n.translate('xpack.observability.alertsTable.loadingTextLabel', {
         defaultMessage: 'loading alerts',

diff --git a/x-pack/plugins/timelines/public/components/t_grid/standalone/index.tsx b/x-pack/plugins/timelines/public/components/t_grid/standalone/index.tsx
@@ -70,7 +70,6 @@ const EventsContainerLoading = styled.div.attrs(({ className = '' }) => ({
 const FullWidthFlexGroup = styled(EuiFlexGroup)<{ $visible: boolean }>`
   overflow: hidden;
   margin: 0;
-  min-height: 490px;
   display: ${({ $visible }) => ($visible ? 'flex' : 'none')};
 `;
 
@@ -96,7 +95,6 @@ export interface TGridStandaloneProps {
   filterStatus: AlertStatus;
   height?: number;
   indexNames: string[];
-  itemsPerPage: number;
   itemsPerPageOptions: number[];
   query: Query;
   onRuleChange?: () => void;
@@ -127,7 +125,6 @@ const TGridStandaloneComponent: React.FC<TGridStandaloneProps> = ({
   footerText,
   filterStatus,
   indexNames,
-  itemsPerPage,
   itemsPerPageOptions,
   onRuleChange,
   query,
@@ -282,7 +279,7 @@ const TGridStandaloneComponent: React.FC<TGridStandaloneProps> = ({
           end,
         },
         indexNames,
-        itemsPerPage,
+        itemsPerPage: itemsPerPageStore,
         itemsPerPageOptions,
         showCheckboxes: true,
       })

diff --git a/x-pack/plugins/timelines/public/store/t_grid/defaults.ts b/x-pack/plugins/timelines/public/store/t_grid/defaults.ts
@@ -73,7 +73,7 @@ export const tGridDefaults: SubsetTGridModel = {
   indexNames: [],
   isLoading: false,
   isSelectAllChecked: false,
-  itemsPerPage: 25,
+  itemsPerPage: 50,
   itemsPerPageOptions: [10, 25, 50, 100],
   loadingEventIds: [],
   selectedEventIds: {},

diff --git a/...est/plugin_functional/plugins/timelines_test/public/applications/timelines_test/index.tsx b/...est/plugin_functional/plugins/timelines_test/public/applications/timelines_test/index.tsx
@@ -73,7 +73,6 @@ const AppRoot = React.memo(
                 end: '',
                 footerText: 'Events',
                 filters: [],
-                itemsPerPage: 50,
                 itemsPerPageOptions: [1, 2, 3],
                 loadingText: 'Loading events',
                 renderCellValue: () => <div data-test-subj="timeline-wrapper">test</div>,