Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow members of @security-solution-test-skippers to use
/skip
comm…
…ents on failed test issues (#173430) ## Summary After a PR is merged, CI runs all the tests on `main`. If one fails, a github issue with the label `failed-test` is created. If you comment `/skip` on the issue then a workflow action will skip the test directly on the failing branches. This workflow can only be used by contributors who have `admin` access to Kibana, OR to people who are on an allow-list of elastic teams. The list of teams allowed is `appex-qa`. This PR adds another team to the list: @elastic/security-solution-test-skippers This team was just created to allow a small list of Security Solution contributors the ability to use this workflow. Allowing a few of us access to this workflow will allow Security to triage our own test by writing `/skip` comments. ### Without this PR we have to: Without this PR we have to do a bunch of stuff to skip our own flaky tests: 1. Manually edit the files to create a PR on all affected branches. 2. Create PRs using the web app. 3. Get a second developer to approve the PR. 4. Wait for CI. 5. Merge the PR. This process is slow because of manual steps, and because CI must run before we can skip the test. At a minimum we should expect that process to take as long as CI takes (e.g. 90 minutes.) But the PRs that are meant to skip tests may also in turn be blocked by flaky tests. It also requires coordination from 2 people to make and approve the PR. ### Code references [skip-failed-test.yml](https://github.com/elastic/kibana/blob/main/.github/workflows/skip-failed-test.yml#L25-L30) is where the workflow is defined [Docs on the syntax for workflows.](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsuses) [permission-check/index.ts](https://github.com/elastic/kibana-github-actions/blob/main/permission-check/index.ts#L23-L26) is where the permission check is implemented. Users need to have: * either the right permission level * or be a member of the team ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Gloria Hornero <[email protected]>
- Loading branch information