UI fixes for Rules

elastic · Nov 4, 2021 · dd0758f · dd0758f
1 parent ebd0ed4
commit dd0758f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/x-pack/plugins/security_solution/cypress/integration/detection_rules/threshold_rule.spec.ts b/x-pack/plugins/security_solution/cypress/integration/detection_rules/threshold_rule.spec.ts
@@ -99,7 +99,7 @@ describe('Detection rules, threshold', () => {
     waitForAlertsIndexToBeCreated();
   });
 
-  it.skip('Creates and activates a new threshold rule', () => {
+  it('Creates and activates a new threshold rule', () => {
     goToManageAlertsDetectionRules();
     waitForRulesTableToBeLoaded();
     goToCreateNewRule();

diff --git a/...ck/plugins/security_solution/public/detections/containers/detection_engine/rules/types.ts b/...ck/plugins/security_solution/public/detections/containers/detection_engine/rules/types.ts
@@ -92,7 +92,7 @@ export const RuleSchema = t.intersection([
     enabled: t.boolean,
     false_positives: t.array(t.string),
     from: t.string,
-    id: t.string,
+    uuid: t.string,
     interval: t.string,
     immutable: t.boolean,
     name: t.string,

diff --git a/...y_solution/public/detections/containers/detection_engine/rules/use_rule_with_fallback.tsx b/...y_solution/public/detections/containers/detection_engine/rules/use_rule_with_fallback.tsx
@@ -28,8 +28,10 @@ interface AlertHit {
   _index: string;
   _source: {
     '@timestamp': string;
-    signal: {
-      rule: Rule;
+    kibana: {
+      alert: {
+        rule: Rule;
+      };
     };
   };
 }
@@ -77,7 +79,7 @@ export const useRuleWithFallback = (ruleId: string): UseRuleWithFallback => {
   }, [addError, error]);
 
   const rule = useMemo<Rule | undefined>(() => {
-    const result = isExistingRule ? ruleData : alertsData?.hits.hits[0]?._source.signal.rule;
+    const result = isExistingRule ? ruleData : alertsData?.hits.hits[0]?._source.kibana.alert.rule;
     if (result) {
       return transformInput(result);
     }