Skip to content

Commit

Permalink
[8.2] [Reporting] Fix copy issue in report notifications (#123607) (#…
Browse files Browse the repository at this point in the history
…131222)

* [Reporting] Fix copy issue in report notifications (#123607)

* refactor constants to better group report types separately

* format

* update comment

* split report type and job type constants into separate files

* added prettyReportTypeName getter to Job

* use pretty name if it exists, otherwise fallback to whatever is in jobtype

* slight restructure to existing copy to make it sound more natural

* added basic test for pretty names

* another update to existing copy, this time for the warning notification

* slight update to make test clearer

* fixed i18n strings for error notification and refactored success for consistency

* removed previous copy

* updated snapshots

* remove old i18n

* incorporoated copy feedback

* updated snapshots

(cherry picked from commit 8a8a12a)

# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json

* resolve merge conflicts

Co-authored-by: Kibana Machine <[email protected]>
  • Loading branch information
jloleysens and kibanamachine authored May 4, 2022
1 parent 6f90e0b commit d62b676
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit d62b676

Please sign in to comment.