Remove generics

elastic · Apr 22, 2024 · d54c6ec · d54c6ec
1 parent 02afccb
commit d54c6ec
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/x-pack/plugins/alerting/server/application/rule/methods/bulk_enable/bulk_enable_rules.ts b/x-pack/plugins/alerting/server/application/rule/methods/bulk_enable/bulk_enable_rules.ts
@@ -68,7 +68,7 @@ const getShouldScheduleTask = async (
   }
 };
 
-export const bulkEnableRules = async <Params extends RuleParams = never>(
+export const bulkEnableRules = async <Params extends RuleParams>(
   context: RulesClientContext,
   params: BulkEnableRulesParams
 ): Promise<BulkEnableRulesResult<Params>> => {

diff --git a/...ins/alerting/server/application/rule/methods/bulk_enable/types/bulk_enable_rules_types.ts b/...ins/alerting/server/application/rule/methods/bulk_enable/types/bulk_enable_rules_types.ts
@@ -23,7 +23,7 @@ export interface BulkEnableRulesError {
 }
 
 // TODO (http-versioning): This should be of type Rule, change this when all rule types are fixed
-export interface BulkEnableRulesResult<Params extends RuleParams = never> {
+export interface BulkEnableRulesResult<Params extends RuleParams> {
   rules: Array<SanitizedRule<Params>>;
   errors: BulkEnableRulesError[];
   total: number;

diff --git a/x-pack/plugins/alerting/server/routes/rule/apis/bulk_enable/bulk_enable_rules_route.ts b/x-pack/plugins/alerting/server/routes/rule/apis/bulk_enable/bulk_enable_rules_route.ts
@@ -38,7 +38,7 @@ export const bulkEnableRulesRoute = ({
 
           const body: BulkEnableRulesRequestBodyV1 = req.body;
           try {
-            const result = await rulesClient.bulkEnableRules<RuleParamsV1>({
+            const result = await rulesClient.bulkEnableRules({
               filter: body.filter,
               ids: body.ids,
             });

diff --git a/x-pack/plugins/alerting/server/rules_client/rules_client.ts b/x-pack/plugins/alerting/server/rules_client/rules_client.ts
@@ -154,8 +154,7 @@ export class RulesClient {
     bulkDeleteRules(this.context, options);
   public bulkEdit = <Params extends RuleTypeParams>(options: BulkEditOptions<Params>) =>
     bulkEditRules<Params>(this.context, options);
-  public bulkEnableRules = <Params extends RuleTypeParams = never>(params: BulkEnableRulesParams) =>
-    bulkEnableRules<Params>(this.context, params);
+  public bulkEnableRules = (params: BulkEnableRulesParams) => bulkEnableRules(this.context, params);
   public bulkDisableRules = (options: BulkDisableRulesRequestBody) =>
     bulkDisableRules(this.context, options);