Fix type errors

elastic · Dec 22, 2021 · d50c2e9 · d50c2e9
1 parent 282d3ac
commit d50c2e9
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/...terfall_with_summary/waterfall_container/Waterfall/waterfall_helpers/waterfall_helpers.ts b/...terfall_with_summary/waterfall_container/Waterfall/waterfall_helpers/waterfall_helpers.ts
@@ -267,7 +267,6 @@ const getWaterfallDuration = (waterfallItems: IWaterfallItem[]) =>
 
 const getWaterfallItems = (items: TraceAPIResponse['traceDocs']) =>
   items.map((item) => {
-    // @ts-expect-error 'processor' does not exist on type 'Profile'
     const docType: 'span' | 'transaction' = item.processor.event;
     switch (docType) {
       case 'span':

diff --git a/x-pack/plugins/apm/server/routes/traces/get_trace_items.ts b/x-pack/plugins/apm/server/routes/traces/get_trace_items.ts
@@ -66,7 +66,7 @@ export async function getTraceItems(
         { _score: { order: 'asc' as const } },
         { [TRANSACTION_DURATION]: { order: 'desc' as const } },
         { [SPAN_DURATION]: { order: 'desc' as const } },
-      ],
+      ] as Sort,
       track_total_hits: true,
     },
   });

diff --git a/x-pack/test/apm_api_integration/tests/traces/trace_by_id.spec.ts b/x-pack/test/apm_api_integration/tests/traces/trace_by_id.spec.ts
@@ -59,12 +59,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
       `);
       expectSnapshot(
         response.body.traceDocs.map((doc) =>
-          // @ts-expect-error Property 'processor' does not exist on type 'Profile'.
-          doc.processor.event === 'transaction'
-            ? // @ts-expect-error
-              `${doc.transaction.name} (transaction)`
-            : // @ts-expect-error
-              `${doc.span.name} (span)`
+          'span' in doc ? `${doc.span.name} (span)` : `${doc.transaction.name} (transaction)`
         )
       ).toMatchInline(`
         Array [