[Security Solution][Exceptions] - Update exceptions tab privileges ch…

…ecks (#122902) (#123305) ### Summary Addresses #122227. (cherry picked from commit fc64d17) Co-authored-by: Yara Tercero <[email protected]>
elastic · Jan 18, 2022 · d47fe31 · d47fe31
1 parent 8f656e9
commit d47fe31
Show file tree

Hide file tree

Showing 17 changed files with 196 additions and 82 deletions.
diff --git a/x-pack/plugins/lists/server/routes/read_privileges_route.mock.ts b/x-pack/plugins/lists/server/routes/read_privileges_route.mock.ts
@@ -88,7 +88,7 @@ export const getReadPrivilegeMock = (
       manage_index_templates: booleanValues,
       manage_ingest_pipelines: booleanValues,
       manage_ml: booleanValues,
-      manage_own_api_key: false,
+      manage_own_api_key: booleanValues,
       manage_pipeline: booleanValues,
       manage_rollup: booleanValues,
       manage_saml: booleanValues,
@@ -105,7 +105,7 @@ export const getReadPrivilegeMock = (
       read_ilm: booleanValues,
       transport_client: booleanValues,
     },
-    has_all_requested: false,
+    has_all_requested: booleanValues,
     index: {
       [listItemsIndex]: {
         all: booleanValues,
@@ -141,7 +141,7 @@ export const getReadPrivilegeMock = (
       manage_index_templates: booleanValues,
       manage_ingest_pipelines: booleanValues,
       manage_ml: booleanValues,
-      manage_own_api_key: false,
+      manage_own_api_key: booleanValues,
       manage_pipeline: booleanValues,
       manage_rollup: booleanValues,
       manage_saml: booleanValues,
@@ -158,7 +158,7 @@ export const getReadPrivilegeMock = (
       read_ilm: booleanValues,
       transport_client: booleanValues,
     },
-    has_all_requested: false,
+    has_all_requested: booleanValues,
     index: {
       [listIndex]: {
         all: booleanValues,

diff --git a/x-pack/plugins/security_solution/cypress/integration/detection_alerts/attach_to_case.spec.ts b/x-pack/plugins/security_solution/cypress/integration/detection_alerts/attach_to_case.spec.ts
@@ -20,7 +20,7 @@ import { login, loginAndWaitForPage, waitForPageWithoutDateRange } from '../../t
 import { refreshPage } from '../../tasks/security_header';
 
 import { ALERTS_URL } from '../../urls/navigation';
-import { ATTACH_ALERT_TO_CASE_BUTTON } from '../../screens/alerts';
+import { ATTACH_ALERT_TO_CASE_BUTTON, TIMELINE_CONTEXT_MENU_BTN } from '../../screens/alerts';
 
 const loadDetectionsPage = (role: ROLES) => {
   waitForPageWithoutDateRange(ALERTS_URL, role);
@@ -48,8 +48,8 @@ describe('Alerts timeline', () => {
     });
 
     it('should not allow user with read only privileges to attach alerts to cases', () => {
-      expandFirstAlertActions();
-      cy.get(ATTACH_ALERT_TO_CASE_BUTTON).should('not.exist');
+      // Disabled actions for read only users are hidden, so actions button should not show
+      cy.get(TIMELINE_CONTEXT_MENU_BTN).should('not.exist');
     });
   });
 

diff --git a/...tion/public/common/components/exceptions/viewer/exception_item/exception_entries.test.tsx b/...tion/public/common/components/exceptions/viewer/exception_item/exception_entries.test.tsx
@@ -23,7 +23,7 @@ describe('ExceptionEntries', () => {
     const wrapper = mount(
       <ThemeProvider theme={mockTheme}>
         <ExceptionEntries
-          disableDelete={false}
+          disableActions={false}
           entries={[getFormattedEntryMock()]}
           onDelete={jest.fn()}
           onEdit={jest.fn()}
@@ -38,7 +38,7 @@ describe('ExceptionEntries', () => {
     const wrapper = mount(
       <ThemeProvider theme={mockTheme}>
         <ExceptionEntries
-          disableDelete={false}
+          disableActions={false}
           entries={[getFormattedEntryMock(), getFormattedEntryMock()]}
           onDelete={jest.fn()}
           onEdit={jest.fn()}
@@ -54,7 +54,7 @@ describe('ExceptionEntries', () => {
     const wrapper = mount(
       <ThemeProvider theme={mockTheme}>
         <ExceptionEntries
-          disableDelete={false}
+          disableActions={false}
           entries={[getFormattedEntryMock()]}
           onDelete={jest.fn()}
           onEdit={mockOnEdit}
@@ -72,7 +72,7 @@ describe('ExceptionEntries', () => {
     const wrapper = mount(
       <ThemeProvider theme={mockTheme}>
         <ExceptionEntries
-          disableDelete={false}
+          disableActions={false}
           entries={[getFormattedEntryMock()]}
           onDelete={mockOnDelete}
           onEdit={jest.fn()}
@@ -85,37 +85,36 @@ describe('ExceptionEntries', () => {
     expect(mockOnDelete).toHaveBeenCalledTimes(1);
   });
 
-  test('it renders edit button disabled if "disableDelete" is "true"', () => {
+  test('it does not render edit button if "disableActions" is "true"', () => {
     const wrapper = mount(
       <ThemeProvider theme={mockTheme}>
         <ExceptionEntries
-          disableDelete={true}
+          disableActions={true}
           entries={[getFormattedEntryMock()]}
           onDelete={jest.fn()}
           onEdit={jest.fn()}
         />
       </ThemeProvider>
     );
-    const editBtn = wrapper.find('[data-test-subj="exceptionsViewerEditBtn"] button').at(0);
+    const editBtns = wrapper.find('[data-test-subj="exceptionsViewerEditBtn"] button');
 
-    expect(editBtn.prop('disabled')).toBeTruthy();
+    expect(editBtns).toHaveLength(0);
   });
 
-  test('it renders delete button in loading state if "disableDelete" is "true"', () => {
+  test('it does not render delete button if "disableActions" is "true"', () => {
     const wrapper = mount(
       <ThemeProvider theme={mockTheme}>
         <ExceptionEntries
-          disableDelete={true}
+          disableActions={true}
           entries={[getFormattedEntryMock()]}
           onDelete={jest.fn()}
           onEdit={jest.fn()}
         />
       </ThemeProvider>
     );
-    const deleteBtn = wrapper.find('[data-test-subj="exceptionsViewerDeleteBtn"] button').at(0);
+    const deleteBtns = wrapper.find('[data-test-subj="exceptionsViewerDeleteBtn"] button').at(0);
 
-    expect(deleteBtn.prop('disabled')).toBeTruthy();
-    expect(deleteBtn.find('.euiLoadingSpinner')).toBeTruthy();
+    expect(deleteBtns).toHaveLength(0);
   });
 
   test('it renders nested entry', () => {
@@ -126,7 +125,7 @@ describe('ExceptionEntries', () => {
     const wrapper = mount(
       <ThemeProvider theme={mockTheme}>
         <ExceptionEntries
-          disableDelete={false}
+          disableActions={false}
           entries={[parentEntry, getFormattedEntryMock(true)]}
           onDelete={jest.fn()}
           onEdit={jest.fn()}
@@ -168,7 +167,7 @@ describe('ExceptionEntries', () => {
     const wrapper = mount(
       <ThemeProvider theme={mockTheme}>
         <ExceptionEntries
-          disableDelete={false}
+          disableActions={false}
           entries={[getFormattedEntryMock()]}
           onDelete={jest.fn()}
           onEdit={jest.fn()}

diff --git a/..._solution/public/common/components/exceptions/viewer/exception_item/exception_entries.tsx b/..._solution/public/common/components/exceptions/viewer/exception_item/exception_entries.tsx
@@ -75,14 +75,14 @@ const ValueBadgeGroup = styled(EuiBadgeGroup)`
 
 interface ExceptionEntriesComponentProps {
   entries: FormattedEntry[];
-  disableDelete: boolean;
+  disableActions: boolean;
   onDelete: () => void;
   onEdit: () => void;
 }
 
 const ExceptionEntriesComponent = ({
   entries,
-  disableDelete,
+  disableActions,
   onDelete,
   onEdit,
 }: ExceptionEntriesComponentProps): JSX.Element => {
@@ -181,32 +181,32 @@ const ExceptionEntriesComponent = ({
             </EuiFlexItem>
           </EuiFlexGroup>
         </EuiFlexItem>
-        <EuiFlexItem grow={1}>
-          <EuiFlexGroup gutterSize="s" justifyContent="flexEnd">
-            <MyActionButton grow={false}>
-              <MyEditButton
-                size="s"
-                color="primary"
-                onClick={onEdit}
-                isDisabled={disableDelete}
-                data-test-subj="exceptionsViewerEditBtn"
-              >
-                {i18n.EDIT}
-              </MyEditButton>
-            </MyActionButton>
-            <MyActionButton grow={false}>
-              <MyRemoveButton
-                size="s"
-                color="danger"
-                onClick={onDelete}
-                isLoading={disableDelete}
-                data-test-subj="exceptionsViewerDeleteBtn"
-              >
-                {i18n.REMOVE}
-              </MyRemoveButton>
-            </MyActionButton>
-          </EuiFlexGroup>
-        </EuiFlexItem>
+        {!disableActions && (
+          <EuiFlexItem grow={1}>
+            <EuiFlexGroup gutterSize="s" justifyContent="flexEnd">
+              <MyActionButton grow={false}>
+                <MyEditButton
+                  size="s"
+                  color="primary"
+                  onClick={onEdit}
+                  data-test-subj="exceptionsViewerEditBtn"
+                >
+                  {i18n.EDIT}
+                </MyEditButton>
+              </MyActionButton>
+              <MyActionButton grow={false}>
+                <MyRemoveButton
+                  size="s"
+                  color="danger"
+                  onClick={onDelete}
+                  data-test-subj="exceptionsViewerDeleteBtn"
+                >
+                  {i18n.REMOVE}
+                </MyRemoveButton>
+              </MyActionButton>
+            </EuiFlexGroup>
+          </EuiFlexItem>
+        )}
       </EuiFlexGroup>
     </MyEntriesDetails>
   );

diff --git a/...rity_solution/public/common/components/exceptions/viewer/exception_item/index.stories.tsx b/...rity_solution/public/common/components/exceptions/viewer/exception_item/index.stories.tsx
@@ -35,6 +35,7 @@ storiesOf('Components/ExceptionItem', module)
 
     return (
       <ExceptionItem
+        disableActions={false}
         loadingItemIds={[]}
         commentsAccordionId={'accordion--comments'}
         exceptionItem={payload}
@@ -57,6 +58,7 @@ storiesOf('Components/ExceptionItem', module)
 
     return (
       <ExceptionItem
+        disableActions={false}
         loadingItemIds={[]}
         commentsAccordionId={'accordion--comments'}
         exceptionItem={payload}
@@ -80,6 +82,7 @@ storiesOf('Components/ExceptionItem', module)
 
     return (
       <ExceptionItem
+        disableActions={false}
         loadingItemIds={[]}
         commentsAccordionId={'accordion--comments'}
         exceptionItem={payload}
@@ -95,6 +98,7 @@ storiesOf('Components/ExceptionItem', module)
 
     return (
       <ExceptionItem
+        disableActions={false}
         loadingItemIds={[]}
         commentsAccordionId={'accordion--comments'}
         exceptionItem={payload}
@@ -108,6 +112,7 @@ storiesOf('Components/ExceptionItem', module)
     payload.comments = getCommentsArrayMock();
     return (
       <ExceptionItem
+        disableActions={false}
         loadingItemIds={[]}
         commentsAccordionId={'accordion--comments'}
         exceptionItem={payload}
@@ -122,11 +127,36 @@ storiesOf('Components/ExceptionItem', module)
 
     return (
       <ExceptionItem
+        disableActions={false}
         loadingItemIds={[{ id, namespaceType: namespace_type }]}
         commentsAccordionId={'accordion--comments'}
         exceptionItem={{ id, namespace_type, ...rest }}
         onDeleteException={action('onClick')}
         onEditException={action('onClick')}
       />
     );
+  })
+  .add('with actions disabled', () => {
+    const payload = getExceptionListItemSchemaMock();
+    payload.description = '';
+    payload.comments = getCommentsArrayMock();
+    payload.entries = [
+      {
+        field: 'actingProcess.file.signer',
+        type: 'match',
+        operator: 'included',
+        value: 'Elastic, N.V.',
+      },
+    ];
+
+    return (
+      <ExceptionItem
+        disableActions
+        loadingItemIds={[]}
+        commentsAccordionId={'accordion--comments'}
+        exceptionItem={payload}
+        onDeleteException={action('onClick')}
+        onEditException={action('onClick')}
+      />
+    );
   });
diff --git a/...ecurity_solution/public/common/components/exceptions/viewer/exception_item/index.test.tsx b/...ecurity_solution/public/common/components/exceptions/viewer/exception_item/index.test.tsx
@@ -32,6 +32,7 @@ describe('ExceptionItem', () => {
     const wrapper = mount(
       <ThemeProvider theme={mockTheme}>
         <ExceptionItem
+          disableActions={false}
           loadingItemIds={[]}
           commentsAccordionId={'accordion--comments'}
           onDeleteException={jest.fn()}
@@ -51,6 +52,7 @@ describe('ExceptionItem', () => {
     const wrapper = mount(
       <ThemeProvider theme={mockTheme}>
         <ExceptionItem
+          disableActions={false}
           loadingItemIds={[]}
           commentsAccordionId={'accordion--comments'}
           onDeleteException={jest.fn()}
@@ -70,13 +72,38 @@ describe('ExceptionItem', () => {
     );
   });
 
+  it('it does not render edit or delete action buttons when "disableActions" is "true"', () => {
+    const mockOnEditException = jest.fn();
+    const exceptionItem = getExceptionListItemSchemaMock();
+
+    const wrapper = mount(
+      <ThemeProvider theme={mockTheme}>
+        <ExceptionItem
+          disableActions
+          loadingItemIds={[]}
+          commentsAccordionId={'accordion--comments'}
+          onDeleteException={jest.fn()}
+          onEditException={mockOnEditException}
+          exceptionItem={exceptionItem}
+        />
+      </ThemeProvider>
+    );
+
+    const editBtn = wrapper.find('[data-test-subj="exceptionsViewerEditBtn"] button');
+    const deleteBtn = wrapper.find('[data-test-subj="exceptionsViewerDeleteBtn"] button');
+
+    expect(editBtn).toHaveLength(0);
+    expect(deleteBtn).toHaveLength(0);
+  });
+
   it('it invokes "onEditException" when edit button clicked', () => {
     const mockOnEditException = jest.fn();
     const exceptionItem = getExceptionListItemSchemaMock();
 
     const wrapper = mount(
       <ThemeProvider theme={mockTheme}>
         <ExceptionItem
+          disableActions={false}
           loadingItemIds={[]}
           commentsAccordionId={'accordion--comments'}
           onDeleteException={jest.fn()}
@@ -99,6 +126,7 @@ describe('ExceptionItem', () => {
     const wrapper = mount(
       <ThemeProvider theme={mockTheme}>
         <ExceptionItem
+          disableActions={false}
           loadingItemIds={[]}
           commentsAccordionId={'accordion--comments'}
           onDeleteException={mockOnDeleteException}
@@ -108,8 +136,8 @@ describe('ExceptionItem', () => {
       </ThemeProvider>
     );
 
-    const editBtn = wrapper.find('[data-test-subj="exceptionsViewerDeleteBtn"] button').at(0);
-    editBtn.simulate('click');
+    const deleteBtn = wrapper.find('[data-test-subj="exceptionsViewerDeleteBtn"] button').at(0);
+    deleteBtn.simulate('click');
 
     expect(mockOnDeleteException).toHaveBeenCalledWith({
       id: '1',
@@ -124,6 +152,7 @@ describe('ExceptionItem', () => {
     const wrapper = mount(
       <ThemeProvider theme={mockTheme}>
         <ExceptionItem
+          disableActions={false}
           loadingItemIds={[]}
           commentsAccordionId={'accordion--comments'}
           onDeleteException={mockOnDeleteException}
@@ -143,6 +172,7 @@ describe('ExceptionItem', () => {
     const wrapper = mount(
       <ThemeProvider theme={mockTheme}>
         <ExceptionItem
+          disableActions={false}
           loadingItemIds={[]}
           commentsAccordionId={'accordion--comments'}
           onDeleteException={mockOnDeleteException}