Small improvement

elastic · Sep 14, 2023 · d0519f9 · d0519f9
1 parent 1f72855
commit d0519f9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/x-pack/plugins/infra/public/common/visualizations/lens/dashboards/asset_details/index.ts b/x-pack/plugins/infra/public/common/visualizations/lens/dashboards/asset_details/index.ts
@@ -13,6 +13,15 @@ import { kubernetesCharts } from './host/kubernetes_charts';
 export { type KPIChartProps };
 export const assetDetailsDashboards = {
   host: { hostMetricFlyoutCharts, hostMetricChartsFullPage, hostKPICharts, keyField: 'host.name' },
-  nginx: { nginxStubstatusCharts, nginxAccessCharts, keyField: 'host.name' },
-  kubernetes: { kubernetesCharts, keyField: 'kubernetes.node.name' },
+  nginx: {
+    nginxStubstatusCharts,
+    nginxAccessCharts,
+    keyField: 'host.name',
+    dependsOn: ['nginx.stubstatus', 'nginx.access'],
+  },
+  kubernetes: {
+    kubernetesCharts,
+    keyField: 'kubernetes.node.name',
+    dependsOn: ['kubernetes.node'],
+  },
 };
diff --git a/x-pack/plugins/infra/public/components/asset_details/tabs/overview/metrics/metrics_grid.tsx b/x-pack/plugins/infra/public/components/asset_details/tabs/overview/metrics/metrics_grid.tsx
@@ -41,7 +41,7 @@ export const MetricsGrid = React.memo(
             data-test-subj="infraAssetDetailsMetricsChart"
           />
         </Section>
-        <Section dependsOn={['kubernetes.node']} title={KubernetesMetricsSectionTitle}>
+        <Section dependsOn={kubernetes.dependsOn} title={KubernetesMetricsSectionTitle}>
           <ChartGrid
             assetName={assetName}
             timeRange={timeRange}
@@ -52,11 +52,11 @@ export const MetricsGrid = React.memo(
             data-test-subj="infraAssetDetailsNginxMetricsChart"
           />
         </Section>
-        <Section dependsOn={['nginx.stubstatus', 'nginx.access']} title={NginxMetricsSectionTitle}>
+        <Section dependsOn={nginx.dependsOn} title={NginxMetricsSectionTitle}>
           <ChartGrid
             assetName={assetName}
             timeRange={timeRange}
-            filterFieldName={host.keyField}
+            filterFieldName={nginx.keyField}
             charts={[
               ...nginx.nginxStubstatusCharts.map((chart) => ({
                 ...chart,