Skip to content

Commit

Permalink
Removes unused exported constants
Browse files Browse the repository at this point in the history
  • Loading branch information
TinaHeiligers committed Nov 3, 2022
1 parent 3274c9b commit d0213c3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
8 changes: 1 addition & 7 deletions packages/core/apps/core-apps-server-internal/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,11 @@
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/
import Path from 'path';

export { CoreAppsService } from './src';
export type {
InternalCoreAppsServiceRequestHandlerContext,
InternalCoreAppsServiceRouter,
} from './src';
// only used by integration tests
export { FileHashCache, registerRouteForBundle } from './src';
// After the package is built and bootstrap extracts files to bazel-bin, node modules structure exposes assets outside of the src folder
// These constants reference locations in the hierarchy after the build is done
export const ASSETS_DIR = Path.resolve(__dirname, '../assets');
export const FAVICONS_DIR = `${ASSETS_DIR}/favicons`;
export const THEMES_DIR = `${ASSETS_DIR}`;
export const FONTS_DIR = `${ASSETS_DIR}/fonts`;
2 changes: 2 additions & 0 deletions packages/core/apps/core-apps-server-internal/src/core_app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,8 @@ export class CoreAppsService {
});
}

// After the package is built and bootstrap extracts files to bazel-bin,
// assets are exposed at the root of the package and in the package's node_modules dir
private registerStaticDirs(core: InternalCoreSetup | InternalCorePreboot) {
core.http.registerStaticDir(
'/ui/{path*}',
Expand Down

0 comments on commit d0213c3

Please sign in to comment.