Incorporate PR feedback

elastic · Feb 3, 2020 · cfd819c · cfd819c
1 parent 536662b
commit cfd819c
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/.../plugins/uptime/server/lib/adapters/monitor_states/search/__tests__/query_context.test.ts b/.../plugins/uptime/server/lib/adapters/monitor_states/search/__tests__/query_context.test.ts
@@ -19,10 +19,7 @@ describe(QueryContext, () => {
   };
 
   let qc: QueryContext;
-  const makeQueryContext = () => {
-    return new QueryContext({}, rangeStart, rangeEnd, pagination, null, 10);
-  };
-  beforeEach(() => (qc = makeQueryContext()));
+  beforeEach(() => (qc = new QueryContext({}, rangeStart, rangeEnd, pagination, null, 10)));
 
   describe('dateRangeFilter()', () => {
     const expectedRange = {
@@ -36,7 +33,7 @@ describe(QueryContext, () => {
     describe('when hasTimespan() is true', () => {
       it('should create a date range filter including the timespan', async () => {
         const mockHasTimespan = jest.fn();
-        mockHasTimespan.mockReturnValue(Promise.resolve(true));
+        mockHasTimespan.mockReturnValue(true);
         qc.hasTimespan = mockHasTimespan;
 
         expect(await qc.dateRangeFilter()).toEqual({
@@ -60,7 +57,7 @@ describe(QueryContext, () => {
     describe('when hasTimespan() is false', () => {
       it('should only use the timestamp fields in the returned filter', async () => {
         const mockHasTimespan = jest.fn();
-        mockHasTimespan.mockReturnValue(Promise.resolve(false));
+        mockHasTimespan.mockReturnValue(false);
         qc.hasTimespan = mockHasTimespan;
 
         expect(await qc.dateRangeFilter()).toEqual(expectedRange);