[New platform] Introduce start phase for core services on server (#35297

) (#35791)

* introduce start phase. setup is bloated with start functionality

* fix amp typings: server is part of start contract now

* update mock files

* root.start(): necessary to run test server

* expose  setup&start server api to simplify testing

* move tests to the new API

* test servers also should call root.start()

* update docs

* update snapshots: this functionality is tested in http server

* split setup/start phases

* update docs

* expose http server if it not started

to get rid of Optional<HttpServer> type and make it Require<HttpServer>

* adopt test to exposed Http server via SetupContract

* udpate docs

* cleanup apm changees

* check legacy service setup before start

* check http server setup before start

* restrict server options mutation; unify Promise interface for setup

* introduce start pahse for plugins service for parity with client side

* Revert "introduce start pahse for plugins service for parity with client side"

This reverts commit c04fdd2.

docs/development/core/server/kibana-plugin-server.authenticationhandler.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [AuthenticationHandler](./kibana-plugin-server.authenticationhandler.md)
 
 ## AuthenticationHandler type

docs/development/core/server/kibana-plugin-server.authtoolkit.authenticated.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [AuthToolkit](./kibana-plugin-server.authtoolkit.md) &gt; [authenticated](./kibana-plugin-server.authtoolkit.authenticated.md)
 
 ## AuthToolkit.authenticated property

docs/development/core/server/kibana-plugin-server.authtoolkit.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [AuthToolkit](./kibana-plugin-server.authtoolkit.md)
 
 ## AuthToolkit interface

docs/development/core/server/kibana-plugin-server.authtoolkit.redirected.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [AuthToolkit](./kibana-plugin-server.authtoolkit.md) &gt; [redirected](./kibana-plugin-server.authtoolkit.redirected.md)
 
 ## AuthToolkit.redirected property

docs/development/core/server/kibana-plugin-server.authtoolkit.rejected.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [AuthToolkit](./kibana-plugin-server.authtoolkit.md) &gt; [rejected](./kibana-plugin-server.authtoolkit.rejected.md)
 
 ## AuthToolkit.rejected property

docs/development/core/server/kibana-plugin-server.corestart.http.md

@@ -0,0 +1,11 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [CoreStart](./kibana-plugin-server.corestart.md) &gt; [http](./kibana-plugin-server.corestart.http.md)
+
+## CoreStart.http property
+
+<b>Signature:</b>
+
+```typescript
+http: HttpServiceStart;
+```

docs/development/core/server/kibana-plugin-server.corestart.md

@@ -0,0 +1,18 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [CoreStart](./kibana-plugin-server.corestart.md)
+
+## CoreStart interface
+
+<b>Signature:</b>
+
+```typescript
+export interface CoreStart 
+```
+
+## Properties
+
+|  Property | Type | Description |
+|  --- | --- | --- |
+|  [http](./kibana-plugin-server.corestart.http.md) | <code>HttpServiceStart</code> |  |
+

docs/development/core/server/kibana-plugin-server.httpservicesetup.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [HttpServiceSetup](./kibana-plugin-server.httpservicesetup.md)
 
 ## HttpServiceSetup type
@@ -6,5 +8,5 @@
 <b>Signature:</b>
 
 ```typescript
-export declare type HttpServiceSetup = HttpServerInfo;
+export declare type HttpServiceSetup = HttpServerSetup;
 ```

docs/development/core/server/kibana-plugin-server.httpservicestart.islistening.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [HttpServiceStart](./kibana-plugin-server.httpservicestart.md) &gt; [isListening](./kibana-plugin-server.httpservicestart.islistening.md)
+
+## HttpServiceStart.isListening property
+
+Indicates if http server is listening on a port
+
+<b>Signature:</b>
+
+```typescript
+isListening: () => boolean;
+```

docs/development/core/server/kibana-plugin-server.httpservicestart.md

@@ -0,0 +1,19 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [HttpServiceStart](./kibana-plugin-server.httpservicestart.md)
+
+## HttpServiceStart interface
+
+
+<b>Signature:</b>
+
+```typescript
+export interface HttpServiceStart 
+```
+
+## Properties
+
+|  Property | Type | Description |
+|  --- | --- | --- |
+|  [isListening](./kibana-plugin-server.httpservicestart.islistening.md) | <code>() =&gt; boolean</code> | Indicates if http server is listening on a port |
+

docs/development/core/server/kibana-plugin-server.kibanarequest.body.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [KibanaRequest](./kibana-plugin-server.kibanarequest.md) &gt; [body](./kibana-plugin-server.kibanarequest.body.md)
 
 ## KibanaRequest.body property

docs/development/core/server/kibana-plugin-server.kibanarequest.from.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [KibanaRequest](./kibana-plugin-server.kibanarequest.md) &gt; [from](./kibana-plugin-server.kibanarequest.from.md)
 
 ## KibanaRequest.from() method

docs/development/core/server/kibana-plugin-server.kibanarequest.getfilteredheaders.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [KibanaRequest](./kibana-plugin-server.kibanarequest.md) &gt; [getFilteredHeaders](./kibana-plugin-server.kibanarequest.getfilteredheaders.md)
 
 ## KibanaRequest.getFilteredHeaders() method

docs/development/core/server/kibana-plugin-server.kibanarequest.headers.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [KibanaRequest](./kibana-plugin-server.kibanarequest.md) &gt; [headers](./kibana-plugin-server.kibanarequest.headers.md)
 
 ## KibanaRequest.headers property

docs/development/core/server/kibana-plugin-server.kibanarequest.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [KibanaRequest](./kibana-plugin-server.kibanarequest.md)
 
 ## KibanaRequest class

docs/development/core/server/kibana-plugin-server.kibanarequest.params.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [KibanaRequest](./kibana-plugin-server.kibanarequest.md) &gt; [params](./kibana-plugin-server.kibanarequest.params.md)
 
 ## KibanaRequest.params property

docs/development/core/server/kibana-plugin-server.kibanarequest.path.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [KibanaRequest](./kibana-plugin-server.kibanarequest.md) &gt; [path](./kibana-plugin-server.kibanarequest.path.md)
 
 ## KibanaRequest.path property

docs/development/core/server/kibana-plugin-server.kibanarequest.query.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [KibanaRequest](./kibana-plugin-server.kibanarequest.md) &gt; [query](./kibana-plugin-server.kibanarequest.query.md)
 
 ## KibanaRequest.query property

docs/development/core/server/kibana-plugin-server.md

@@ -21,7 +21,9 @@
 |  [AuthToolkit](./kibana-plugin-server.authtoolkit.md) | A tool set defining an outcome of Auth interceptor for incoming request. |
 |  [CallAPIOptions](./kibana-plugin-server.callapioptions.md) | The set of options that defines how API call should be made and result be processed. |
 |  [CoreSetup](./kibana-plugin-server.coresetup.md) |  |
+|  [CoreStart](./kibana-plugin-server.corestart.md) |  |
 |  [ElasticsearchServiceSetup](./kibana-plugin-server.elasticsearchservicesetup.md) |  |
+|  [HttpServiceStart](./kibana-plugin-server.httpservicestart.md) |  |
 |  [Logger](./kibana-plugin-server.logger.md) | Logger exposes all the necessary methods to log any type of information and this is the interface used by the logging consumers including plugins. |
 |  [LoggerFactory](./kibana-plugin-server.loggerfactory.md) | The single purpose of <code>LoggerFactory</code> interface is to define a way to retrieve a context-based logger instance. |
 |  [LogMeta](./kibana-plugin-server.logmeta.md) | Contextual metadata |

docs/development/core/server/kibana-plugin-server.onrequesthandler.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [OnRequestHandler](./kibana-plugin-server.onrequesthandler.md)
 
 ## OnRequestHandler type

docs/development/core/server/kibana-plugin-server.onrequesttoolkit.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [OnRequestToolkit](./kibana-plugin-server.onrequesttoolkit.md)
 
 ## OnRequestToolkit interface

docs/development/core/server/kibana-plugin-server.onrequesttoolkit.next.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [OnRequestToolkit](./kibana-plugin-server.onrequesttoolkit.md) &gt; [next](./kibana-plugin-server.onrequesttoolkit.next.md)
 
 ## OnRequestToolkit.next property

docs/development/core/server/kibana-plugin-server.onrequesttoolkit.redirected.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [OnRequestToolkit](./kibana-plugin-server.onrequesttoolkit.md) &gt; [redirected](./kibana-plugin-server.onrequesttoolkit.redirected.md)
 
 ## OnRequestToolkit.redirected property

docs/development/core/server/kibana-plugin-server.onrequesttoolkit.rejected.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [OnRequestToolkit](./kibana-plugin-server.onrequesttoolkit.md) &gt; [rejected](./kibana-plugin-server.onrequesttoolkit.rejected.md)
 
 ## OnRequestToolkit.rejected property

docs/development/core/server/kibana-plugin-server.pluginsetupcontext.http.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [PluginSetupContext](./kibana-plugin-server.pluginsetupcontext.md) &gt; [http](./kibana-plugin-server.pluginsetupcontext.http.md)
 
 ## PluginSetupContext.http property

docs/development/core/server/kibana-plugin-server.router.delete.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [Router](./kibana-plugin-server.router.md) &gt; [delete](./kibana-plugin-server.router.delete.md)
 
 ## Router.delete() method

docs/development/core/server/kibana-plugin-server.router.get.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [Router](./kibana-plugin-server.router.md) &gt; [get](./kibana-plugin-server.router.get.md)
 
 ## Router.get() method

docs/development/core/server/kibana-plugin-server.router.getroutes.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [Router](./kibana-plugin-server.router.md) &gt; [getRoutes](./kibana-plugin-server.router.getroutes.md)
 
 ## Router.getRoutes() method

docs/development/core/server/kibana-plugin-server.router.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [Router](./kibana-plugin-server.router.md)
 
 ## Router class

docs/development/core/server/kibana-plugin-server.router.path.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [Router](./kibana-plugin-server.router.md) &gt; [path](./kibana-plugin-server.router.path.md)
 
 ## Router.path property

docs/development/core/server/kibana-plugin-server.router.post.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [Router](./kibana-plugin-server.router.md) &gt; [post](./kibana-plugin-server.router.post.md)
 
 ## Router.post() method

docs/development/core/server/kibana-plugin-server.router.put.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [Router](./kibana-plugin-server.router.md) &gt; [put](./kibana-plugin-server.router.put.md)
 
 ## Router.put() method

docs/development/core/server/kibana-plugin-server.router.routes.md

@@ -1,3 +1,5 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
 [Home](./index) &gt; [kibana-plugin-server](./kibana-plugin-server.md) &gt; [Router](./kibana-plugin-server.router.md) &gt; [routes](./kibana-plugin-server.router.routes.md)
 
 ## Router.routes property

src/core/public/plugins/plugins_service.ts

@@ -37,14 +37,17 @@ export type PluginsServiceStartDeps = CoreStart;
 export interface PluginsServiceSetup {
   contracts: Map<string, unknown>;
 }
+export interface PluginsServiceStart {
+  contracts: Map<string, unknown>;
+}
 
 /**
  * Service responsible for loading plugin bundles, initializing plugins, and managing the lifecycle
  * of all plugins.
  *
  * @internal
  */
-export class PluginsService implements CoreService<PluginsServiceSetup> {
+export class PluginsService implements CoreService<PluginsServiceSetup, PluginsServiceStart> {
   /** Plugin wrappers in topological order. */
   private readonly plugins: Map<
     PluginName,

src/core/server/bootstrap.ts

@@ -84,6 +84,7 @@ export async function bootstrap({
 
   try {
     await root.setup();
+    await root.start();
   } catch (err) {
     await shutdown(err);
   }

src/core/server/elasticsearch/elasticsearch_service.mock.ts

@@ -39,6 +39,7 @@ type ElasticsearchServiceContract = PublicMethodsOf<ElasticsearchService>;
 const createMock = () => {
   const mocked: jest.Mocked<ElasticsearchServiceContract> = {
     setup: jest.fn(),
+    start: jest.fn(),
     stop: jest.fn(),
   };
   mocked.setup.mockResolvedValue(createSetupContractMock());

src/core/server/elasticsearch/elasticsearch_service.ts

@@ -106,6 +106,8 @@ export class ElasticsearchService implements CoreService<ElasticsearchServiceSet
     };
   }
 
+  public async start() {}
+
   public async stop() {
     this.log.debug('Stopping elasticsearch service');
 

src/core/server/http/http_config.ts

@@ -83,7 +83,7 @@ const createHttpSchema = schema.object(
   }
 );
 
-type HttpConfigType = TypeOf<typeof createHttpSchema>;
+export type HttpConfigType = TypeOf<typeof createHttpSchema>;
 
 export class HttpConfig {
   /**