[Lens] Fix regression in field list for beats (thousands of fields) (#…

…55625) * [Lens] Fix regression in field list for beats * Add api test
elastic · Jan 23, 2020 · cda6b13 · cda6b13
1 parent d97526e
commit cda6b13
Show file tree

Hide file tree

Showing 3 changed files with 174 additions and 4 deletions.
diff --git a/x-pack/legacy/plugins/lens/server/routes/existing_fields.ts b/x-pack/legacy/plugins/lens/server/routes/existing_fields.ts
@@ -226,17 +226,15 @@ async function fetchIndexPatternStats({
       match_all: {},
     };
   }
-  const viableFields = fields.filter(
-    f => !f.isScript && !f.isAlias && !metaFields.includes(f.name)
-  );
   const scriptedFields = fields.filter(f => f.isScript);
 
   const result = await client.callAsCurrentUser('search', {
     index,
     body: {
       size: SAMPLE_SIZE,
-      _source: viableFields.map(f => f.name),
       query,
+      // _source is required because we are also providing script fields.
+      _source: '*',
       script_fields: scriptedFields.reduce((acc, field) => {
         acc[field.name] = {
           script: {

diff --git a/x-pack/test/api_integration/apis/lens/existing_fields.ts b/x-pack/test/api_integration/apis/lens/existing_fields.ts
@@ -94,6 +94,41 @@ const fieldsWithData = [
   'relatedContent.url.raw',
 ];
 
+const metricBeatData = [
+  '@timestamp',
+  'agent.ephemeral_id',
+  'agent.hostname',
+  'agent.id',
+  'agent.type',
+  'agent.version',
+  'ecs.version',
+  'event.dataset',
+  'event.duration',
+  'event.module',
+  'host.architecture',
+  'host.hostname',
+  'host.id',
+  'host.name',
+  'host.os.build',
+  'host.os.family',
+  'host.os.kernel',
+  'host.os.name',
+  'host.os.platform',
+  'host.os.version',
+  'metricset.name',
+  'service.type',
+  'system.cpu.cores',
+  'system.cpu.idle.pct',
+  'system.cpu.iowait.pct',
+  'system.cpu.irq.pct',
+  'system.cpu.nice.pct',
+  'system.cpu.softirq.pct',
+  'system.cpu.steal.pct',
+  'system.cpu.system.pct',
+  'system.cpu.total.pct',
+  'system.cpu.user.pct',
+];
+
 // eslint-disable-next-line import/no-default-export
 export default ({ getService }: FtrProviderContext) => {
   const esArchiver = getService('esArchiver');
@@ -124,6 +159,20 @@ export default ({ getService }: FtrProviderContext) => {
         expect(body.existingFieldNames.sort()).to.eql(fieldsWithData.sort());
       });
 
+      it('should succeed for thousands of fields', async () => {
+        const { body } = await supertest
+          .get(
+            `/api/lens/existing_fields/${encodeURIComponent(
+              'metricbeat-*'
+            )}?fromDate=${TEST_START_TIME}&toDate=${TEST_END_TIME}`
+          )
+          .set(COMMON_HEADERS)
+          .expect(200);
+
+        expect(body.indexPatternTitle).to.eql('metricbeat-*');
+        expect(body.existingFieldNames.sort()).to.eql(metricBeatData.sort());
+      });
+
       it('should throw a 404 for a non-existent index', async () => {
         await supertest
           .get(