♻️ Refactor to reuse shared function

elastic · Nov 12, 2020 · c4cc2bf · c4cc2bf
1 parent 2dae5e8
commit c4cc2bf
Showing 1 changed file with 9 additions and 17 deletions.
diff --git a/...ins/lens/public/indexpattern_datasource/operations/definitions/filters/filter_popover.tsx b/...ins/lens/public/indexpattern_datasource/operations/definitions/filters/filter_popover.tsx
@@ -32,9 +32,13 @@ export const FilterPopover = ({
   const [isPopoverOpen, setIsPopoverOpen] = useState(false);
   const inputRef = React.useRef<HTMLInputElement>();
 
-  const setPopoverOpen = (isOpen: boolean) => {
-    setIsPopoverOpen(isOpen);
-    setIsOpenByCreation(isOpen);
+  const closePopover = () => {
+    if (isOpenByCreation) {
+      setIsOpenByCreation(false);
+    }
+    if (isPopoverOpen) {
+      setIsPopoverOpen(false);
+    }
   };
 
   const setFilterLabel = (label: string) => setFilter({ ...filter, label });
@@ -57,14 +61,7 @@ export const FilterPopover = ({
       panelClassName="lnsIndexPatternDimensionEditor__filtersEditor"
       isOpen={isOpenByCreation || isPopoverOpen}
       ownFocus
-      closePopover={() => {
-        if (isOpenByCreation) {
-          setIsOpenByCreation(false);
-        }
-        if (isPopoverOpen) {
-          setIsPopoverOpen(false);
-        }
-      }}
+      closePopover={() => closePopover()}
       button={
         <Button
           onClick={() => {
@@ -91,12 +88,7 @@ export const FilterPopover = ({
         onChange={setFilterLabel}
         placeholder={getPlaceholder(filter.input.query)}
         inputRef={inputRef}
-        onSubmit={() => {
-          if (isOpenByCreation) {
-            setIsOpenByCreation(false);
-          }
-          setIsPopoverOpen(false);
-        }}
+        onSubmit={() => closePopover()}
         dataTestSubj="indexPattern-filters-label"
       />
     </EuiPopover>