-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.14] [ML] AIOps: Fix to not run log rate analysis twice when no spi…
…ke/dip detected. (#180980) (#181128) # Backport This will backport the following commits from `main` to `8.14`: - [[ML] AIOps: Fix to not run log rate analysis twice when no spike/dip detected. (#180980)](#180980) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-18T09:35:16Z","message":"[ML] AIOps: Fix to not run log rate analysis twice when no spike/dip detected. (#180980)\n\n## Summary\r\n\r\nPart of #172981.\r\n\r\nThis fixes to not run log rate analysis twice when no spike/dip detected\r\nand a user needs to adapt the initial selection. When a user clicks in\r\nan area of the histogram chart that's not a highlighted change point,\r\nthe click will just trigger the baseline/deviation time range selection,\r\nbut it will not automatically run the analysis. Instead, an updated\r\nprompt is shown below the chart that explains that the\r\nbaseline/deviation can be adjusted via dragging and the analysis can be\r\nrun via the button below that description.\r\n\r\nInitial view after loading the page:\r\n\r\n<img width=\"1040\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/230104/90e8c390-af2a-45e2-8d11-cfd42285200b\">\r\n\r\nUser clicked in an area that's not covered by the highlighted change\r\npoint:\r\n\r\n<img width=\"1026\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/230104/050a07e0-c5e6-4639-a854-83fae10b125b\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6fdcd8d7b80515ce9361666f5264f8966d9b54e7","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:ML/AIOps","v8.14.0","v8.15.0"],"title":"[ML] AIOps: Fix to not run log rate analysis twice when no spike/dip detected.","number":180980,"url":"https://github.com/elastic/kibana/pull/180980","mergeCommit":{"message":"[ML] AIOps: Fix to not run log rate analysis twice when no spike/dip detected. (#180980)\n\n## Summary\r\n\r\nPart of #172981.\r\n\r\nThis fixes to not run log rate analysis twice when no spike/dip detected\r\nand a user needs to adapt the initial selection. When a user clicks in\r\nan area of the histogram chart that's not a highlighted change point,\r\nthe click will just trigger the baseline/deviation time range selection,\r\nbut it will not automatically run the analysis. Instead, an updated\r\nprompt is shown below the chart that explains that the\r\nbaseline/deviation can be adjusted via dragging and the analysis can be\r\nrun via the button below that description.\r\n\r\nInitial view after loading the page:\r\n\r\n<img width=\"1040\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/230104/90e8c390-af2a-45e2-8d11-cfd42285200b\">\r\n\r\nUser clicked in an area that's not covered by the highlighted change\r\npoint:\r\n\r\n<img width=\"1026\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/230104/050a07e0-c5e6-4639-a854-83fae10b125b\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6fdcd8d7b80515ce9361666f5264f8966d9b54e7"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/180980","number":180980,"mergeCommit":{"message":"[ML] AIOps: Fix to not run log rate analysis twice when no spike/dip detected. (#180980)\n\n## Summary\r\n\r\nPart of #172981.\r\n\r\nThis fixes to not run log rate analysis twice when no spike/dip detected\r\nand a user needs to adapt the initial selection. When a user clicks in\r\nan area of the histogram chart that's not a highlighted change point,\r\nthe click will just trigger the baseline/deviation time range selection,\r\nbut it will not automatically run the analysis. Instead, an updated\r\nprompt is shown below the chart that explains that the\r\nbaseline/deviation can be adjusted via dragging and the analysis can be\r\nrun via the button below that description.\r\n\r\nInitial view after loading the page:\r\n\r\n<img width=\"1040\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/230104/90e8c390-af2a-45e2-8d11-cfd42285200b\">\r\n\r\nUser clicked in an area that's not covered by the highlighted change\r\npoint:\r\n\r\n<img width=\"1026\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/230104/050a07e0-c5e6-4639-a854-83fae10b125b\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6fdcd8d7b80515ce9361666f5264f8966d9b54e7"}}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <[email protected]>
- Loading branch information
1 parent
dda3856
commit c1513cd
Showing
34 changed files
with
312 additions
and
81 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
x-pack/packages/ml/aiops_components/src/log_rate_analysis_state_provider/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
export { | ||
useLogRateAnalysisStateContext, | ||
LogRateAnalysisStateProvider, | ||
} from './log_rate_analysis_state_provider'; | ||
export type { GroupTableItem, GroupTableItemGroup, TableItemAction } from './types'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.