Skip to content

Commit

Permalink
[Security Solution] Unskip perform bulk action ESS FTR tests (#197660)
Browse files Browse the repository at this point in the history
**Closes: #196470
**Closes: #196462

## Summary

This PR unskips `perform_bulk_action_ess.ts` functional test.

## Details

`perform_bulk_action_ess.ts` includes a number of functional tests where some of them were flaky. Investigation revealed that creating enabled rules and performing bulk actions may lead to race conditions. Under that conditions rule's SO isn't updated as expected. For example legacy rule actions aren't persisted in rule's SO when it's expected by the test.

This PR includes `perform_bulk_action_ess.ts` refactoring to create disabled rules in the majority of tests. Enabled rules are created only in tests checking behavior upon rules disabling. These tests were checked multiple times and didn't demonstrate flakiness.

Additionally `@kbn/expect` was replaced with `expect` to make asserting more transparent and avoid unclear error messages. 

## Flaky test results

[100 runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7274) 🟢
  • Loading branch information
maximpn authored Nov 5, 2024
1 parent b122722 commit bf37a01
Show file tree
Hide file tree
Showing 2 changed files with 298 additions and 156 deletions.
Loading

0 comments on commit bf37a01

Please sign in to comment.