fix eslint errors

elastic · Mar 5, 2020 · bd866a9 · bd866a9
1 parent dc83371
commit bd866a9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 13 deletions.
diff --git a/x-pack/legacy/plugins/maps/common/constants.ts b/x-pack/legacy/plugins/maps/common/constants.ts
@@ -58,7 +58,7 @@ export const EMS_XYZ = 'EMS_XYZ'; // identifies a custom TMS source. Name is a l
 export enum FIELD_ORIGIN {
   SOURCE = 'source',
   JOIN = 'join',
-};
+}
 
 export const SOURCE_DATA_ID_ORIGIN = 'source';
 export const META_ID_ORIGIN_SUFFIX = 'meta';

diff --git a/x-pack/legacy/plugins/maps/public/layers/sources/es_agg_source.d.ts b/x-pack/legacy/plugins/maps/public/layers/sources/es_agg_source.d.ts
@@ -8,7 +8,6 @@ import { IESSource } from './es_source';
 import { AbstractESSource } from './es_source';
 import { AGG_TYPE } from '../../../common/constants';
 
-
 export interface IESAggSource extends IESSource {
   getAggKey(aggType: AGG_TYPE, fieldName: string): string;
   getAggLabel(aggType: AGG_TYPE, fieldName: string): string;

diff --git a/x-pack/legacy/plugins/maps/public/layers/sources/es_agg_source.js b/x-pack/legacy/plugins/maps/public/layers/sources/es_agg_source.js
@@ -55,16 +55,9 @@ export class AbstractESAggSource extends AbstractESSource {
 
   getMetricFields() {
     const metrics = this._metricFields.filter(esAggField => esAggField.isValid());
-    if (metrics.length === 0) {
-      metrics.push(
-        new ESAggMetricField({
-          aggType: AGG_TYPE.COUNT,
-          source: this,
-          origin: this.getOriginForField(),
-        })
-      );
-    }
-    return metrics;
+    return metrics.length === 0
+      ? esAggFieldsFactory({ type: AGG_TYPE.COUNT }, this, this.getOriginForField())
+      : metrics;
   }
 
   getAggKey(aggType, fieldName) {

diff --git a/x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_style_property.js b/x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_style_property.js
@@ -98,7 +98,6 @@ export class DynamicStyleProperty extends AbstractStyleProperty {
 
   async getFieldMetaRequest() {
     if (this.isOrdinal()) {
-      const fieldMetaOptions = this.getFieldMetaOptions();
       return this._field.getOrdinalFieldMetaRequest();
     } else if (this.isCategorical()) {
       return this._field.getCategoricalFieldMetaRequest();