Skip to content

Commit

Permalink
[Security Solution][Data Views] - Update bulk actions data views inde…
Browse files Browse the repository at this point in the history
…x param to be snake_case (#138304)

## Summary

Overlooked a param name - should be snake case per our APIs. `overwriteDataViews` --> `overwrite_data_views`
  • Loading branch information
yctercero authored Aug 9, 2022
1 parent 9e690e6 commit bad17a1
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ const bulkActionEditPayloadIndexPatterns = t.intersection([
]),
value: index,
}),
t.exact(t.partial({ overwriteDataViews: t.boolean })),
t.exact(t.partial({ overwrite_data_views: t.boolean })),
]);

export type BulkActionEditPayloadIndexPatterns = t.TypeOf<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ const IndexPatternsFormComponent = ({
const payload = {
value: data.index,
type: data.overwrite ? BulkActionEditType.set_index_patterns : editAction,
overwriteDataViews: data.overwriteDataViews,
overwrite_data_views: data.overwriteDataViews,
};

onConfirm(payload);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const applyBulkActionEditToRuleParams = (
"Index patterns can't be added. Machine learning rule doesn't have index patterns property"
);

if (action.overwriteDataViews) {
if (action.overwrite_data_views) {
ruleParams.dataViewId = undefined;
}

Expand All @@ -59,7 +59,7 @@ const applyBulkActionEditToRuleParams = (
"Index patterns can't be overwritten. Machine learning rule doesn't have index patterns property"
);

if (action.overwriteDataViews) {
if (action.overwrite_data_views) {
ruleParams.dataViewId = undefined;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ export default ({ getService }: FtrProviderContext): void => {
{
type: BulkActionEditType.add_index_patterns,
value: ['initial-index-*'],
overwriteDataViews: true,
overwrite_data_views: true,
},
],
})
Expand Down

0 comments on commit bad17a1

Please sign in to comment.