-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(NA): do not remote cache npm directories copies on rules_nodejs v5 (
#130214) * fix(NA): bazel remote cache traffic * chore(NA): include local patch to fix the caches node_modules problem
- Loading branch information
Showing
2 changed files
with
17 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
src/dev/bazel/rules_nodejs_patches/exclude_npm_directory_copies_from_remote_cache.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
diff --git a/third_party/github.com/bazelbuild/bazel-skylib/rules/private/copy_file_private.bzl b/third_party/github.com/bazelbuild/bazel-skylib/rules/private/copy_file_private.bzl | ||
index a719174c..273322d0 100644 | ||
--- a/third_party/github.com/bazelbuild/bazel-skylib/rules/private/copy_file_private.bzl | ||
+++ b/third_party/github.com/bazelbuild/bazel-skylib/rules/private/copy_file_private.bzl | ||
@@ -30,7 +30,9 @@ _execution_requirements = { | ||
# Also, remote-execution does not allow source directory inputs, see | ||
# https://github.com/bazelbuild/bazel/commit/c64421bc35214f0414e4f4226cc953e8c55fa0d2 | ||
# So we must not attempt to execute remotely in that case. | ||
- "no-remote-exec": "1", | ||
+ # no-remote | Prevents the action or test from being executed remotely or cached remotely. | ||
+ # | This is equivalent to using both `no-remote-cache` and `no-remote-exec`. | ||
+ "no-remote": "1", | ||
} | ||
|
||
def _hash_file(file): |